Hello Thomas,
could you have a look at this patch a Debian user prepared for diffstat
manpage, and eventually commit it to the upstream code?

thanks!
On Tue, Apr 17, 2018 at 9:18 PM Bjarni Ingi Gislason <bjarn...@rhi.hi.is>
wrote:

> Package: diffstat
> Version: 1.61-1+b1
> Severity: minor
> Tags: patch

> Dear Maintainer,

> Input file is diffstat.1

> Test nr. 2:

> Enable and fix warnings from 'test-groff'.

> <diffstat.1>:82 (macro BI): only 1 argument, but more are expected
> <diffstat.1>:89 (macro BI): only 1 argument, but more are expected
> <diffstat.1>:185 (macro BI): only 1 argument, but more are expected

> chk_manuals: Output is from: test-groff -b -e -mandoc -T utf8 -rF0 -t -w
w -z

>    and

> Test nr. 15:

> Change the name of a macro for two fonts (e.g., BR and IR) to one
> letter, if there is only one argument.
> Add the second argument if needed.  It is sometimes part of the first
> one.

> 82:.BI \-d
> 89:.BI \-E
> 185:.BI \-s

> #####

> Test nr. 20:

> Use a macro to change to the italic font, instead of \fI [1], if
> possible.
> The macros have the italic corrections, but "\c" removes them
>    or
> add the italic corrections.
> [1] man-pages(7)

> 87:redirect standard error to \fIfile\fR.
> 150:redirect standard output to \fIfile\fR.

> #####

> Test nr. 27:

> Split lines longer than 80 characters into two or more lines.
> Appropriate break points are the end of a sentence and a subordinate
> clause.

> diffstat.1: line 30     length 84
> diffstat.1: line 195    length 85
> diffstat.1: line 204    length 87
> diffstat.1: line 251    length 82

> #####

> Test nr. 30:

> Surround a block of comments with the macros ".ig" and "..".
> The .\" (\#) at the beginning of each line is then not needed.
> Makes it easier to add and remove text and adjust length of lines.

> NO PATCH


1:.\"*****************************************************************************
> 2:.\" Copyright 1994-2014,2016 by Thomas E. Dickey
         *
> 3:.\" All Rights Reserved.
         *
> 4:.\"
        *
> 5:.\" Permission to use, copy, modify, and distribute this software and
its      *
> 6:.\" documentation for any purpose and without fee is hereby granted,
provided  *
> 7:.\" that the above copyright notice appear in all copies and that both
that    *
> 8:.\" copyright notice and this permission notice appear in supporting
         *
> 9:.\" documentation, and that the name of the above listed copyright
holder(s)   *
> 10:.\" not be used in advertising or publicity pertaining to distribution
of the  *
> 11:.\" software without specific, written prior permission.
         *
> 12:.\"
          *
> 13:.\" THE ABOVE LISTED COPYRIGHT HOLDER(S) DISCLAIM ALL WARRANTIES WITH
REGARD   *
> 14:.\" TO THIS SOFTWARE, INCLUDING ALL IMPLIED WARRANTIES OF
MERCHANTABILITY AND  *
> 15:.\" FITNESS, IN NO EVENT SHALL THE ABOVE LISTED COPYRIGHT HOLDER(S) BE
LIABLE  *
> 16:.\" FOR ANY SPECIAL, INDIRECT OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
          *
> 17:.\" WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN
AN      *
> 18:.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING
OUT OF OR *
> 19:.\" IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
          *

20:.\"*****************************************************************************
> 21:.\" $Id: diffstat.1,v 1.35 2016/01/14 09:39:26 tom Exp $

> #####

> Test nr. 40:

> Add a comma before "and", "or", or "nor" if a series contains three or
> more words

> 34:If the input filename ends with .bz2, .gz, .lzma, .z or .Z,
> 56:These are shown in the histogram as "+", "\-" and "!" characters.
> 195:changed lines found in the differences for each file: inserted,
deleted and modified.

> #####

>    Patch:

> --- diffstat.1  2018-04-17 23:46:52.000000000 +0000
> +++ diffstat.1.new      2018-04-17 23:03:20.000000000 +0000
> @@ -27,11 +27,12 @@
>   .SH DESCRIPTION
>   This program reads the output of \fBdiff\fP and displays a histogram
>   of the insertions, deletions, and modifications per-file.
> -\fBDiffstat\fP is a program that is useful for reviewing large, complex
patch files.
> +\fBDiffstat\fP is a program that is useful for reviewing large,
> +complex patch files.
>   It reads from one or more input files which contain output from
\fBdiff\fP,
>   producing a histogram of the total lines changed for each file
referenced.
>   .PP
> -If the input filename ends with .bz2, .gz, .lzma, .z or .Z,
> +If the input filename ends with .bz2, .gz, .lzma, .z, or .Z,
>   \fBdiffstat\fP will read the
>   uncompressed data via a pipe from the corresponding program.
>   It also can infer the compression type from files piped via the standard
input.
> @@ -53,7 +54,7 @@ not good for much, but simple to generat
>   tell which files are compared, and then counts the markers in the
>   first column that denote the type of change (insertion, deletion
>   or modification).
> -These are shown in the histogram as "+", "\-" and "!" characters.
> +These are shown in the histogram as "+", "\-", and "!" characters.
>   .PP
>   If no filename is given on the command line,
>   \fBdiffstat\fP reads the differences from the standard input.
> @@ -79,14 +80,15 @@ to obtain the total number of lines in e
>   The remainder, after subtracting modified and deleted lines,
>   is shown as "unchanged lines".
>   .TP
> -.BI \-d
> +.B \-d
>   The debug prints a lot of information.
>   It is normally compiled-in, but can be suppressed.
>   .TP
>   .BI \-e " file"
> -redirect standard error to \fIfile\fR.
> +redirect standard error to
> +.IR file .
>   .TP
> -.BI \-E
> +.B \-E
>   strip out ANSI escape sequences on each line before parsing the
differences.
>   This allows \fBdiffstat\fP to be used with \fBcolordiff\fP.
>   .TP
> @@ -97,7 +99,7 @@ specify the format of the histogram.
>   0
>   for concise, which shows only the value and a single histogram code for
each of
>   insert (+),
> -delete (\-) or
> +delete (\-), or
>   modify (!)
>   .TP 3
>   1
> @@ -147,7 +149,8 @@ Names longer than this limit are truncat
>   If you do not specify this, \fBdiffstat\fP next checks the \fB\-n\fP
option.
>   .TP
>   .BI \-o " file"
> -redirect standard output to \fIfile\fR.
> +redirect standard output to
> +.IR file .
>   .TP
>   .BI \-p " number"
>   override the logic that strips common pathnames, simulating the
\fBpatch\fP
> @@ -182,7 +185,7 @@ those would normally be rounded to zero.
>   .B \-R
>   Assume patch was created with old and new files swapped.
>   .TP
> -.BI \-s
> +.B \-s
>   show only the summary line, e.g., number of insertions and deletions.
>   .TP
>   .BI \-S " source"
> @@ -192,7 +195,8 @@ the original files (before applying diff
>   .B \-t
>   overrides the histogram,
>   generates output of comma separated values for the number of
> -changed lines found in the differences for each file: inserted, deleted
and modified.
> +changed lines found in the differences for each file: inserted,
> +deleted, and modified.
>   .IP
>   If \fB\-S\fP or \fB\-D\fP options are given, the number of unchanged
>   lines precedes the number of changes.
> @@ -201,7 +205,8 @@ lines precedes the number of changes.
>   prints the numbers that the \fB\-t\fP option would show,
>   between the pathname and histogram.
>   .IP
> -The width of the number of changes is determined by the largest value
(but at least 3).
> +The width of the number of changes is determined by the largest value
> +(but at least 3).
>   The width given in the \fB\-w\fP option is separate from the width of
these
>   numbers.
>   .TP
> @@ -248,7 +253,10 @@ same command-line options, e.g., "\-c" t
>   \fBDiffstat\fP is a single binary module, which uses no auxiliary files.
>   .SH BUGS
>   .PP
> -\fBDiffstat\fP makes a lot of assumptions about the format of
\fBdiff\fP's output.
> +.B Diffstat
> +makes a lot of assumptions about the format of
> +.BR diff 's
> +output.
>   .PP
>   There is no way to obtain a filename from the standard \fBdiff\fP between
>   two files with no options.



> -- System Information:
> Debian Release: buster/sid
>    APT prefers stable-updates
>    APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500,
'testing'), (500, 'stable')
> Architecture: amd64 (x86_64)

> Kernel: Linux 4.9.82-1u3 (SMP w/2 CPU cores)
> Locale: LANG=is_IS.iso88591, LC_CTYPE=is_IS.iso88591
(charmap=ISO-8859-1), LANGUAGE=is_IS.iso88591 (charmap=ISO-8859-1)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)

> Versions of packages diffstat depends on:
> ii  libc6  2.27-3

> diffstat recommends no packages.

> diffstat suggests no packages.

> -- no debconf information

> --
> Bjarni I. Gislason



-- 
Sandro "morph" Tosi
My website: http://sandrotosi.me/
Me at Debian: http://wiki.debian.org/SandroTosi
G+: https://plus.google.com/u/0/+SandroTosi

Reply via email to