Control: tags -1 + patch

On 2018-05-13 09:06 +0200, Sven Joachim wrote:

> Package: powertop
> Version: 2.8-1+b2
> Severity: minor
> Tags: upstream
>
> The powertop binary is linked with both -lncursesw and -lncurses which
> does not make sense, since the latter is redundant.  This is noticed by
> dpkg-shlibdeps:
>
> ,----
> | dpkg-shlibdeps: warning: package could avoid a useless dependency if
> debian/powertop/usr/sbin/powertop was not linked against
> libncurses.so.6 (it uses none of the library's symbols)
> `----
>
> Will try to work out a patch as soon as I have the bug number.

The attached patch fixes that.  Should probably be forwarded/discussed
upstream as well.

Description: Do not link with ncurses unnecessarily
 Linking with both ncursesw and ncurses is redundant.
Author: Sven Joachim <svenj...@gmx.de>
Bug-Debian: https://bugs.debian.org/898533

---
--- powertop-2.8.orig/configure.ac
+++ powertop-2.8/configure.ac
@@ -106,9 +106,9 @@ AC_CHECK_FUNCS([ \
 	strtoull \
 ])
 
-PKG_CHECK_MODULES([NCURSES], [ncursesw ncurses], [LIBS="$LIBS $ncurses_LIBS"], [
-	AC_SEARCH_LIBS([delwin], [ncursesw ncurses], [], [
-		AC_MSG_ERROR([ncurses is required but was not found])
+PKG_CHECK_MODULES([NCURSES], [ncursesw], [LIBS="$LIBS $ncurses_LIBS"], [
+	AC_SEARCH_LIBS([delwin], [ncursesw], [], [
+		AC_MSG_ERROR([ncursesw is required but was not found])
 	], [])
 ])
 

Reply via email to