On Thu, May 10, 2018 at 07:32:54PM +0900, Mike Hommey wrote: > [snip] > > CPPFLAGS missing (-D_FORTIFY_SOURCE=2): /usr/bin/gcc -std=gnu99 -o > xptcinvoke_asm_x86_64_unix.o -DNDEBUG=1 -DTRIMMED=1 > -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API > -DIMPL_LIBXUL -g -fPIC -Wa,--noexecstack -include > /<<PKGBUILDDIR>>/build-browser/mozilla-config.h -DMOZILLA_CLIENT -g > -I/<<PKGBUILDDIR>>/xpcom/reflect/xptcall > -I/<<PKGBUILDDIR>>/xpcom/reflect/xptinfo -c > /<<PKGBUILDDIR>>/xpcom/reflect/xptcall/md/unix/xptcinvoke_asm_x86_64_unix.S > > [snip] > > Sure, -F_FORTIFY_SOURCE=2 *is* missing on those command lines, but it's > also, afaik, irrelevant when compiling assembly files (.S), even if they > are preprocessed.
Hey Mike, True, fortify source will very likely not be used by assembly files so this looks like a false positive. However blhc doesn't treat fortify source specially and tracks the use of all CPPFLAGS. As .S files are preprocessed it expects all CPPFLAGS to be present. So this report from blhc is valid (even though it might be confusing). Adding CPPFLAGS is the correct fix for this issue. Regards Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
signature.asc
Description: PGP signature
