On Mon, Apr 30, 2018 at 9:02 AM, Emmanuel Bourg <ebo...@apache.org> wrote: > Thank you fo the update. I'm attaching the revised patch since it wasn't > sent to the bug log.
Thanks! > I suggest also setting the -release parameter when the VM is forked. > Since the plexus-compiler package is only used to build Debian packages > with the default JDK there is no risk of calling a JDK that doesn't > support the new parameter. Right, I was not sure if that was the case - that is: 1) used only by debian builds and 2) that the default-jdk would be used for a fork. In particular, when setting "fork" the user also has the option to set a few other properties, such as "executable", "compilerArgs", "compilerVersion", etc which can change the behavior quite a lot. Do we have packages that are currently setting the fork option? I would like to take a look at a few examples to get on overview of what else is being set (and maybe why) before committing any changes to the way the patch deals with a fork. > Also no need to print the deprecation message for the source/target > parameters, this is Debian specific and we aren't going to reconfigure > all upstream projects ourself anyway. Ack. Thanks for the help and for the review. -- Tiago Stürmer Daitx Software Engineer tiago.da...@canonical.com PGP Key: 4096R/F5B213BE (hkp://keyserver.ubuntu.com) Fingerprint = 45D0 FE5A 8109 1E91 866E 8CA4 1931 8D5E F5B2 13BE
