On Thu, Apr 26, 2018 at 01:33:33PM +0800, Paul Wise wrote: > Subsequently I looked up how > to add new formats to diffoscope and found it was fairly easy.
:)
> If the attached patch is acceptable, let me know and I'll push the
> OpenPGP-signed version of the commit.
First please:
* add a test
* expand that TODO item, I can't understand what it is about
* wrap the long lines the way pep8 teaches
* explain why the external_tools.py's dict lists both edid-decode and
read-edid, but in the build-dep are made as alternatives
--
regards,
Mattia Rizzolo
GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`.
more about me: https://mapreri.org : :' :
Launchpad user: https://launchpad.net/~mapreri `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
