Hi Chris,

> I just ACCEPTed dlib from NEW but noticed it was missing attribution 
> in debian/copyright for at least assert.h, numerical_integration.cpp,
> fhog.h, and possibly all of dlib-models, I am unsure..
> 
> (This is in no way exhaustive so please check over the entire package 
> carefully and address these on your next upload.)

Right, we didn't notice these dlib/ files:

 setup.py: Copyright (C) 2015  Ehsan Azar (dash...@linux.com)

 dlib/sockets/sockets_kernel_1.cpp:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg
 dlib/sockets/sockets_kernel_2.h:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg
 dlib/sockets/sockets_kernel_1.h:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg
 dlib/sockets/sockets_kernel_2.cpp:// Copyright (C) 2003  Davis E. King 
(da...@dlib.net), Miguel Grinberg

 dlib/matlab/mex_wrapper.cpp:// Copyright (C) 2012 Massachusetts Institute of 
Technology, Lincoln Laboratory
 dlib/matlab/mex_wrapper.cpp:// Copyright (C) 2012 Massachusetts Institute of 
Technology, Lincoln Laboratory
 dlib/matlab/call_matlab.h:// Copyright (C) 2012 Massachusetts Institute of 
Technology, Lincoln Laboratory

 dlib/gui_widgets/nativefont.h:// Copyright (C) 2006 Keita Mochizuki 

 dlib/gui_core/gui_core_kernel_2.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_core/gui_core_kernel_2.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_core/gui_core_kernel_1.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki 
 dlib/gui_core/gui_core_kernel_1.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/base_widgets.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_core/gui_core_kernel_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/widgets.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/widgets.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/drawable.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/widgets_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/drawable.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/base_widgets.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/gui_widgets/base_widgets_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Keita Mochizuki
 dlib/unicode/unicode.cpp:// Copyright (C) 2008 Keita Mochizuki, Davis E. King 
(da...@dlib.net)

 dlib/gui_widgets/fonts_abstract.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), Nils Labugt, Keita Mochizuki
 dlib/gui_widgets/fonts.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt, Keita Mochizuki
 dlib/gui_widgets/fonts.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt, Keita Mochizuki

 dlib/test/numerical_integration.cpp:// Copyright (C) 2013 Steve Taylor 
(steve98...@gmail.com)
 dlib/numerical_integration.h:// Copyright (C) 2013 Steve Taylor 
(steve98...@gmail.com)
 dlib/numerical_integration/integrate_function_adapt_simpson.h:// Copyright (C) 
2013 Steve Taylor (steve98...@gmail.com)
 dlib/numerical_integration/integrate_function_adapt_simpson_abstract.h:// 
Copyright (C) 2013 Steve Taylor (steve98...@gmail.com)

 dlib/statistics/statistics.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Steve Taylor
 dlib/statistics/statistics_abstract.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Steve Taylor
 dlib/numeric_constants.h://Copyright (C) 2013 Steve Taylor 
(steve98...@gmail.com), Davis E. King

 dlib/matrix/lapack/fortran_id.h://  Copyright (C) 2002, 2003 Si-Lab b.v.b.a., 
Toon Knapen and Kresimir Fresl 

 dlib/image_loader/jpeg_loader.h:// Copyright (C) 2010  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/png_loader.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/png_loader.cpp:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/png_loader_abstract.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/jpeg_loader.cpp:// Copyright (C) 2010  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/gui_widgets/canvas_drawing_abstract.h:// Copyright (C) 2005  Davis E. 
King (da...@dlib.net), and Nils Labugt
 dlib/image_loader/load_image_abstract.h:// Copyright (C) 2011  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/image_loader/jpeg_loader_abstract.h:// Copyright (C) 2010  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/gui_widgets/canvas_drawing.h:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt
 dlib/gui_widgets/style.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), and Nils Labugt
 dlib/gui_widgets/style.cpp:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), and Nils Labugt
 dlib/image_saver/save_jpeg.cpp:// Copyright (C) 2014  Davis E. King 
(da...@dlib.net), Nils Labugt
 dlib/gui_widgets/canvas_drawing.cpp:// Copyright (C) 2005  Davis E. King 
(da...@dlib.net), and Nils Labugt
 dlib/gui_widgets/style_abstract.h:// Copyright (C) 2008  Davis E. King 
(da...@dlib.net), and Nils Labugt
 dlib/unicode/unicode.h:// Copyright (C) 2007  Davis E. King (da...@dlib.net), 
and Nils Labugt
 dlib/unicode/unicode_abstract.h:// Copyright (C) 2007  Davis E. King 
(da...@dlib.net), and Nils Labugt

 dlib/image_loader/load_image.h:// Copyright (C) 2011  Davis E. King 
(da...@dlib.net), Nils Labugt, Changjiang Yang (yang...@leidos.com)

 dlib/optimization/optimization_bobyqa.h:// Copyright (C) 2009 M.J.D. Powell, 
Davis E. King (da...@dlib.net)

 dlib/statistics/sammon.h:// Copyright (C) 2012  Emanuele Cesena 
(emanuele.ces...@gmail.com), Davis E. King
 dlib/statistics/sammon_abstract.h:// Copyright (C) 2012  Emanuele Cesena 
(emanuele.ces...@gmail.com), Davis E. King

 dlib/enable_if.h:// Copyright 2003 (C) The Trustees of Indiana University.

 dlib/image_transforms/fhog.h:                Copyright (C) 2011, 2012 Ross 
Girshick, Pedro Felzenszwalb
 dlib/image_transforms/fhog.h:                Copyright (C) 2008, 2009, 2010 
Pedro Felzenszwalb, Ross Girshick

 dlib/image_transforms/fhog.h:                Copyright (C) 2007 Pedro 
Felzenszwalb, Deva Ramanan

 dlib/noncopyable.h://  (C) Copyright Beman Dawes 1999-2003. Distributed under 
the Boost

 dlib/assert.h://  (C) Copyright John Maddock 2001 - 2003.

 dlib/assert.h://  (C) Copyright Darin Adler 2001.

 dlib/assert.h://  (C) Copyright Peter Dimov 2001.

 dlib/assert.h://  (C) Copyright Bill Kempf 2002.

 dlib/assert.h://  (C) Copyright Jens Maurer 2002.

 dlib/assert.h://  (C) Copyright David Abrahams 2002 - 2003.

 dlib/assert.h://  (C) Copyright Gennaro Prota 2003.

 dlib/assert.h://  (C) Copyright Eric Friedman 2003.

 dlib/server/server_http_abstract.h:// Copyright (C) 2006  Davis E. King 
(da...@dlib.net), Steven Van Ingelgem
 dlib/server/server_http.h:// Copyright (C) 2006  Davis E. King 
(da...@dlib.net), Steven Van Ingelgem

Concerning the dlib models, there is nothing wrong IMO. The only issue
is:

 Files: */shape_predictor_68_face_landmarks.dat
 Copyright: 2015-2016 Davis E King <da...@dlib.net>
 License: Creative-Commons-0-1.0

should rather be

 Files: dlib-models/shape_predictor_68_face_landmarks.dat
 Copyright: 2015-2016 Davis E King <da...@dlib.net>
 License: Creative-Commons-0-1.0

but it is nitpicking because anyways
*/shape_predictor_68_face_landmarks.dat matches
dlib-models/shape_predictor_68_face_landmarks.dat

I'll upload a fixed d/copyright asap.

Thanks.

Cheers,
 Hugo

-- 
             Hugo Lefeuvre (hle)    |    www.owl.eu.com
4096/ 9C4F C8BF A4B0 8FC5 48EB 56B8 1962 765B B9A8 BACA

Attachment: signature.asc
Description: PGP signature

Reply via email to