Michel Bouissou <mic...@bouissou.net> writes: > After a more thourough dive in GPGME logs, it is now crystal clear to > me that the matter is that GPG is unable to import the key data that > GPGME tries to feed into it at key import time. > > Here is the result of the GPG secret key import (working) inside the > chroot : > > [GNUPG:] KEY_CONSIDERED <key_id>. > [GNUPG:] IMPORTED <key_name>. > [GNUPG:] IMPORT_OK 1 <key_id>. > [GNUPG:] IMPORT_RES 1 0 1 0 0 0 0 0 0 1 1 0 0 0 0 > > - Count : 1 > - Imported : 1 > - Sec Read : 1 > - Sec Imported : 1 > > And now the failing one from initramfs : > > [GNUPG:] IMPORT_RES 1 1 0 0 0 0 0 0 0 1 0 0 0 0 0. > > - Count : 1 > - No_User_ID : 1 > - Imported : 0 > - Sec Read : 1 > - Sec Imported : 0 > > IMPORT_RES <count> <no_user_id> <imported> <imported_rsa> <unchanged> > <n_uids> <n_subk> <n_sigs> <n_revoc> <sec_read> <sec_imported> > <sec_dups> <not_imported> <skipped_new_keys> > > However it further seems to properly receive the encrypted data, but > is unable to decrypt it because it has no keys. > > I have no clue about why, and what the difference can be, but I need a > break for now as I have spent my entire sunday wrestling with this :-\
I've added, to the latest revision of mandos-client.c in trunk, an additional check for errors in the GPGME key importing code, and lots of code for outputting whatever GPGME says went wrong. Latest revision of mandos-client.c, and a bare diff with just this change, are attached. This should hopefully show what GPGME thinks is the problem. Whatever it is, it can't be a problem reading the key files, because we can import them into GnuTLS just fine. It must, I think, be some problem with writing or locking the GPGME keyring files, which is why I'm still leaing towards the unwriteable /tmp problem, or something very much like it. /Teddy Hogeborn -- The Mandos Project https://www.recompile.se/mandos
/* -*- coding: utf-8 -*- */ /* * Mandos-client - get and decrypt data from a Mandos server * * This program is partly derived from an example program for an Avahi * service browser, downloaded from * <http://avahi.org/browser/examples/core-browse-services.c>. This * includes the following functions: "resolve_callback", * "browse_callback", and parts of "main". * * Everything else is * Copyright © 2008-2018 Teddy Hogeborn * Copyright © 2008-2018 Björn Påhlsson * * This file is part of Mandos. * * Mandos is free software: you can redistribute it and/or modify it * under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * * Mandos is distributed in the hope that it will be useful, but * WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * General Public License for more details. * * You should have received a copy of the GNU General Public License * along with Mandos. If not, see <http://www.gnu.org/licenses/>. * * Contact the authors at <man...@recompile.se>. */ /* Needed by GPGME, specifically gpgme_data_seek() */ #ifndef _LARGEFILE_SOURCE #define _LARGEFILE_SOURCE #endif /* not _LARGEFILE_SOURCE */ #ifndef _FILE_OFFSET_BITS #define _FILE_OFFSET_BITS 64 #endif /* not _FILE_OFFSET_BITS */ #define _GNU_SOURCE /* TEMP_FAILURE_RETRY(), asprintf() */ #include <stdio.h> /* fprintf(), stderr, fwrite(), stdout, ferror() */ #include <stdint.h> /* uint16_t, uint32_t, intptr_t */ #include <stddef.h> /* NULL, size_t, ssize_t */ #include <stdlib.h> /* free(), EXIT_SUCCESS, srand(), strtof(), abort() */ #include <stdbool.h> /* bool, false, true */ #include <string.h> /* strcmp(), strlen(), strerror(), asprintf(), strncpy(), strsignal() */ #include <sys/ioctl.h> /* ioctl */ #include <sys/types.h> /* socket(), inet_pton(), sockaddr, sockaddr_in6, PF_INET6, SOCK_STREAM, uid_t, gid_t, open(), opendir(), DIR */ #include <sys/stat.h> /* open(), S_ISREG */ #include <sys/socket.h> /* socket(), struct sockaddr_in6, inet_pton(), connect(), getnameinfo() */ #include <fcntl.h> /* open(), unlinkat(), AT_REMOVEDIR */ #include <dirent.h> /* opendir(), struct dirent, readdir() */ #include <inttypes.h> /* PRIu16, PRIdMAX, intmax_t, strtoimax() */ #include <errno.h> /* perror(), errno, EINTR, EINVAL, EAI_SYSTEM, ENETUNREACH, EHOSTUNREACH, ECONNREFUSED, EPROTO, EIO, ENOENT, ENXIO, ENOMEM, EISDIR, ENOTEMPTY, program_invocation_short_name */ #include <time.h> /* nanosleep(), time(), sleep() */ #include <net/if.h> /* ioctl, ifreq, SIOCGIFFLAGS, IFF_UP, SIOCSIFFLAGS, if_indextoname(), if_nametoindex(), IF_NAMESIZE */ #include <netinet/in.h> /* IN6_IS_ADDR_LINKLOCAL, INET_ADDRSTRLEN, INET6_ADDRSTRLEN */ #include <unistd.h> /* close(), SEEK_SET, off_t, write(), getuid(), getgid(), seteuid(), setgid(), pause(), _exit(), unlinkat() */ #include <arpa/inet.h> /* inet_pton(), htons() */ #include <iso646.h> /* not, or, and */ #include <argp.h> /* struct argp_option, error_t, struct argp_state, struct argp, argp_parse(), ARGP_KEY_ARG, ARGP_KEY_END, ARGP_ERR_UNKNOWN */ #include <signal.h> /* sigemptyset(), sigaddset(), sigaction(), SIGTERM, sig_atomic_t, raise() */ #include <sysexits.h> /* EX_OSERR, EX_USAGE, EX_UNAVAILABLE, EX_NOHOST, EX_IOERR, EX_PROTOCOL */ #include <sys/wait.h> /* waitpid(), WIFEXITED(), WEXITSTATUS(), WTERMSIG() */ #include <grp.h> /* setgroups() */ #include <argz.h> /* argz_add_sep(), argz_next(), argz_delete(), argz_append(), argz_stringify(), argz_add(), argz_count() */ #include <netdb.h> /* getnameinfo(), NI_NUMERICHOST, EAI_SYSTEM, gai_strerror() */ #ifdef __linux__ #include <sys/klog.h> /* klogctl() */ #endif /* __linux__ */ /* Avahi */ /* All Avahi types, constants and functions Avahi*, avahi_*, AVAHI_* */ #include <avahi-core/core.h> #include <avahi-core/lookup.h> #include <avahi-core/log.h> #include <avahi-common/simple-watch.h> #include <avahi-common/malloc.h> #include <avahi-common/error.h> /* GnuTLS */ #include <gnutls/gnutls.h> /* All GnuTLS types, constants and functions: gnutls_* init_gnutls_session(), GNUTLS_* */ #include <gnutls/openpgp.h> /* gnutls_certificate_set_openpgp_key_file(), GNUTLS_OPENPGP_FMT_BASE64 */ /* GPGME */ #include <gpgme.h> /* All GPGME types, constants and functions: gpgme_* GPGME_PROTOCOL_OpenPGP, GPG_ERR_NO_* */ #define BUFFER_SIZE 256 #define PATHDIR "/conf/conf.d/mandos" #define SECKEY "seckey.txt" #define PUBKEY "pubkey.txt" #define HOOKDIR "/lib/mandos/network-hooks.d" bool debug = false; static const char mandos_protocol_version[] = "1"; const char *argp_program_version = "mandos-client " VERSION; const char *argp_program_bug_address = "<man...@recompile.se>"; static const char sys_class_net[] = "/sys/class/net"; char *connect_to = NULL; const char *hookdir = HOOKDIR; int hookdir_fd = -1; uid_t uid = 65534; gid_t gid = 65534; /* Doubly linked list that need to be circularly linked when used */ typedef struct server{ const char *ip; in_port_t port; AvahiIfIndex if_index; int af; struct timespec last_seen; struct server *next; struct server *prev; } server; /* Used for passing in values through the Avahi callback functions */ typedef struct { AvahiServer *server; gnutls_certificate_credentials_t cred; unsigned int dh_bits; gnutls_dh_params_t dh_params; const char *priority; gpgme_ctx_t ctx; server *current_server; char *interfaces; size_t interfaces_size; } mandos_context; /* global so signal handler can reach it*/ AvahiSimplePoll *simple_poll; sig_atomic_t quit_now = 0; int signal_received = 0; /* Function to use when printing errors */ void perror_plus(const char *print_text){ int e = errno; fprintf(stderr, "Mandos plugin %s: ", program_invocation_short_name); errno = e; perror(print_text); } __attribute__((format (gnu_printf, 2, 3), nonnull)) int fprintf_plus(FILE *stream, const char *format, ...){ va_list ap; va_start (ap, format); TEMP_FAILURE_RETRY(fprintf(stream, "Mandos plugin %s: ", program_invocation_short_name)); return (int)TEMP_FAILURE_RETRY(vfprintf(stream, format, ap)); } /* * Make additional room in "buffer" for at least BUFFER_SIZE more * bytes. "buffer_capacity" is how much is currently allocated, * "buffer_length" is how much is already used. */ __attribute__((nonnull, warn_unused_result)) size_t incbuffer(char **buffer, size_t buffer_length, size_t buffer_capacity){ if(buffer_length + BUFFER_SIZE > buffer_capacity){ char *new_buf = realloc(*buffer, buffer_capacity + BUFFER_SIZE); if(new_buf == NULL){ int old_errno = errno; free(*buffer); errno = old_errno; *buffer = NULL; return 0; } *buffer = new_buf; buffer_capacity += BUFFER_SIZE; } return buffer_capacity; } /* Add server to set of servers to retry periodically */ __attribute__((nonnull, warn_unused_result)) bool add_server(const char *ip, in_port_t port, AvahiIfIndex if_index, int af, server **current_server){ int ret; server *new_server = malloc(sizeof(server)); if(new_server == NULL){ perror_plus("malloc"); return false; } *new_server = (server){ .ip = strdup(ip), .port = port, .if_index = if_index, .af = af }; if(new_server->ip == NULL){ perror_plus("strdup"); free(new_server); return false; } ret = clock_gettime(CLOCK_MONOTONIC, &(new_server->last_seen)); if(ret == -1){ perror_plus("clock_gettime"); #ifdef __GNUC__ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wcast-qual" #endif free((char *)(new_server->ip)); #ifdef __GNUC__ #pragma GCC diagnostic pop #endif free(new_server); return false; } /* Special case of first server */ if(*current_server == NULL){ new_server->next = new_server; new_server->prev = new_server; *current_server = new_server; } else { /* Place the new server last in the list */ new_server->next = *current_server; new_server->prev = (*current_server)->prev; new_server->prev->next = new_server; (*current_server)->prev = new_server; } return true; } /* * Initialize GPGME. */ __attribute__((nonnull, warn_unused_result)) static bool init_gpgme(const char * const seckey, const char * const pubkey, const char * const tempdir, mandos_context *mc){ gpgme_error_t rc; gpgme_engine_info_t engine_info; /* * Helper function to insert pub and seckey to the engine keyring. */ bool import_key(const char * const filename){ int ret; int fd; gpgme_data_t pgp_data; fd = (int)TEMP_FAILURE_RETRY(open(filename, O_RDONLY)); if(fd == -1){ perror_plus("open"); return false; } rc = gpgme_data_new_from_fd(&pgp_data, fd); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_data_new_from_fd: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); return false; } rc = gpgme_op_import(mc->ctx, pgp_data); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_op_import: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); return false; } { gpgme_import_result_t import_result = gpgme_op_import_result(mc->ctx); if((import_result->imported < 1 or import_result->not_imported > 0) and import_result->unchanged == 0){ fprintf_plus(stderr, "bad gpgme_op_import_results:\n"); fprintf_plus(stderr, "The total number of considered keys: %d\n", import_result->considered); fprintf_plus(stderr, "The number of keys without user ID: %d\n", import_result->no_user_id); fprintf_plus(stderr, "The total number of imported keys: %d\n", import_result->imported); fprintf_plus(stderr, "The number of imported RSA keys: %d\n", import_result->imported_rsa); fprintf_plus(stderr, "The number of unchanged keys: %d\n", import_result->unchanged); fprintf_plus(stderr, "The number of new user IDs: %d\n", import_result->new_user_ids); fprintf_plus(stderr, "The number of new sub keys: %d\n", import_result->new_sub_keys); fprintf_plus(stderr, "The number of new signatures: %d\n", import_result->new_signatures); fprintf_plus(stderr, "The number of new revocations: %d\n", import_result->new_revocations); fprintf_plus(stderr, "The total number of secret keys read: %d\n", import_result->secret_read); fprintf_plus(stderr, "The number of imported secret keys: %d\n", import_result->secret_imported); fprintf_plus(stderr, "The number of unchanged secret keys: %d\n", import_result->secret_unchanged); fprintf_plus(stderr, "The number of keys not imported: %d\n", import_result->not_imported); for(gpgme_import_status_t import_status = import_result->imports; import_status != NULL; import_status = import_status->next){ fprintf_plus(stderr, "Import status for key: %s\n", import_status->fpr); if(import_status->result != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "Import result: %s: %s\n", gpgme_strsource(import_status->result), gpgme_strerror(import_status->result)); } fprintf_plus(stderr, "Key status:\n"); fprintf_plus(stderr, import_status->status & GPGME_IMPORT_NEW ? "The key was new.\n" : "The key was not new.\n"); fprintf_plus(stderr, import_status->status & GPGME_IMPORT_UID ? "The key contained new user IDs.\n" : "The key did not contain new user IDs.\n"); fprintf_plus(stderr, import_status->status & GPGME_IMPORT_SIG ? "The key contained new signatures.\n" : "The key did not contain new signatures.\n"); fprintf_plus(stderr, import_status->status & GPGME_IMPORT_SUBKEY ? "The key contained new sub keys.\n" : "The key did not contain new sub keys.\n"); fprintf_plus(stderr, import_status->status & GPGME_IMPORT_SECRET ? "The key contained a secret key.\n" : "The key did not contain a secret key.\n"); } return false; } } ret = close(fd); if(ret == -1){ perror_plus("close"); } gpgme_data_release(pgp_data); return true; } if(debug){ fprintf_plus(stderr, "Initializing GPGME\n"); } /* Init GPGME */ gpgme_check_version(NULL); rc = gpgme_engine_check_version(GPGME_PROTOCOL_OpenPGP); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_engine_check_version: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); return false; } /* Set GPGME home directory for the OpenPGP engine only */ rc = gpgme_get_engine_info(&engine_info); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_get_engine_info: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); return false; } while(engine_info != NULL){ if(engine_info->protocol == GPGME_PROTOCOL_OpenPGP){ gpgme_set_engine_info(GPGME_PROTOCOL_OpenPGP, engine_info->file_name, tempdir); break; } engine_info = engine_info->next; } if(engine_info == NULL){ fprintf_plus(stderr, "Could not set GPGME home dir to %s\n", tempdir); return false; } /* Create new GPGME "context" */ rc = gpgme_new(&(mc->ctx)); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_new: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); return false; } if(not import_key(pubkey) or not import_key(seckey)){ return false; } return true; } /* * Decrypt OpenPGP data. * Returns -1 on error */ __attribute__((nonnull, warn_unused_result)) static ssize_t pgp_packet_decrypt(const char *cryptotext, size_t crypto_size, char **plaintext, mandos_context *mc){ gpgme_data_t dh_crypto, dh_plain; gpgme_error_t rc; ssize_t ret; size_t plaintext_capacity = 0; ssize_t plaintext_length = 0; if(debug){ fprintf_plus(stderr, "Trying to decrypt OpenPGP data\n"); } /* Create new GPGME data buffer from memory cryptotext */ rc = gpgme_data_new_from_mem(&dh_crypto, cryptotext, crypto_size, 0); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_data_new_from_mem: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); return -1; } /* Create new empty GPGME data buffer for the plaintext */ rc = gpgme_data_new(&dh_plain); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_data_new: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); gpgme_data_release(dh_crypto); return -1; } /* Decrypt data from the cryptotext data buffer to the plaintext data buffer */ rc = gpgme_op_decrypt(mc->ctx, dh_crypto, dh_plain); if(rc != GPG_ERR_NO_ERROR){ fprintf_plus(stderr, "bad gpgme_op_decrypt: %s: %s\n", gpgme_strsource(rc), gpgme_strerror(rc)); plaintext_length = -1; if(debug){ gpgme_decrypt_result_t result; result = gpgme_op_decrypt_result(mc->ctx); if(result == NULL){ fprintf_plus(stderr, "gpgme_op_decrypt_result failed\n"); } else { if(result->unsupported_algorithm != NULL) { fprintf_plus(stderr, "Unsupported algorithm: %s\n", result->unsupported_algorithm); } fprintf_plus(stderr, "Wrong key usage: %s\n", result->wrong_key_usage ? "Yes" : "No"); if(result->file_name != NULL){ fprintf_plus(stderr, "File name: %s\n", result->file_name); } gpgme_recipient_t recipient; recipient = result->recipients; while(recipient != NULL){ fprintf_plus(stderr, "Public key algorithm: %s\n", gpgme_pubkey_algo_name (recipient->pubkey_algo)); fprintf_plus(stderr, "Key ID: %s\n", recipient->keyid); fprintf_plus(stderr, "Secret key available: %s\n", recipient->status == GPG_ERR_NO_SECKEY ? "No" : "Yes"); recipient = recipient->next; } } } goto decrypt_end; } if(debug){ fprintf_plus(stderr, "Decryption of OpenPGP data succeeded\n"); } /* Seek back to the beginning of the GPGME plaintext data buffer */ if(gpgme_data_seek(dh_plain, (off_t)0, SEEK_SET) == -1){ perror_plus("gpgme_data_seek"); plaintext_length = -1; goto decrypt_end; } *plaintext = NULL; while(true){ plaintext_capacity = incbuffer(plaintext, (size_t)plaintext_length, plaintext_capacity); if(plaintext_capacity == 0){ perror_plus("incbuffer"); plaintext_length = -1; goto decrypt_end; } ret = gpgme_data_read(dh_plain, *plaintext + plaintext_length, BUFFER_SIZE); /* Print the data, if any */ if(ret == 0){ /* EOF */ break; } if(ret < 0){ perror_plus("gpgme_data_read"); plaintext_length = -1; goto decrypt_end; } plaintext_length += ret; } if(debug){ fprintf_plus(stderr, "Decrypted password is: "); for(ssize_t i = 0; i < plaintext_length; i++){ fprintf(stderr, "%02hhX ", (*plaintext)[i]); } fprintf(stderr, "\n"); } decrypt_end: /* Delete the GPGME cryptotext data buffer */ gpgme_data_release(dh_crypto); /* Delete the GPGME plaintext data buffer */ gpgme_data_release(dh_plain); return plaintext_length; } __attribute__((warn_unused_result, const)) static const char *safe_string(const char *str){ if(str == NULL) return "(unknown)"; return str; } __attribute__((warn_unused_result)) static const char *safer_gnutls_strerror(int value){ const char *ret = gnutls_strerror(value); return safe_string(ret); } /* GnuTLS log function callback */ __attribute__((nonnull)) static void debuggnutls(__attribute__((unused)) int level, const char* string){ fprintf_plus(stderr, "GnuTLS: %s", string); } __attribute__((nonnull(1, 2, 4), warn_unused_result)) static int init_gnutls_global(const char *pubkeyfilename, const char *seckeyfilename, const char *dhparamsfilename, mandos_context *mc){ int ret; unsigned int uret; if(debug){ fprintf_plus(stderr, "Initializing GnuTLS\n"); } if(debug){ /* "Use a log level over 10 to enable all debugging options." * - GnuTLS manual */ gnutls_global_set_log_level(11); gnutls_global_set_log_function(debuggnutls); } /* OpenPGP credentials */ ret = gnutls_certificate_allocate_credentials(&mc->cred); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "GnuTLS memory error: %s\n", safer_gnutls_strerror(ret)); return -1; } if(debug){ fprintf_plus(stderr, "Attempting to use OpenPGP public key %s and" " secret key %s as GnuTLS credentials\n", pubkeyfilename, seckeyfilename); } ret = gnutls_certificate_set_openpgp_key_file (mc->cred, pubkeyfilename, seckeyfilename, GNUTLS_OPENPGP_FMT_BASE64); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error[%d] while reading the OpenPGP key pair ('%s'," " '%s')\n", ret, pubkeyfilename, seckeyfilename); fprintf_plus(stderr, "The GnuTLS error is: %s\n", safer_gnutls_strerror(ret)); goto globalfail; } /* GnuTLS server initialization */ ret = gnutls_dh_params_init(&mc->dh_params); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error in GnuTLS DH parameter" " initialization: %s\n", safer_gnutls_strerror(ret)); goto globalfail; } /* If a Diffie-Hellman parameters file was given, try to use it */ if(dhparamsfilename != NULL){ gnutls_datum_t params = { .data = NULL, .size = 0 }; do { int dhpfile = open(dhparamsfilename, O_RDONLY); if(dhpfile == -1){ perror_plus("open"); dhparamsfilename = NULL; break; } size_t params_capacity = 0; while(true){ params_capacity = incbuffer((char **)¶ms.data, (size_t)params.size, (size_t)params_capacity); if(params_capacity == 0){ perror_plus("incbuffer"); free(params.data); params.data = NULL; dhparamsfilename = NULL; break; } ssize_t bytes_read = read(dhpfile, params.data + params.size, BUFFER_SIZE); /* EOF */ if(bytes_read == 0){ break; } /* check bytes_read for failure */ if(bytes_read < 0){ perror_plus("read"); free(params.data); params.data = NULL; dhparamsfilename = NULL; break; } params.size += (unsigned int)bytes_read; } ret = close(dhpfile); if(ret == -1){ perror_plus("close"); } if(params.data == NULL){ dhparamsfilename = NULL; } if(dhparamsfilename == NULL){ break; } ret = gnutls_dh_params_import_pkcs3(mc->dh_params, ¶ms, GNUTLS_X509_FMT_PEM); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Failed to parse DH parameters in file" " \"%s\": %s\n", dhparamsfilename, safer_gnutls_strerror(ret)); dhparamsfilename = NULL; } free(params.data); } while(false); } if(dhparamsfilename == NULL){ if(mc->dh_bits == 0){ /* Find out the optimal number of DH bits */ /* Try to read the private key file */ gnutls_datum_t buffer = { .data = NULL, .size = 0 }; do { int secfile = open(seckeyfilename, O_RDONLY); if(secfile == -1){ perror_plus("open"); break; } size_t buffer_capacity = 0; while(true){ buffer_capacity = incbuffer((char **)&buffer.data, (size_t)buffer.size, (size_t)buffer_capacity); if(buffer_capacity == 0){ perror_plus("incbuffer"); free(buffer.data); buffer.data = NULL; break; } ssize_t bytes_read = read(secfile, buffer.data + buffer.size, BUFFER_SIZE); /* EOF */ if(bytes_read == 0){ break; } /* check bytes_read for failure */ if(bytes_read < 0){ perror_plus("read"); free(buffer.data); buffer.data = NULL; break; } buffer.size += (unsigned int)bytes_read; } close(secfile); } while(false); /* If successful, use buffer to parse private key */ gnutls_sec_param_t sec_param = GNUTLS_SEC_PARAM_ULTRA; if(buffer.data != NULL){ { gnutls_openpgp_privkey_t privkey = NULL; ret = gnutls_openpgp_privkey_init(&privkey); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error initializing OpenPGP key" " structure: %s", safer_gnutls_strerror(ret)); free(buffer.data); buffer.data = NULL; } else { ret = gnutls_openpgp_privkey_import (privkey, &buffer, GNUTLS_OPENPGP_FMT_BASE64, "", 0); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error importing OpenPGP key : %s", safer_gnutls_strerror(ret)); privkey = NULL; } free(buffer.data); buffer.data = NULL; if(privkey != NULL){ /* Use private key to suggest an appropriate sec_param */ sec_param = gnutls_openpgp_privkey_sec_param(privkey); gnutls_openpgp_privkey_deinit(privkey); if(debug){ fprintf_plus(stderr, "This OpenPGP key implies using" " a GnuTLS security parameter \"%s\".\n", safe_string(gnutls_sec_param_get_name (sec_param))); } } } } if(sec_param == GNUTLS_SEC_PARAM_UNKNOWN){ /* Err on the side of caution */ sec_param = GNUTLS_SEC_PARAM_ULTRA; if(debug){ fprintf_plus(stderr, "Falling back to security parameter" " \"%s\"\n", safe_string(gnutls_sec_param_get_name (sec_param))); } } } uret = gnutls_sec_param_to_pk_bits(GNUTLS_PK_DH, sec_param); if(uret != 0){ mc->dh_bits = uret; if(debug){ fprintf_plus(stderr, "A \"%s\" GnuTLS security parameter" " implies %u DH bits; using that.\n", safe_string(gnutls_sec_param_get_name (sec_param)), mc->dh_bits); } } else { fprintf_plus(stderr, "Failed to get implied number of DH" " bits for security parameter \"%s\"): %s\n", safe_string(gnutls_sec_param_get_name (sec_param)), safer_gnutls_strerror(ret)); goto globalfail; } } else if(debug){ fprintf_plus(stderr, "DH bits explicitly set to %u\n", mc->dh_bits); } ret = gnutls_dh_params_generate2(mc->dh_params, mc->dh_bits); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error in GnuTLS prime generation (%u" " bits): %s\n", mc->dh_bits, safer_gnutls_strerror(ret)); goto globalfail; } } gnutls_certificate_set_dh_params(mc->cred, mc->dh_params); return 0; globalfail: gnutls_certificate_free_credentials(mc->cred); gnutls_dh_params_deinit(mc->dh_params); return -1; } __attribute__((nonnull, warn_unused_result)) static int init_gnutls_session(gnutls_session_t *session, mandos_context *mc){ int ret; /* GnuTLS session creation */ do { ret = gnutls_init(session, GNUTLS_SERVER); if(quit_now){ return -1; } } while(ret == GNUTLS_E_INTERRUPTED or ret == GNUTLS_E_AGAIN); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error in GnuTLS session initialization: %s\n", safer_gnutls_strerror(ret)); } { const char *err; do { ret = gnutls_priority_set_direct(*session, mc->priority, &err); if(quit_now){ gnutls_deinit(*session); return -1; } } while(ret == GNUTLS_E_INTERRUPTED or ret == GNUTLS_E_AGAIN); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Syntax error at: %s\n", err); fprintf_plus(stderr, "GnuTLS error: %s\n", safer_gnutls_strerror(ret)); gnutls_deinit(*session); return -1; } } do { ret = gnutls_credentials_set(*session, GNUTLS_CRD_CERTIFICATE, mc->cred); if(quit_now){ gnutls_deinit(*session); return -1; } } while(ret == GNUTLS_E_INTERRUPTED or ret == GNUTLS_E_AGAIN); if(ret != GNUTLS_E_SUCCESS){ fprintf_plus(stderr, "Error setting GnuTLS credentials: %s\n", safer_gnutls_strerror(ret)); gnutls_deinit(*session); return -1; } /* ignore client certificate if any. */ gnutls_certificate_server_set_request(*session, GNUTLS_CERT_IGNORE); return 0; } /* Avahi log function callback */ static void empty_log(__attribute__((unused)) AvahiLogLevel level, __attribute__((unused)) const char *txt){} /* Set effective uid to 0, return errno */ __attribute__((warn_unused_result)) int raise_privileges(void){ int old_errno = errno; int ret = 0; if(seteuid(0) == -1){ ret = errno; } errno = old_errno; return ret; } /* Set effective and real user ID to 0. Return errno. */ __attribute__((warn_unused_result)) int raise_privileges_permanently(void){ int old_errno = errno; int ret = raise_privileges(); if(ret != 0){ errno = old_errno; return ret; } if(setuid(0) == -1){ ret = errno; } errno = old_errno; return ret; } /* Set effective user ID to unprivileged saved user ID */ __attribute__((warn_unused_result)) int lower_privileges(void){ int old_errno = errno; int ret = 0; if(seteuid(uid) == -1){ ret = errno; } errno = old_errno; return ret; } /* Lower privileges permanently */ __attribute__((warn_unused_result)) int lower_privileges_permanently(void){ int old_errno = errno; int ret = 0; if(setuid(uid) == -1){ ret = errno; } errno = old_errno; return ret; } /* Helper function to add_local_route() and delete_local_route() */ __attribute__((nonnull, warn_unused_result)) static bool add_delete_local_route(const bool add, const char *address, AvahiIfIndex if_index){ int ret; char helper[] = "mandos-client-iprouteadddel"; char add_arg[] = "add"; char delete_arg[] = "delete"; char debug_flag[] = "--debug"; char *pluginhelperdir = getenv("MANDOSPLUGINHELPERDIR"); if(pluginhelperdir == NULL){ if(debug){ fprintf_plus(stderr, "MANDOSPLUGINHELPERDIR environment" " variable not set; cannot run helper\n"); } return false; } char interface[IF_NAMESIZE]; if(if_indextoname((unsigned int)if_index, interface) == NULL){ perror_plus("if_indextoname"); return false; } int devnull = (int)TEMP_FAILURE_RETRY(open("/dev/null", O_RDONLY)); if(devnull == -1){ perror_plus("open(\"/dev/null\", O_RDONLY)"); return false; } pid_t pid = fork(); if(pid == 0){ /* Child */ /* Raise privileges */ errno = raise_privileges_permanently(); if(errno != 0){ perror_plus("Failed to raise privileges"); /* _exit(EX_NOPERM); */ } else { /* Set group */ errno = 0; ret = setgid(0); if(ret == -1){ perror_plus("setgid"); _exit(EX_NOPERM); } /* Reset supplementary groups */ errno = 0; ret = setgroups(0, NULL); if(ret == -1){ perror_plus("setgroups"); _exit(EX_NOPERM); } } ret = dup2(devnull, STDIN_FILENO); if(ret == -1){ perror_plus("dup2(devnull, STDIN_FILENO)"); _exit(EX_OSERR); } ret = close(devnull); if(ret == -1){ perror_plus("close"); _exit(EX_OSERR); } ret = dup2(STDERR_FILENO, STDOUT_FILENO); if(ret == -1){ perror_plus("dup2(STDERR_FILENO, STDOUT_FILENO)"); _exit(EX_OSERR); } int helperdir_fd = (int)TEMP_FAILURE_RETRY(open(pluginhelperdir, O_RDONLY | O_DIRECTORY | O_PATH | O_CLOEXEC)); if(helperdir_fd == -1){ perror_plus("open"); _exit(EX_UNAVAILABLE); } int helper_fd = (int)TEMP_FAILURE_RETRY(openat(helperdir_fd, helper, O_RDONLY)); if(helper_fd == -1){ perror_plus("openat"); close(helperdir_fd); _exit(EX_UNAVAILABLE); } close(helperdir_fd); #ifdef __GNUC__ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wcast-qual" #endif if(fexecve(helper_fd, (char *const []) { helper, add ? add_arg : delete_arg, (char *)address, interface, debug ? debug_flag : NULL, NULL }, environ) == -1){ #ifdef __GNUC__ #pragma GCC diagnostic pop #endif perror_plus("fexecve"); _exit(EXIT_FAILURE); } } if(pid == -1){ perror_plus("fork"); return false; } int status; pid_t pret = -1; errno = 0; do { pret = waitpid(pid, &status, 0); if(pret == -1 and errno == EINTR and quit_now){ int errno_raising = 0; if((errno = raise_privileges()) != 0){ errno_raising = errno; perror_plus("Failed to raise privileges in order to" " kill helper program"); } if(kill(pid, SIGTERM) == -1){ perror_plus("kill"); } if((errno_raising == 0) and (errno = lower_privileges()) != 0){ perror_plus("Failed to lower privileges after killing" " helper program"); } return false; } } while(pret == -1 and errno == EINTR); if(pret == -1){ perror_plus("waitpid"); return false; } if(WIFEXITED(status)){ if(WEXITSTATUS(status) != 0){ fprintf_plus(stderr, "Error: iprouteadddel exited" " with status %d\n", WEXITSTATUS(status)); return false; } return true; } if(WIFSIGNALED(status)){ fprintf_plus(stderr, "Error: iprouteadddel died by" " signal %d\n", WTERMSIG(status)); return false; } fprintf_plus(stderr, "Error: iprouteadddel crashed\n"); return false; } __attribute__((nonnull, warn_unused_result)) static bool add_local_route(const char *address, AvahiIfIndex if_index){ if(debug){ fprintf_plus(stderr, "Adding route to %s\n", address); } return add_delete_local_route(true, address, if_index); } __attribute__((nonnull, warn_unused_result)) static bool delete_local_route(const char *address, AvahiIfIndex if_index){ if(debug){ fprintf_plus(stderr, "Removing route to %s\n", address); } return add_delete_local_route(false, address, if_index); } /* Called when a Mandos server is found */ __attribute__((nonnull, warn_unused_result)) static int start_mandos_communication(const char *ip, in_port_t port, AvahiIfIndex if_index, int af, mandos_context *mc){ int ret, tcp_sd = -1; ssize_t sret; struct sockaddr_storage to; char *buffer = NULL; char *decrypted_buffer = NULL; size_t buffer_length = 0; size_t buffer_capacity = 0; size_t written; int retval = -1; gnutls_session_t session; int pf; /* Protocol family */ bool route_added = false; errno = 0; if(quit_now){ errno = EINTR; return -1; } switch(af){ case AF_INET6: pf = PF_INET6; break; case AF_INET: pf = PF_INET; break; default: fprintf_plus(stderr, "Bad address family: %d\n", af); errno = EINVAL; return -1; } /* If the interface is specified and we have a list of interfaces */ if(if_index != AVAHI_IF_UNSPEC and mc->interfaces != NULL){ /* Check if the interface is one of the interfaces we are using */ bool match = false; { char *interface = NULL; while((interface = argz_next(mc->interfaces, mc->interfaces_size, interface))){ if(if_nametoindex(interface) == (unsigned int)if_index){ match = true; break; } } } if(not match){ /* This interface does not match any in the list, so we don't connect to the server */ if(debug){ char interface[IF_NAMESIZE]; if(if_indextoname((unsigned int)if_index, interface) == NULL){ perror_plus("if_indextoname"); } else { fprintf_plus(stderr, "Skipping server on non-used interface" " \"%s\"\n", if_indextoname((unsigned int)if_index, interface)); } } return -1; } } ret = init_gnutls_session(&session, mc); if(ret != 0){ return -1; } if(debug){ fprintf_plus(stderr, "Setting up a TCP connection to %s, port %" PRIuMAX "\n", ip, (uintmax_t)port); } tcp_sd = socket(pf, SOCK_STREAM | SOCK_CLOEXEC, 0); if(tcp_sd < 0){ int e = errno; perror_plus("socket"); errno = e; goto mandos_end; } if(quit_now){ errno = EINTR; goto mandos_end; } if(af == AF_INET6){ struct sockaddr_in6 *to6 = (struct sockaddr_in6 *)&to; *to6 = (struct sockaddr_in6){ .sin6_family = (sa_family_t)af }; ret = inet_pton(af, ip, &to6->sin6_addr); } else { /* IPv4 */ struct sockaddr_in *to4 = (struct sockaddr_in *)&to; *to4 = (struct sockaddr_in){ .sin_family = (sa_family_t)af }; ret = inet_pton(af, ip, &to4->sin_addr); } if(ret < 0 ){ int e = errno; perror_plus("inet_pton"); errno = e; goto mandos_end; } if(ret == 0){ int e = errno; fprintf_plus(stderr, "Bad address: %s\n", ip); errno = e; goto mandos_end; } if(af == AF_INET6){ ((struct sockaddr_in6 *)&to)->sin6_port = htons(port); if(IN6_IS_ADDR_LINKLOCAL (&((struct sockaddr_in6 *)&to)->sin6_addr)){ if(if_index == AVAHI_IF_UNSPEC){ fprintf_plus(stderr, "An IPv6 link-local address is" " incomplete without a network interface\n"); errno = EINVAL; goto mandos_end; } /* Set the network interface number as scope */ ((struct sockaddr_in6 *)&to)->sin6_scope_id = (uint32_t)if_index; } } else { ((struct sockaddr_in *)&to)->sin_port = htons(port); } if(quit_now){ errno = EINTR; goto mandos_end; } if(debug){ if(af == AF_INET6 and if_index != AVAHI_IF_UNSPEC){ char interface[IF_NAMESIZE]; if(if_indextoname((unsigned int)if_index, interface) == NULL){ perror_plus("if_indextoname"); } else { fprintf_plus(stderr, "Connection to: %s%%%s, port %" PRIuMAX "\n", ip, interface, (uintmax_t)port); } } else { fprintf_plus(stderr, "Connection to: %s, port %" PRIuMAX "\n", ip, (uintmax_t)port); } char addrstr[(INET_ADDRSTRLEN > INET6_ADDRSTRLEN) ? INET_ADDRSTRLEN : INET6_ADDRSTRLEN] = ""; if(af == AF_INET6){ ret = getnameinfo((struct sockaddr *)&to, sizeof(struct sockaddr_in6), addrstr, sizeof(addrstr), NULL, 0, NI_NUMERICHOST); } else { ret = getnameinfo((struct sockaddr *)&to, sizeof(struct sockaddr_in), addrstr, sizeof(addrstr), NULL, 0, NI_NUMERICHOST); } if(ret == EAI_SYSTEM){ perror_plus("getnameinfo"); } else if(ret != 0) { fprintf_plus(stderr, "getnameinfo: %s", gai_strerror(ret)); } else if(strcmp(addrstr, ip) != 0){ fprintf_plus(stderr, "Canonical address form: %s\n", addrstr); } } if(quit_now){ errno = EINTR; goto mandos_end; } while(true){ if(af == AF_INET6){ ret = connect(tcp_sd, (struct sockaddr *)&to, sizeof(struct sockaddr_in6)); } else { ret = connect(tcp_sd, (struct sockaddr *)&to, /* IPv4 */ sizeof(struct sockaddr_in)); } if(ret < 0){ if(((errno == ENETUNREACH) or (errno == EHOSTUNREACH)) and if_index != AVAHI_IF_UNSPEC and connect_to == NULL and not route_added and ((af == AF_INET6 and not IN6_IS_ADDR_LINKLOCAL(&(((struct sockaddr_in6 *) &to)->sin6_addr))) or (af == AF_INET and /* Not a a IPv4LL address */ (ntohl(((struct sockaddr_in *)&to)->sin_addr.s_addr) & 0xFFFF0000L) != 0xA9FE0000L))){ /* Work around Avahi bug - Avahi does not announce link-local addresses if it has a global address, so local hosts with *only* a link-local address (e.g. Mandos clients) cannot connect to a Mandos server announced by Avahi on a server host with a global address. Work around this by retrying with an explicit route added with the server's address. Avahi bug reference: https://lists.freedesktop.org/archives/avahi/2010-February/001833.html https://bugs.debian.org/587961 */ if(debug){ fprintf_plus(stderr, "Mandos server unreachable, trying" " direct route\n"); } int e = errno; route_added = add_local_route(ip, if_index); if(route_added){ continue; } errno = e; } if(errno != ECONNREFUSED or debug){ int e = errno; perror_plus("connect"); errno = e; } goto mandos_end; } if(quit_now){ errno = EINTR; goto mandos_end; } break; } const char *out = mandos_protocol_version; written = 0; while(true){ size_t out_size = strlen(out); ret = (int)TEMP_FAILURE_RETRY(write(tcp_sd, out + written, out_size - written)); if(ret == -1){ int e = errno; perror_plus("write"); errno = e; goto mandos_end; } written += (size_t)ret; if(written < out_size){ continue; } else { if(out == mandos_protocol_version){ written = 0; out = "\r\n"; } else { break; } } if(quit_now){ errno = EINTR; goto mandos_end; } } if(debug){ fprintf_plus(stderr, "Establishing TLS session with %s\n", ip); } if(quit_now){ errno = EINTR; goto mandos_end; } /* This casting via intptr_t is to eliminate warning about casting an int to a pointer type. This is exactly how the GnuTLS Guile function "set-session-transport-fd!" does it. */ gnutls_transport_set_ptr(session, (gnutls_transport_ptr_t)(intptr_t)tcp_sd); if(quit_now){ errno = EINTR; goto mandos_end; } do { ret = gnutls_handshake(session); if(quit_now){ errno = EINTR; goto mandos_end; } } while(ret == GNUTLS_E_AGAIN or ret == GNUTLS_E_INTERRUPTED); if(ret != GNUTLS_E_SUCCESS){ if(debug){ fprintf_plus(stderr, "*** GnuTLS Handshake failed ***\n"); gnutls_perror(ret); } errno = EPROTO; goto mandos_end; } /* Read OpenPGP packet that contains the wanted password */ if(debug){ fprintf_plus(stderr, "Retrieving OpenPGP encrypted password from" " %s\n", ip); } while(true){ if(quit_now){ errno = EINTR; goto mandos_end; } buffer_capacity = incbuffer(&buffer, buffer_length, buffer_capacity); if(buffer_capacity == 0){ int e = errno; perror_plus("incbuffer"); errno = e; goto mandos_end; } if(quit_now){ errno = EINTR; goto mandos_end; } sret = gnutls_record_recv(session, buffer+buffer_length, BUFFER_SIZE); if(sret == 0){ break; } if(sret < 0){ switch(sret){ case GNUTLS_E_INTERRUPTED: case GNUTLS_E_AGAIN: break; case GNUTLS_E_REHANDSHAKE: do { ret = gnutls_handshake(session); if(quit_now){ errno = EINTR; goto mandos_end; } } while(ret == GNUTLS_E_AGAIN or ret == GNUTLS_E_INTERRUPTED); if(ret < 0){ fprintf_plus(stderr, "*** GnuTLS Re-handshake failed " "***\n"); gnutls_perror(ret); errno = EPROTO; goto mandos_end; } break; default: fprintf_plus(stderr, "Unknown error while reading data from" " encrypted session with Mandos server\n"); gnutls_bye(session, GNUTLS_SHUT_RDWR); errno = EIO; goto mandos_end; } } else { buffer_length += (size_t) sret; } } if(debug){ fprintf_plus(stderr, "Closing TLS session\n"); } if(quit_now){ errno = EINTR; goto mandos_end; } do { ret = gnutls_bye(session, GNUTLS_SHUT_RDWR); if(quit_now){ errno = EINTR; goto mandos_end; } } while(ret == GNUTLS_E_AGAIN or ret == GNUTLS_E_INTERRUPTED); if(buffer_length > 0){ ssize_t decrypted_buffer_size; decrypted_buffer_size = pgp_packet_decrypt(buffer, buffer_length, &decrypted_buffer, mc); if(decrypted_buffer_size >= 0){ clearerr(stdout); written = 0; while(written < (size_t) decrypted_buffer_size){ if(quit_now){ errno = EINTR; goto mandos_end; } ret = (int)fwrite(decrypted_buffer + written, 1, (size_t)decrypted_buffer_size - written, stdout); if(ret == 0 and ferror(stdout)){ int e = errno; if(debug){ fprintf_plus(stderr, "Error writing encrypted data: %s\n", strerror(errno)); } errno = e; goto mandos_end; } written += (size_t)ret; } ret = fflush(stdout); if(ret != 0){ int e = errno; if(debug){ fprintf_plus(stderr, "Error writing encrypted data: %s\n", strerror(errno)); } errno = e; goto mandos_end; } retval = 0; } } /* Shutdown procedure */ mandos_end: { if(route_added){ if(not delete_local_route(ip, if_index)){ fprintf_plus(stderr, "Failed to delete local route to %s on" " interface %d", ip, if_index); } } int e = errno; free(decrypted_buffer); free(buffer); if(tcp_sd >= 0){ ret = close(tcp_sd); } if(ret == -1){ if(e == 0){ e = errno; } perror_plus("close"); } gnutls_deinit(session); errno = e; if(quit_now){ errno = EINTR; retval = -1; } } return retval; } static void resolve_callback(AvahiSServiceResolver *r, AvahiIfIndex interface, AvahiProtocol proto, AvahiResolverEvent event, const char *name, const char *type, const char *domain, const char *host_name, const AvahiAddress *address, uint16_t port, AVAHI_GCC_UNUSED AvahiStringList *txt, AVAHI_GCC_UNUSED AvahiLookupResultFlags flags, void *mc){ if(r == NULL){ return; } /* Called whenever a service has been resolved successfully or timed out */ if(quit_now){ avahi_s_service_resolver_free(r); return; } switch(event){ default: case AVAHI_RESOLVER_FAILURE: fprintf_plus(stderr, "(Avahi Resolver) Failed to resolve service " "'%s' of type '%s' in domain '%s': %s\n", name, type, domain, avahi_strerror(avahi_server_errno (((mandos_context*)mc)->server))); break; case AVAHI_RESOLVER_FOUND: { char ip[AVAHI_ADDRESS_STR_MAX]; avahi_address_snprint(ip, sizeof(ip), address); if(debug){ fprintf_plus(stderr, "Mandos server \"%s\" found on %s (%s, %" PRIdMAX ") on port %" PRIu16 "\n", name, host_name, ip, (intmax_t)interface, port); } int ret = start_mandos_communication(ip, (in_port_t)port, interface, avahi_proto_to_af(proto), mc); if(ret == 0){ avahi_simple_poll_quit(simple_poll); } else { if(not add_server(ip, (in_port_t)port, interface, avahi_proto_to_af(proto), &((mandos_context*)mc)->current_server)){ fprintf_plus(stderr, "Failed to add server \"%s\" to server" " list\n", name); } } } } avahi_s_service_resolver_free(r); } static void browse_callback(AvahiSServiceBrowser *b, AvahiIfIndex interface, AvahiProtocol protocol, AvahiBrowserEvent event, const char *name, const char *type, const char *domain, AVAHI_GCC_UNUSED AvahiLookupResultFlags flags, void *mc){ if(b == NULL){ return; } /* Called whenever a new services becomes available on the LAN or is removed from the LAN */ if(quit_now){ return; } switch(event){ default: case AVAHI_BROWSER_FAILURE: fprintf_plus(stderr, "(Avahi browser) %s\n", avahi_strerror(avahi_server_errno (((mandos_context*)mc)->server))); avahi_simple_poll_quit(simple_poll); return; case AVAHI_BROWSER_NEW: /* We ignore the returned Avahi resolver object. In the callback function we free it. If the Avahi server is terminated before the callback function is called the Avahi server will free the resolver for us. */ if(avahi_s_service_resolver_new(((mandos_context*)mc)->server, interface, protocol, name, type, domain, protocol, 0, resolve_callback, mc) == NULL) fprintf_plus(stderr, "Avahi: Failed to resolve service '%s':" " %s\n", name, avahi_strerror(avahi_server_errno (((mandos_context*)mc)->server))); break; case AVAHI_BROWSER_REMOVE: break; case AVAHI_BROWSER_ALL_FOR_NOW: case AVAHI_BROWSER_CACHE_EXHAUSTED: if(debug){ fprintf_plus(stderr, "No Mandos server found, still" " searching...\n"); } break; } } /* Signal handler that stops main loop after SIGTERM */ static void handle_sigterm(int sig){ if(quit_now){ return; } quit_now = 1; signal_received = sig; int old_errno = errno; /* set main loop to exit */ if(simple_poll != NULL){ avahi_simple_poll_quit(simple_poll); } errno = old_errno; } __attribute__((nonnull, warn_unused_result)) bool get_flags(const char *ifname, struct ifreq *ifr){ int ret; int old_errno; int s = socket(PF_INET6, SOCK_DGRAM, IPPROTO_IP); if(s < 0){ old_errno = errno; perror_plus("socket"); errno = old_errno; return false; } strncpy(ifr->ifr_name, ifname, IF_NAMESIZE); ifr->ifr_name[IF_NAMESIZE-1] = '\0'; /* NUL terminate */ ret = ioctl(s, SIOCGIFFLAGS, ifr); if(ret == -1){ if(debug){ old_errno = errno; perror_plus("ioctl SIOCGIFFLAGS"); errno = old_errno; } if((close(s) == -1) and debug){ old_errno = errno; perror_plus("close"); errno = old_errno; } return false; } if((close(s) == -1) and debug){ old_errno = errno; perror_plus("close"); errno = old_errno; } return true; } __attribute__((nonnull, warn_unused_result)) bool good_flags(const char *ifname, const struct ifreq *ifr){ /* Reject the loopback device */ if(ifr->ifr_flags & IFF_LOOPBACK){ if(debug){ fprintf_plus(stderr, "Rejecting loopback interface \"%s\"\n", ifname); } return false; } /* Accept point-to-point devices only if connect_to is specified */ if(connect_to != NULL and (ifr->ifr_flags & IFF_POINTOPOINT)){ if(debug){ fprintf_plus(stderr, "Accepting point-to-point interface" " \"%s\"\n", ifname); } return true; } /* Otherwise, reject non-broadcast-capable devices */ if(not (ifr->ifr_flags & IFF_BROADCAST)){ if(debug){ fprintf_plus(stderr, "Rejecting non-broadcast interface" " \"%s\"\n", ifname); } return false; } /* Reject non-ARP interfaces (including dummy interfaces) */ if(ifr->ifr_flags & IFF_NOARP){ if(debug){ fprintf_plus(stderr, "Rejecting non-ARP interface \"%s\"\n", ifname); } return false; } /* Accept this device */ if(debug){ fprintf_plus(stderr, "Interface \"%s\" is good\n", ifname); } return true; } /* * This function determines if a directory entry in /sys/class/net * corresponds to an acceptable network device. * (This function is passed to scandir(3) as a filter function.) */ __attribute__((nonnull, warn_unused_result)) int good_interface(const struct dirent *if_entry){ if(if_entry->d_name[0] == '.'){ return 0; } struct ifreq ifr; if(not get_flags(if_entry->d_name, &ifr)){ if(debug){ fprintf_plus(stderr, "Failed to get flags for interface " "\"%s\"\n", if_entry->d_name); } return 0; } if(not good_flags(if_entry->d_name, &ifr)){ return 0; } return 1; } /* * This function determines if a network interface is up. */ __attribute__((nonnull, warn_unused_result)) bool interface_is_up(const char *interface){ struct ifreq ifr; if(not get_flags(interface, &ifr)){ if(debug){ fprintf_plus(stderr, "Failed to get flags for interface " "\"%s\"\n", interface); } return false; } return (bool)(ifr.ifr_flags & IFF_UP); } /* * This function determines if a network interface is running */ __attribute__((nonnull, warn_unused_result)) bool interface_is_running(const char *interface){ struct ifreq ifr; if(not get_flags(interface, &ifr)){ if(debug){ fprintf_plus(stderr, "Failed to get flags for interface " "\"%s\"\n", interface); } return false; } return (bool)(ifr.ifr_flags & IFF_RUNNING); } __attribute__((nonnull, pure, warn_unused_result)) int notdotentries(const struct dirent *direntry){ /* Skip "." and ".." */ if(direntry->d_name[0] == '.' and (direntry->d_name[1] == '\0' or (direntry->d_name[1] == '.' and direntry->d_name[2] == '\0'))){ return 0; } return 1; } /* Is this directory entry a runnable program? */ __attribute__((nonnull, warn_unused_result)) int runnable_hook(const struct dirent *direntry){ int ret; size_t sret; struct stat st; if((direntry->d_name)[0] == '\0'){ /* Empty name? */ return 0; } sret = strspn(direntry->d_name, "ABCDEFGHIJKLMNOPQRSTUVWXYZ" "abcdefghijklmnopqrstuvwxyz" "0123456789" "_.-"); if((direntry->d_name)[sret] != '\0'){ /* Contains non-allowed characters */ if(debug){ fprintf_plus(stderr, "Ignoring hook \"%s\" with bad name\n", direntry->d_name); } return 0; } ret = fstatat(hookdir_fd, direntry->d_name, &st, 0); if(ret == -1){ if(debug){ perror_plus("Could not stat hook"); } return 0; } if(not (S_ISREG(st.st_mode))){ /* Not a regular file */ if(debug){ fprintf_plus(stderr, "Ignoring hook \"%s\" - not a file\n", direntry->d_name); } return 0; } if(not (st.st_mode & (S_IXUSR | S_IXGRP | S_IXOTH))){ /* Not executable */ if(debug){ fprintf_plus(stderr, "Ignoring hook \"%s\" - not executable\n", direntry->d_name); } return 0; } if(debug){ fprintf_plus(stderr, "Hook \"%s\" is acceptable\n", direntry->d_name); } return 1; } __attribute__((nonnull, warn_unused_result)) int avahi_loop_with_timeout(AvahiSimplePoll *s, int retry_interval, mandos_context *mc){ int ret; struct timespec now; struct timespec waited_time; intmax_t block_time; while(true){ if(mc->current_server == NULL){ if(debug){ fprintf_plus(stderr, "Wait until first server is found." " No timeout!\n"); } ret = avahi_simple_poll_iterate(s, -1); } else { if(debug){ fprintf_plus(stderr, "Check current_server if we should run" " it, or wait\n"); } /* the current time */ ret = clock_gettime(CLOCK_MONOTONIC, &now); if(ret == -1){ perror_plus("clock_gettime"); return -1; } /* Calculating in ms how long time between now and server who we visted longest time ago. Now - last seen. */ waited_time.tv_sec = (now.tv_sec - mc->current_server->last_seen.tv_sec); waited_time.tv_nsec = (now.tv_nsec - mc->current_server->last_seen.tv_nsec); /* total time is 10s/10,000ms. Converting to s from ms by dividing by 1,000, and ns to ms by dividing by 1,000,000. */ block_time = ((retry_interval - ((intmax_t)waited_time.tv_sec * 1000)) - ((intmax_t)waited_time.tv_nsec / 1000000)); if(debug){ fprintf_plus(stderr, "Blocking for %" PRIdMAX " ms\n", block_time); } if(block_time <= 0){ ret = start_mandos_communication(mc->current_server->ip, mc->current_server->port, mc->current_server->if_index, mc->current_server->af, mc); if(ret == 0){ avahi_simple_poll_quit(s); return 0; } ret = clock_gettime(CLOCK_MONOTONIC, &mc->current_server->last_seen); if(ret == -1){ perror_plus("clock_gettime"); return -1; } mc->current_server = mc->current_server->next; block_time = 0; /* Call avahi to find new Mandos servers, but don't block */ } ret = avahi_simple_poll_iterate(s, (int)block_time); } if(ret != 0){ if(ret > 0 or errno != EINTR){ return (ret != 1) ? ret : 0; } } } } __attribute__((nonnull)) void run_network_hooks(const char *mode, const char *interface, const float delay){ struct dirent **direntries = NULL; if(hookdir_fd == -1){ hookdir_fd = open(hookdir, O_RDONLY | O_DIRECTORY | O_PATH | O_CLOEXEC); if(hookdir_fd == -1){ if(errno == ENOENT){ if(debug){ fprintf_plus(stderr, "Network hook directory \"%s\" not" " found\n", hookdir); } } else { perror_plus("open"); } return; } } int devnull = (int)TEMP_FAILURE_RETRY(open("/dev/null", O_RDONLY)); if(devnull == -1){ perror_plus("open(\"/dev/null\", O_RDONLY)"); return; } int numhooks = scandirat(hookdir_fd, ".", &direntries, runnable_hook, alphasort); if(numhooks == -1){ perror_plus("scandir"); close(devnull); return; } struct dirent *direntry; int ret; for(int i = 0; i < numhooks; i++){ direntry = direntries[i]; if(debug){ fprintf_plus(stderr, "Running network hook \"%s\"\n", direntry->d_name); } pid_t hook_pid = fork(); if(hook_pid == 0){ /* Child */ /* Raise privileges */ errno = raise_privileges_permanently(); if(errno != 0){ perror_plus("Failed to raise privileges"); _exit(EX_NOPERM); } /* Set group */ errno = 0; ret = setgid(0); if(ret == -1){ perror_plus("setgid"); _exit(EX_NOPERM); } /* Reset supplementary groups */ errno = 0; ret = setgroups(0, NULL); if(ret == -1){ perror_plus("setgroups"); _exit(EX_NOPERM); } ret = setenv("MANDOSNETHOOKDIR", hookdir, 1); if(ret == -1){ perror_plus("setenv"); _exit(EX_OSERR); } ret = setenv("DEVICE", interface, 1); if(ret == -1){ perror_plus("setenv"); _exit(EX_OSERR); } ret = setenv("VERBOSITY", debug ? "1" : "0", 1); if(ret == -1){ perror_plus("setenv"); _exit(EX_OSERR); } ret = setenv("MODE", mode, 1); if(ret == -1){ perror_plus("setenv"); _exit(EX_OSERR); } char *delaystring; ret = asprintf(&delaystring, "%f", (double)delay); if(ret == -1){ perror_plus("asprintf"); _exit(EX_OSERR); } ret = setenv("DELAY", delaystring, 1); if(ret == -1){ free(delaystring); perror_plus("setenv"); _exit(EX_OSERR); } free(delaystring); if(connect_to != NULL){ ret = setenv("CONNECT", connect_to, 1); if(ret == -1){ perror_plus("setenv"); _exit(EX_OSERR); } } int hook_fd = (int)TEMP_FAILURE_RETRY(openat(hookdir_fd, direntry->d_name, O_RDONLY)); if(hook_fd == -1){ perror_plus("openat"); _exit(EXIT_FAILURE); } if(close(hookdir_fd) == -1){ perror_plus("close"); _exit(EXIT_FAILURE); } ret = dup2(devnull, STDIN_FILENO); if(ret == -1){ perror_plus("dup2(devnull, STDIN_FILENO)"); _exit(EX_OSERR); } ret = close(devnull); if(ret == -1){ perror_plus("close"); _exit(EX_OSERR); } ret = dup2(STDERR_FILENO, STDOUT_FILENO); if(ret == -1){ perror_plus("dup2(STDERR_FILENO, STDOUT_FILENO)"); _exit(EX_OSERR); } if(fexecve(hook_fd, (char *const []){ direntry->d_name, NULL }, environ) == -1){ perror_plus("fexecve"); _exit(EXIT_FAILURE); } } else { if(hook_pid == -1){ perror_plus("fork"); free(direntry); continue; } int status; if(TEMP_FAILURE_RETRY(waitpid(hook_pid, &status, 0)) == -1){ perror_plus("waitpid"); free(direntry); continue; } if(WIFEXITED(status)){ if(WEXITSTATUS(status) != 0){ fprintf_plus(stderr, "Warning: network hook \"%s\" exited" " with status %d\n", direntry->d_name, WEXITSTATUS(status)); free(direntry); continue; } } else if(WIFSIGNALED(status)){ fprintf_plus(stderr, "Warning: network hook \"%s\" died by" " signal %d\n", direntry->d_name, WTERMSIG(status)); free(direntry); continue; } else { fprintf_plus(stderr, "Warning: network hook \"%s\"" " crashed\n", direntry->d_name); free(direntry); continue; } } if(debug){ fprintf_plus(stderr, "Network hook \"%s\" ran successfully\n", direntry->d_name); } free(direntry); } free(direntries); if(close(hookdir_fd) == -1){ perror_plus("close"); } else { hookdir_fd = -1; } close(devnull); } __attribute__((nonnull, warn_unused_result)) int bring_up_interface(const char *const interface, const float delay){ int old_errno = errno; int ret; struct ifreq network; unsigned int if_index = if_nametoindex(interface); if(if_index == 0){ fprintf_plus(stderr, "No such interface: \"%s\"\n", interface); errno = old_errno; return ENXIO; } if(quit_now){ errno = old_errno; return EINTR; } if(not interface_is_up(interface)){ int ret_errno = 0; int ioctl_errno = 0; if(not get_flags(interface, &network)){ ret_errno = errno; fprintf_plus(stderr, "Failed to get flags for interface " "\"%s\"\n", interface); errno = old_errno; return ret_errno; } network.ifr_flags |= IFF_UP; /* set flag */ int sd = socket(PF_INET6, SOCK_DGRAM, IPPROTO_IP); if(sd == -1){ ret_errno = errno; perror_plus("socket"); errno = old_errno; return ret_errno; } if(quit_now){ ret = close(sd); if(ret == -1){ perror_plus("close"); } errno = old_errno; return EINTR; } if(debug){ fprintf_plus(stderr, "Bringing up interface \"%s\"\n", interface); } /* Raise privileges */ ret_errno = raise_privileges(); if(ret_errno != 0){ errno = ret_errno; perror_plus("Failed to raise privileges"); } #ifdef __linux__ int ret_linux; bool restore_loglevel = false; if(ret_errno == 0){ /* Lower kernel loglevel to KERN_NOTICE to avoid KERN_INFO messages about the network interface to mess up the prompt */ ret_linux = klogctl(8, NULL, 5); if(ret_linux == -1){ perror_plus("klogctl"); } else { restore_loglevel = true; } } #endif /* __linux__ */ int ret_setflags = ioctl(sd, SIOCSIFFLAGS, &network); ioctl_errno = errno; #ifdef __linux__ if(restore_loglevel){ ret_linux = klogctl(7, NULL, 0); if(ret_linux == -1){ perror_plus("klogctl"); } } #endif /* __linux__ */ /* If raise_privileges() succeeded above */ if(ret_errno == 0){ /* Lower privileges */ ret_errno = lower_privileges(); if(ret_errno != 0){ errno = ret_errno; perror_plus("Failed to lower privileges"); } } /* Close the socket */ ret = close(sd); if(ret == -1){ perror_plus("close"); } if(ret_setflags == -1){ errno = ioctl_errno; perror_plus("ioctl SIOCSIFFLAGS +IFF_UP"); errno = old_errno; return ioctl_errno; } } else if(debug){ fprintf_plus(stderr, "Interface \"%s\" is already up; good\n", interface); } /* Sleep checking until interface is running. Check every 0.25s, up to total time of delay */ for(int i = 0; i < delay * 4; i++){ if(interface_is_running(interface)){ break; } struct timespec sleeptime = { .tv_nsec = 250000000 }; ret = nanosleep(&sleeptime, NULL); if(ret == -1 and errno != EINTR){ perror_plus("nanosleep"); } } errno = old_errno; return 0; } __attribute__((nonnull, warn_unused_result)) int take_down_interface(const char *const interface){ int old_errno = errno; struct ifreq network; unsigned int if_index = if_nametoindex(interface); if(if_index == 0){ fprintf_plus(stderr, "No such interface: \"%s\"\n", interface); errno = old_errno; return ENXIO; } if(interface_is_up(interface)){ int ret_errno = 0; int ioctl_errno = 0; if(not get_flags(interface, &network) and debug){ ret_errno = errno; fprintf_plus(stderr, "Failed to get flags for interface " "\"%s\"\n", interface); errno = old_errno; return ret_errno; } network.ifr_flags &= ~(short)IFF_UP; /* clear flag */ int sd = socket(PF_INET6, SOCK_DGRAM, IPPROTO_IP); if(sd == -1){ ret_errno = errno; perror_plus("socket"); errno = old_errno; return ret_errno; } if(debug){ fprintf_plus(stderr, "Taking down interface \"%s\"\n", interface); } /* Raise privileges */ ret_errno = raise_privileges(); if(ret_errno != 0){ errno = ret_errno; perror_plus("Failed to raise privileges"); } int ret_setflags = ioctl(sd, SIOCSIFFLAGS, &network); ioctl_errno = errno; /* If raise_privileges() succeeded above */ if(ret_errno == 0){ /* Lower privileges */ ret_errno = lower_privileges(); if(ret_errno != 0){ errno = ret_errno; perror_plus("Failed to lower privileges"); } } /* Close the socket */ int ret = close(sd); if(ret == -1){ perror_plus("close"); } if(ret_setflags == -1){ errno = ioctl_errno; perror_plus("ioctl SIOCSIFFLAGS -IFF_UP"); errno = old_errno; return ioctl_errno; } } else if(debug){ fprintf_plus(stderr, "Interface \"%s\" is already down; odd\n", interface); } errno = old_errno; return 0; } int main(int argc, char *argv[]){ mandos_context mc = { .server = NULL, .dh_bits = 0, .priority = "SECURE256:!CTYPE-X.509" ":+CTYPE-OPENPGP:!RSA:+SIGN-DSA-SHA256", .current_server = NULL, .interfaces = NULL, .interfaces_size = 0 }; AvahiSServiceBrowser *sb = NULL; error_t ret_errno; int ret; intmax_t tmpmax; char *tmp; int exitcode = EXIT_SUCCESS; char *interfaces_to_take_down = NULL; size_t interfaces_to_take_down_size = 0; char run_tempdir[] = "/run/tmp/mandosXXXXXX"; char old_tempdir[] = "/tmp/mandosXXXXXX"; char *tempdir = NULL; AvahiIfIndex if_index = AVAHI_IF_UNSPEC; const char *seckey = PATHDIR "/" SECKEY; const char *pubkey = PATHDIR "/" PUBKEY; const char *dh_params_file = NULL; char *interfaces_hooks = NULL; bool gnutls_initialized = false; bool gpgme_initialized = false; float delay = 2.5f; double retry_interval = 10; /* 10s between trying a server and retrying the same server again */ struct sigaction old_sigterm_action = { .sa_handler = SIG_DFL }; struct sigaction sigterm_action = { .sa_handler = handle_sigterm }; uid = getuid(); gid = getgid(); /* Lower any group privileges we might have, just to be safe */ errno = 0; ret = setgid(gid); if(ret == -1){ perror_plus("setgid"); } /* Lower user privileges (temporarily) */ errno = 0; ret = seteuid(uid); if(ret == -1){ perror_plus("seteuid"); } if(quit_now){ goto end; } { struct argp_option options[] = { { .name = "debug", .key = 128, .doc = "Debug mode", .group = 3 }, { .name = "connect", .key = 'c', .arg = "ADDRESS:PORT", .doc = "Connect directly to a specific Mandos server", .group = 1 }, { .name = "interface", .key = 'i', .arg = "NAME", .doc = "Network interface that will be used to search for" " Mandos servers", .group = 1 }, { .name = "seckey", .key = 's', .arg = "FILE", .doc = "OpenPGP secret key file base name", .group = 1 }, { .name = "pubkey", .key = 'p', .arg = "FILE", .doc = "OpenPGP public key file base name", .group = 2 }, { .name = "dh-bits", .key = 129, .arg = "BITS", .doc = "Bit length of the prime number used in the" " Diffie-Hellman key exchange", .group = 2 }, { .name = "dh-params", .key = 134, .arg = "FILE", .doc = "PEM-encoded PKCS#3 file with pre-generated parameters" " for the Diffie-Hellman key exchange", .group = 2 }, { .name = "priority", .key = 130, .arg = "STRING", .doc = "GnuTLS priority string for the TLS handshake", .group = 1 }, { .name = "delay", .key = 131, .arg = "SECONDS", .doc = "Maximum delay to wait for interface startup", .group = 2 }, { .name = "retry", .key = 132, .arg = "SECONDS", .doc = "Retry interval used when denied by the Mandos server", .group = 2 }, { .name = "network-hook-dir", .key = 133, .arg = "DIR", .doc = "Directory where network hooks are located", .group = 2 }, /* * These reproduce what we would get without ARGP_NO_HELP */ { .name = "help", .key = '?', .doc = "Give this help list", .group = -1 }, { .name = "usage", .key = -3, .doc = "Give a short usage message", .group = -1 }, { .name = "version", .key = 'V', .doc = "Print program version", .group = -1 }, { .name = NULL } }; error_t parse_opt(int key, char *arg, struct argp_state *state){ errno = 0; switch(key){ case 128: /* --debug */ debug = true; break; case 'c': /* --connect */ connect_to = arg; break; case 'i': /* --interface */ ret_errno = argz_add_sep(&mc.interfaces, &mc.interfaces_size, arg, (int)','); if(ret_errno != 0){ argp_error(state, "%s", strerror(ret_errno)); } break; case 's': /* --seckey */ seckey = arg; break; case 'p': /* --pubkey */ pubkey = arg; break; case 129: /* --dh-bits */ errno = 0; tmpmax = strtoimax(arg, &tmp, 10); if(errno != 0 or tmp == arg or *tmp != '\0' or tmpmax != (typeof(mc.dh_bits))tmpmax){ argp_error(state, "Bad number of DH bits"); } mc.dh_bits = (typeof(mc.dh_bits))tmpmax; break; case 134: /* --dh-params */ dh_params_file = arg; break; case 130: /* --priority */ mc.priority = arg; break; case 131: /* --delay */ errno = 0; delay = strtof(arg, &tmp); if(errno != 0 or tmp == arg or *tmp != '\0'){ argp_error(state, "Bad delay"); } case 132: /* --retry */ errno = 0; retry_interval = strtod(arg, &tmp); if(errno != 0 or tmp == arg or *tmp != '\0' or (retry_interval * 1000) > INT_MAX or retry_interval < 0){ argp_error(state, "Bad retry interval"); } break; case 133: /* --network-hook-dir */ hookdir = arg; break; /* * These reproduce what we would get without ARGP_NO_HELP */ case '?': /* --help */ argp_state_help(state, state->out_stream, (ARGP_HELP_STD_HELP | ARGP_HELP_EXIT_ERR) & ~(unsigned int)ARGP_HELP_EXIT_OK); case -3: /* --usage */ argp_state_help(state, state->out_stream, ARGP_HELP_USAGE | ARGP_HELP_EXIT_ERR); case 'V': /* --version */ fprintf_plus(state->out_stream, "%s\n", argp_program_version); exit(argp_err_exit_status); break; default: return ARGP_ERR_UNKNOWN; } return errno; } struct argp argp = { .options = options, .parser = parse_opt, .args_doc = "", .doc = "Mandos client -- Get and decrypt" " passwords from a Mandos server" }; ret_errno = argp_parse(&argp, argc, argv, ARGP_IN_ORDER | ARGP_NO_HELP, 0, NULL); switch(ret_errno){ case 0: break; case ENOMEM: default: errno = ret_errno; perror_plus("argp_parse"); exitcode = EX_OSERR; goto end; case EINVAL: exitcode = EX_USAGE; goto end; } } { /* Work around Debian bug #633582: <https://bugs.debian.org/633582> */ /* Re-raise privileges */ ret = raise_privileges(); if(ret != 0){ errno = ret; perror_plus("Failed to raise privileges"); } else { struct stat st; if(strcmp(seckey, PATHDIR "/" SECKEY) == 0){ int seckey_fd = open(seckey, O_RDONLY); if(seckey_fd == -1){ perror_plus("open"); } else { ret = (int)TEMP_FAILURE_RETRY(fstat(seckey_fd, &st)); if(ret == -1){ perror_plus("fstat"); } else { if(S_ISREG(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){ ret = fchown(seckey_fd, uid, gid); if(ret == -1){ perror_plus("fchown"); } } } close(seckey_fd); } } if(strcmp(pubkey, PATHDIR "/" PUBKEY) == 0){ int pubkey_fd = open(pubkey, O_RDONLY); if(pubkey_fd == -1){ perror_plus("open"); } else { ret = (int)TEMP_FAILURE_RETRY(fstat(pubkey_fd, &st)); if(ret == -1){ perror_plus("fstat"); } else { if(S_ISREG(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){ ret = fchown(pubkey_fd, uid, gid); if(ret == -1){ perror_plus("fchown"); } } } close(pubkey_fd); } } if(dh_params_file != NULL and strcmp(dh_params_file, PATHDIR "/dhparams.pem" ) == 0){ int dhparams_fd = open(dh_params_file, O_RDONLY); if(dhparams_fd == -1){ perror_plus("open"); } else { ret = (int)TEMP_FAILURE_RETRY(fstat(dhparams_fd, &st)); if(ret == -1){ perror_plus("fstat"); } else { if(S_ISREG(st.st_mode) and st.st_uid == 0 and st.st_gid == 0){ ret = fchown(dhparams_fd, uid, gid); if(ret == -1){ perror_plus("fchown"); } } } close(dhparams_fd); } } /* Lower privileges */ ret = lower_privileges(); if(ret != 0){ errno = ret; perror_plus("Failed to lower privileges"); } } } /* Remove invalid interface names (except "none") */ { char *interface = NULL; while((interface = argz_next(mc.interfaces, mc.interfaces_size, interface))){ if(strcmp(interface, "none") != 0 and if_nametoindex(interface) == 0){ if(interface[0] != '\0'){ fprintf_plus(stderr, "Not using nonexisting interface" " \"%s\"\n", interface); } argz_delete(&mc.interfaces, &mc.interfaces_size, interface); interface = NULL; } } } /* Run network hooks */ { if(mc.interfaces != NULL){ interfaces_hooks = malloc(mc.interfaces_size); if(interfaces_hooks == NULL){ perror_plus("malloc"); goto end; } memcpy(interfaces_hooks, mc.interfaces, mc.interfaces_size); argz_stringify(interfaces_hooks, mc.interfaces_size, (int)','); } run_network_hooks("start", interfaces_hooks != NULL ? interfaces_hooks : "", delay); } if(not debug){ avahi_set_log_function(empty_log); } /* Initialize Avahi early so avahi_simple_poll_quit() can be called from the signal handler */ /* Initialize the pseudo-RNG for Avahi */ srand((unsigned int) time(NULL)); simple_poll = avahi_simple_poll_new(); if(simple_poll == NULL){ fprintf_plus(stderr, "Avahi: Failed to create simple poll object.\n"); exitcode = EX_UNAVAILABLE; goto end; } sigemptyset(&sigterm_action.sa_mask); ret = sigaddset(&sigterm_action.sa_mask, SIGINT); if(ret == -1){ perror_plus("sigaddset"); exitcode = EX_OSERR; goto end; } ret = sigaddset(&sigterm_action.sa_mask, SIGHUP); if(ret == -1){ perror_plus("sigaddset"); exitcode = EX_OSERR; goto end; } ret = sigaddset(&sigterm_action.sa_mask, SIGTERM); if(ret == -1){ perror_plus("sigaddset"); exitcode = EX_OSERR; goto end; } /* Need to check if the handler is SIG_IGN before handling: | [[info:libc:Initial Signal Actions]] | | [[info:libc:Basic Signal Handling]] | */ ret = sigaction(SIGINT, NULL, &old_sigterm_action); if(ret == -1){ perror_plus("sigaction"); return EX_OSERR; } if(old_sigterm_action.sa_handler != SIG_IGN){ ret = sigaction(SIGINT, &sigterm_action, NULL); if(ret == -1){ perror_plus("sigaction"); exitcode = EX_OSERR; goto end; } } ret = sigaction(SIGHUP, NULL, &old_sigterm_action); if(ret == -1){ perror_plus("sigaction"); return EX_OSERR; } if(old_sigterm_action.sa_handler != SIG_IGN){ ret = sigaction(SIGHUP, &sigterm_action, NULL); if(ret == -1){ perror_plus("sigaction"); exitcode = EX_OSERR; goto end; } } ret = sigaction(SIGTERM, NULL, &old_sigterm_action); if(ret == -1){ perror_plus("sigaction"); return EX_OSERR; } if(old_sigterm_action.sa_handler != SIG_IGN){ ret = sigaction(SIGTERM, &sigterm_action, NULL); if(ret == -1){ perror_plus("sigaction"); exitcode = EX_OSERR; goto end; } } /* If no interfaces were specified, make a list */ if(mc.interfaces == NULL){ struct dirent **direntries = NULL; /* Look for any good interfaces */ ret = scandir(sys_class_net, &direntries, good_interface, alphasort); if(ret >= 1){ /* Add all found interfaces to interfaces list */ for(int i = 0; i < ret; ++i){ ret_errno = argz_add(&mc.interfaces, &mc.interfaces_size, direntries[i]->d_name); if(ret_errno != 0){ errno = ret_errno; perror_plus("argz_add"); free(direntries[i]); continue; } if(debug){ fprintf_plus(stderr, "Will use interface \"%s\"\n", direntries[i]->d_name); } free(direntries[i]); } free(direntries); } else { if(ret == 0){ free(direntries); } fprintf_plus(stderr, "Could not find a network interface\n"); exitcode = EXIT_FAILURE; goto end; } } /* Bring up interfaces which are down, and remove any "none"s */ { char *interface = NULL; while((interface = argz_next(mc.interfaces, mc.interfaces_size, interface))){ /* If interface name is "none", stop bringing up interfaces. Also remove all instances of "none" from the list */ if(strcmp(interface, "none") == 0){ argz_delete(&mc.interfaces, &mc.interfaces_size, interface); interface = NULL; while((interface = argz_next(mc.interfaces, mc.interfaces_size, interface))){ if(strcmp(interface, "none") == 0){ argz_delete(&mc.interfaces, &mc.interfaces_size, interface); interface = NULL; } } break; } bool interface_was_up = interface_is_up(interface); errno = bring_up_interface(interface, delay); if(not interface_was_up){ if(errno != 0){ fprintf_plus(stderr, "Failed to bring up interface \"%s\":" " %s\n", interface, strerror(errno)); } else { errno = argz_add(&interfaces_to_take_down, &interfaces_to_take_down_size, interface); if(errno != 0){ perror_plus("argz_add"); } } } } if(debug and (interfaces_to_take_down == NULL)){ fprintf_plus(stderr, "No interfaces were brought up\n"); } } /* If we only got one interface, explicitly use only that one */ if(argz_count(mc.interfaces, mc.interfaces_size) == 1){ if(debug){ fprintf_plus(stderr, "Using only interface \"%s\"\n", mc.interfaces); } if_index = (AvahiIfIndex)if_nametoindex(mc.interfaces); } if(quit_now){ goto end; } ret = init_gnutls_global(pubkey, seckey, dh_params_file, &mc); if(ret == -1){ fprintf_plus(stderr, "init_gnutls_global failed\n"); exitcode = EX_UNAVAILABLE; goto end; } else { gnutls_initialized = true; } if(quit_now){ goto end; } /* Try /run/tmp before /tmp */ tempdir = mkdtemp(run_tempdir); if(tempdir == NULL and errno == ENOENT){ if(debug){ fprintf_plus(stderr, "Tempdir %s did not work, trying %s\n", run_tempdir, old_tempdir); } tempdir = mkdtemp(old_tempdir); } if(tempdir == NULL){ perror_plus("mkdtemp"); goto end; } if(quit_now){ goto end; } if(not init_gpgme(pubkey, seckey, tempdir, &mc)){ fprintf_plus(stderr, "init_gpgme failed\n"); exitcode = EX_UNAVAILABLE; goto end; } else { gpgme_initialized = true; } if(quit_now){ goto end; } if(connect_to != NULL){ /* Connect directly, do not use Zeroconf */ /* (Mainly meant for debugging) */ char *address = strrchr(connect_to, ':'); if(address == NULL){ fprintf_plus(stderr, "No colon in address\n"); exitcode = EX_USAGE; goto end; } if(quit_now){ goto end; } in_port_t port; errno = 0; tmpmax = strtoimax(address+1, &tmp, 10); if(errno != 0 or tmp == address+1 or *tmp != '\0' or tmpmax != (in_port_t)tmpmax){ fprintf_plus(stderr, "Bad port number\n"); exitcode = EX_USAGE; goto end; } if(quit_now){ goto end; } port = (in_port_t)tmpmax; *address = '\0'; /* Colon in address indicates IPv6 */ int af; if(strchr(connect_to, ':') != NULL){ af = AF_INET6; /* Accept [] around IPv6 address - see RFC 5952 */ if(connect_to[0] == '[' and address[-1] == ']') { connect_to++; address[-1] = '\0'; } } else { af = AF_INET; } address = connect_to; if(quit_now){ goto end; } while(not quit_now){ ret = start_mandos_communication(address, port, if_index, af, &mc); if(quit_now or ret == 0){ break; } if(debug){ fprintf_plus(stderr, "Retrying in %d seconds\n", (int)retry_interval); } sleep((unsigned int)retry_interval); } if(not quit_now){ exitcode = EXIT_SUCCESS; } goto end; } if(quit_now){ goto end; } { AvahiServerConfig config; /* Do not publish any local Zeroconf records */ avahi_server_config_init(&config); config.publish_hinfo = 0; config.publish_addresses = 0; config.publish_workstation = 0; config.publish_domain = 0; /* Allocate a new server */ mc.server = avahi_server_new(avahi_simple_poll_get(simple_poll), &config, NULL, NULL, &ret); /* Free the Avahi configuration data */ avahi_server_config_free(&config); } /* Check if creating the Avahi server object succeeded */ if(mc.server == NULL){ fprintf_plus(stderr, "Failed to create Avahi server: %s\n", avahi_strerror(ret)); exitcode = EX_UNAVAILABLE; goto end; } if(quit_now){ goto end; } /* Create the Avahi service browser */ sb = avahi_s_service_browser_new(mc.server, if_index, AVAHI_PROTO_UNSPEC, "_mandos._tcp", NULL, 0, browse_callback, (void *)&mc); if(sb == NULL){ fprintf_plus(stderr, "Failed to create service browser: %s\n", avahi_strerror(avahi_server_errno(mc.server))); exitcode = EX_UNAVAILABLE; goto end; } if(quit_now){ goto end; } /* Run the main loop */ if(debug){ fprintf_plus(stderr, "Starting Avahi loop search\n"); } ret = avahi_loop_with_timeout(simple_poll, (int)(retry_interval * 1000), &mc); if(debug){ fprintf_plus(stderr, "avahi_loop_with_timeout exited %s\n", (ret == 0) ? "successfully" : "with error"); } end: if(debug){ if(signal_received){ fprintf_plus(stderr, "%s exiting due to signal %d: %s\n", argv[0], signal_received, strsignal(signal_received)); } else { fprintf_plus(stderr, "%s exiting\n", argv[0]); } } /* Cleanup things */ free(mc.interfaces); if(sb != NULL) avahi_s_service_browser_free(sb); if(mc.server != NULL) avahi_server_free(mc.server); if(simple_poll != NULL) avahi_simple_poll_free(simple_poll); if(gnutls_initialized){ gnutls_certificate_free_credentials(mc.cred); gnutls_dh_params_deinit(mc.dh_params); } if(gpgme_initialized){ gpgme_release(mc.ctx); } /* Cleans up the circular linked list of Mandos servers the client has seen */ if(mc.current_server != NULL){ mc.current_server->prev->next = NULL; while(mc.current_server != NULL){ server *next = mc.current_server->next; #ifdef __GNUC__ #pragma GCC diagnostic push #pragma GCC diagnostic ignored "-Wcast-qual" #endif free((char *)(mc.current_server->ip)); #ifdef __GNUC__ #pragma GCC diagnostic pop #endif free(mc.current_server); mc.current_server = next; } } /* Re-raise privileges */ { ret = raise_privileges(); if(ret != 0){ errno = ret; perror_plus("Failed to raise privileges"); } else { /* Run network hooks */ run_network_hooks("stop", interfaces_hooks != NULL ? interfaces_hooks : "", delay); /* Take down the network interfaces which were brought up */ { char *interface = NULL; while((interface = argz_next(interfaces_to_take_down, interfaces_to_take_down_size, interface))){ ret = take_down_interface(interface); if(ret != 0){ errno = ret; perror_plus("Failed to take down interface"); } } if(debug and (interfaces_to_take_down == NULL)){ fprintf_plus(stderr, "No interfaces needed to be taken" " down\n"); } } } ret = lower_privileges_permanently(); if(ret != 0){ errno = ret; perror_plus("Failed to lower privileges permanently"); } } free(interfaces_to_take_down); free(interfaces_hooks); void clean_dir_at(int base, const char * const dirname, uintmax_t level){ struct dirent **direntries = NULL; int dret; int dir_fd = (int)TEMP_FAILURE_RETRY(openat(base, dirname, O_RDONLY | O_NOFOLLOW | O_DIRECTORY | O_PATH)); if(dir_fd == -1){ perror_plus("open"); return; } int numentries = scandirat(dir_fd, ".", &direntries, notdotentries, alphasort); if(numentries >= 0){ for(int i = 0; i < numentries; i++){ if(debug){ fprintf_plus(stderr, "Unlinking \"%s/%s\"\n", dirname, direntries[i]->d_name); } dret = unlinkat(dir_fd, direntries[i]->d_name, 0); if(dret == -1){ if(errno == EISDIR){ dret = unlinkat(dir_fd, direntries[i]->d_name, AT_REMOVEDIR); } if((dret == -1) and (errno == ENOTEMPTY) and (strcmp(direntries[i]->d_name, "private-keys-v1.d") == 0) and (level == 0)){ /* Recurse only in this special case */ clean_dir_at(dir_fd, direntries[i]->d_name, level+1); dret = 0; } if((dret == -1) and (errno != ENOENT)){ fprintf_plus(stderr, "unlink(\"%s/%s\"): %s\n", dirname, direntries[i]->d_name, strerror(errno)); } } free(direntries[i]); } /* need to clean even if 0 because man page doesn't specify */ free(direntries); dret = unlinkat(base, dirname, AT_REMOVEDIR); if(dret == -1 and errno != ENOENT){ perror_plus("rmdir"); } } else { perror_plus("scandirat"); } close(dir_fd); } /* Removes the GPGME temp directory and all files inside */ if(tempdir != NULL){ clean_dir_at(-1, tempdir, 0); } if(quit_now){ sigemptyset(&old_sigterm_action.sa_mask); old_sigterm_action.sa_handler = SIG_DFL; ret = (int)TEMP_FAILURE_RETRY(sigaction(signal_received, &old_sigterm_action, NULL)); if(ret == -1){ perror_plus("sigaction"); } do { ret = raise(signal_received); } while(ret != 0 and errno == EINTR); if(ret != 0){ perror_plus("raise"); abort(); } TEMP_FAILURE_RETRY(pause()); } return exitcode; }
=== modified file 'plugins.d/mandos-client.c' --- plugins.d/mandos-client.c 2018-04-01 19:35:00 +0000 +++ plugins.d/mandos-client.c 2018-04-01 22:08:50 +0000 @@ -310,6 +310,81 @@ gpgme_strsource(rc), gpgme_strerror(rc)); return false; } + { + gpgme_import_result_t import_result + = gpgme_op_import_result(mc->ctx); + if((import_result->imported < 1 + or import_result->not_imported > 0) + and import_result->unchanged == 0){ + fprintf_plus(stderr, "bad gpgme_op_import_results:\n"); + fprintf_plus(stderr, + "The total number of considered keys: %d\n", + import_result->considered); + fprintf_plus(stderr, + "The number of keys without user ID: %d\n", + import_result->no_user_id); + fprintf_plus(stderr, + "The total number of imported keys: %d\n", + import_result->imported); + fprintf_plus(stderr, "The number of imported RSA keys: %d\n", + import_result->imported_rsa); + fprintf_plus(stderr, "The number of unchanged keys: %d\n", + import_result->unchanged); + fprintf_plus(stderr, "The number of new user IDs: %d\n", + import_result->new_user_ids); + fprintf_plus(stderr, "The number of new sub keys: %d\n", + import_result->new_sub_keys); + fprintf_plus(stderr, "The number of new signatures: %d\n", + import_result->new_signatures); + fprintf_plus(stderr, "The number of new revocations: %d\n", + import_result->new_revocations); + fprintf_plus(stderr, + "The total number of secret keys read: %d\n", + import_result->secret_read); + fprintf_plus(stderr, + "The number of imported secret keys: %d\n", + import_result->secret_imported); + fprintf_plus(stderr, + "The number of unchanged secret keys: %d\n", + import_result->secret_unchanged); + fprintf_plus(stderr, "The number of keys not imported: %d\n", + import_result->not_imported); + for(gpgme_import_status_t import_status + = import_result->imports; + import_status != NULL; + import_status = import_status->next){ + fprintf_plus(stderr, "Import status for key: %s\n", + import_status->fpr); + if(import_status->result != GPG_ERR_NO_ERROR){ + fprintf_plus(stderr, "Import result: %s: %s\n", + gpgme_strsource(import_status->result), + gpgme_strerror(import_status->result)); + } + fprintf_plus(stderr, "Key status:\n"); + fprintf_plus(stderr, + import_status->status & GPGME_IMPORT_NEW + ? "The key was new.\n" + : "The key was not new.\n"); + fprintf_plus(stderr, + import_status->status & GPGME_IMPORT_UID + ? "The key contained new user IDs.\n" + : "The key did not contain new user IDs.\n"); + fprintf_plus(stderr, + import_status->status & GPGME_IMPORT_SIG + ? "The key contained new signatures.\n" + : "The key did not contain new signatures.\n"); + fprintf_plus(stderr, + import_status->status & GPGME_IMPORT_SUBKEY + ? "The key contained new sub keys.\n" + : "The key did not contain new sub keys.\n"); + fprintf_plus(stderr, + import_status->status & GPGME_IMPORT_SECRET + ? "The key contained a secret key.\n" + : "The key did not contain a secret key.\n"); + } + return false; + } + } ret = close(fd); if(ret == -1){
signature.asc
Description: PGP signature