Hi Andreas,

Andreas Schmidt <p...@arcor.de> writes:

> Package: needrestart
> Version: 3.0-1
> Severity: normal
>
> Dear Maintainer,
>
> the new GTK-3 frontend to needrestart has two buttons: <BACK> and
> <NEXT>.

needrestart does not have a graphical frontend at all ;-). I think you
are using the debconf frontend which might use some Gtk3 frontend (which
is out of needrestart's scope).

> Pressing <NEXT> results in a restart of the services checked in the main 
> window
> -- as expected. I assumed that with the other button I could quit the dialogue
> without restarting anything. However, hitting <BACK> gives me this message in
> the terminal:
>
> ***
> (frontend:20760): Gtk-CRITICAL **: gtk_assistant_previous_page: assertion
> 'page_node != NULL' failed
> ***
>
> The program continues to work, so this error is just a nuisance. However, With
> this error, the button is useless and should be removed or replaced. What do
> you think about the following suggestion?

There should be a OK and a Cancel button. Testing on stretch (using
needrestart -f <FRONTEND>) it seems to work showing the following
buttons:

dialog: OK, Cancel
gnome: OK, Cancel
kde: OK, Cancel, Back (where 'Back' works like Cancel)


> After updating packages like libc6, needrestart finds lots of services that
> need a restart. There are occasions where restarting them should be delayed --
> just think of a download running in the background that would be interrupted
> for good if network-related services were stopped. In such cases it could be
> quite a tiresome task to manually deselect all listed services and press
> <NEXT>. It would be much easier to have a <CANCEL> button that quits the
> program without restarting anything. Another idea would be to provide a
> checkbox on top (and possibly an identical one at the bottom) of the list that
> turns the checkboxes of all listed services on/off. This would provide an easy
> way to activate a restart of all services, if needed. It might be dangerous,
> though, because it could lead to inadvertently killing the whole X-session if,
> say, dbus was restarted.

Needrestart tries to provide sane default so it should not kill your
X-session nor network connection unless you've changed it's
configuration or select the services explicitly.

The should be a Cancel button which should result in *no* service
restart. If the button is missing while running needrestart on sid than
this is a regression which might be triggered by changes in debconf.

When using debconf (which is the prefered UI) it is not possible to add
custom buttons or checkboxes - debconf does all the magic building the
dialog.


HTH,
Thomas


> Thank you for your consideration!
>
> Andreas
>
>
>
> -- Package-specific info:
> needrestart output:
> Your outdated processes:
> alarm-clock-app[8901], atril[8865, 8892, 8893, 8945, 8936, 8934, 8947, 4626, 
> 8894, 8895, 8943, 8897, 8946, 8932, 24870, 26930, 8864, 8898, 8896, 8933, 
> 8926, 8944], atrild[9180], audacity[7089], balsa[13182], bash[9074, 9081, 
> 9072, 9299, 9076, 9098, 9075, 9091, 9073, 9086, 9094, 9087, 9101, 6716, 9085, 
> 19128, 9078, 9089, 5984, 9071, 9080, 9088, 9166, 9100, 9099, 9077, 9093, 
> 9090, 9083, 9082, 9079, 7243, 9084, 9097], dbus-daemon[8726], 
> dbus-launch[8725], dconf-service[8759], dirmngr[21365], firefox-esr[8866], 
> gconfd-2[8918], gconf-helper[2134], geany[9145], gvfs-afc-volume[8832], 
> gvfsd[8745], gvfsd-computer[26884], gvfsd-dnssd[25296], gvfsd-fuse[8750], 
> gvfsd-metadata[10665], gvfsd-network[25244], gvfsd-trash[10748], 
> gvfs-goa-volume[8826], gvfs-gphoto2-vo[8841], gvfs-mtp-volume[8852], 
> gvfs-udisks2-vo[8810], hamster-service[19488], light-locker[8835], 
> marco[8786], mate-power-mana[8902], mate-screensave[11803], 
> mate-session[8698], mate-settings-d[8776], mate-terminal[8937], 
> mate-user-share[8899], mate-volume-con[8948], mc[7241, 19126, 9272, 6714], 
> mocp[8409, 27558], msd-locate-poin[8806], needrestart-dbu[2101, 8916], 
> oosplash[5959], pluma[8927], polkit-mate-aut[8924], pulseaudio[2026], 
> sh[8884], soffice.bin[5978], systemd[1907], vlc[8343, 10195], 
> WebKitNetworkPr[10439, 10441, 4641, 10448, 10435, 10428, 10444, 10447, 10431, 
> 10433, 10440, 10438, 10437, 26946, 10445, 10423, 10443, 10442, 24736, 10449, 
> 24886, 10430, 10446], zeitgeist-daemo[8906], zeitgeist-datah[8921], 
> zeitgeist-fts[8983]
>
> checkrestart output:
>
>
> -- System Information:
> Debian Release: buster/sid
>   APT prefers unstable-debug
>   APT policy: (500, 'unstable-debug'), (500, 'unstable')
> Architecture: amd64 (x86_64)
> Foreign Architectures: i386
>
> Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
> LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
> LSM: AppArmor: enabled
>
> Versions of packages needrestart depends on:
> ii  binutils                   2.30-5
> ii  dpkg                       1.19.0.5
> ii  gettext-base               0.19.8.1-4
> ii  libintl-perl               1.26-2
> ii  libmodule-find-perl        0.13-1
> ii  libmodule-scandeps-perl    1.24-1
> ii  libproc-processtable-perl  0.55-1
> ii  libsort-naturally-perl     1.03-2
> ii  libterm-readkey-perl       2.37-1+b2
> ii  perl                       5.26.1-5
> ii  xz-utils                   5.2.2-1.3
>
> Versions of packages needrestart recommends:
> ii  libpam-systemd  237-4
>
> Versions of packages needrestart suggests:
> ii  libnotify-bin        0.7.7-3
> ii  needrestart-session  0.3-5
>
> -- no debconf information
>

-- 

    ::  WWW:                        https://fiasko-nw.net/~thomas/  ::
   :::  Jabber:                   xmpp:tho...@jabber.fiasko-nw.net  :::
    ::  flickr:             https://www.flickr.com/photos/laugufe/  ::

Reply via email to