Control: tags 884940 + patch Control: tags 884940 + pending Dear maintainer,
I've prepared an NMU for goldencheetah (versioned as 1:3.5~DEV1710-1.2) and uploaded it to DELAYED/7. Please feel free to tell me if I should delay it longer. Cheers -- Sebastian Ramacher
diff -Nru goldencheetah-3.5~DEV1710/debian/changelog goldencheetah-3.5~DEV1710/debian/changelog
--- goldencheetah-3.5~DEV1710/debian/changelog 2017-12-17 12:42:17.000000000 +0100
+++ goldencheetah-3.5~DEV1710/debian/changelog 2018-03-10 17:01:56.000000000 +0100
@@ -1,3 +1,11 @@
+goldencheetah (1:3.5~DEV1710-1.2) unstable; urgency=medium
+
+ * Non-maintainer upload.
+ * debian/patches/dont-link-libvlccore.patch: Do not unnecessarily link
+ against libvlccore. (Closes: #884940)
+
+ -- Sebastian Ramacher <sramac...@debian.org> Sat, 10 Mar 2018 17:01:56 +0100
+
goldencheetah (1:3.5~DEV1710-1.1) unstable; urgency=medium
* Non-maintainer upload.
diff -Nru goldencheetah-3.5~DEV1710/debian/patches/dont-link-libvlccore.patch goldencheetah-3.5~DEV1710/debian/patches/dont-link-libvlccore.patch
--- goldencheetah-3.5~DEV1710/debian/patches/dont-link-libvlccore.patch 1970-01-01 01:00:00.000000000 +0100
+++ goldencheetah-3.5~DEV1710/debian/patches/dont-link-libvlccore.patch 2018-03-10 17:00:31.000000000 +0100
@@ -0,0 +1,43 @@
+From 3dd20804e9550db5274f6cdae04f616dc82ecae3 Mon Sep 17 00:00:00 2001
+From: Sebastian Ramacher <sramac...@debian.org>
+Date: Thu, 21 Dec 2017 20:39:11 +0100
+Subject: [PATCH] Remove unnecessary linking against libvlccore
+
+libvlccore is for plugins, but GoldenCheetah does not build a plugin. It
+requires only functions available from libvlc.
+
+Signed-off-by: Sebastian Ramacher <sramac...@debian.org>
+---
+ src/gcconfig.pri.in | 4 ++--
+ src/src.pro | 2 +-
+ 2 files changed, 3 insertions(+), 3 deletions(-)
+
+diff --git a/src/gcconfig.pri.in b/src/gcconfig.pri.in
+index 8ee3f0dda..9e4f399b0 100644
+--- a/src/gcconfig.pri.in
++++ b/src/gcconfig.pri.in
+@@ -211,9 +211,9 @@
+ # This will automatically set (Windows and Unix):
+ # VLC_INCLUDE = $${VLC_INSTALL}/include
+ # For Windows
+-# VLC_LIBS = $${VLC_INSTALL}/lib/libvlc.dll.a $${VLC_INSTALL}/lib/libvlccore.dll.a
++# VLC_LIBS = $${VLC_INSTALL}/lib/libvlc.dll.a
+ # For Unix
+-# VLC_LIBS = -lvlc -lvlccore
++# VLC_LIBS = -lvlc
+ # You may override the INCLUDE and LIB files if you like.
+ # You *must* define VLC_INSTALL to use this feature.
+ #VLC_INSTALL =
+diff --git a/src/src.pro b/src/src.pro
+index 79e762ab4..fcd733240 100644
+--- a/src/src.pro
++++ b/src/src.pro
+@@ -537,7 +537,7 @@ unix:!macx {
+
+ # we will work out the rest if you tell use where it is installed
+ isEmpty(VLC_INCLUDE) { VLC_INCLUDE = $${VLC_INSTALL}/include }
+- isEmpty(VLC_LIBS) { VLC_LIBS = -L$${VLC_INSTALL}/lib -lvlc -lvlccore }
++ isEmpty(VLC_LIBS) { VLC_LIBS = -L$${VLC_INSTALL}/lib -lvlc }
+
+ DEFINES += GC_HAVE_VLC
+ INCLUDEPATH += $${VLC_INCLUDE}
diff -Nru goldencheetah-3.5~DEV1710/debian/patches/series goldencheetah-3.5~DEV1710/debian/patches/series
--- goldencheetah-3.5~DEV1710/debian/patches/series 2017-12-17 12:42:06.000000000 +0100
+++ goldencheetah-3.5~DEV1710/debian/patches/series 2018-03-10 17:01:02.000000000 +0100
@@ -2,3 +2,4 @@
append-uncompressed-jquery
avoid-link-google-logo
libical3.diff
+dont-link-libvlccore.patch
signature.asc
Description: PGP signature
