On 03/09/2018 05:49 PM, Chris Lamb wrote: > Hi Thomas, > >> https://review.openstack.org/551269 > > Thanks for doing this. :) But wouldn't it make more sense — as the > package maintainer in Debian — for you to handle these? :)
Of course it does make sense. Though I told you because you attempted to upstream the patch using github, and I thought it was best to let you know that you shouldn't do that, because it's a waste of time: the pull request will automatically be closed telling you to use gerrit. I also feel like cheating you if I upload the change, and then take over the ownership of the patch. If you're ok with that, then I'm very happy to have a few patch here and there in OpenStack, so I can participate in the elections of the leaders of each project ! It's always nice to have the opportunity to vote for friends. > Sure, if the patch was huge, added features or was otherwise invasive > I would perfectly understand going to upstream, but for these smaller > changes I can't help but feel this is the responsibility of the > maintainer in Debian. Sure. > This is especially so as there seems to be a number of things one needs > to do to get a single line upstream, such as the CLA (meh..) as well as > knowing how to use navigate Gerrit and even to know *where* to send > the patch. FYI, there's just the CLA once (I don't like it either... though it's the nicer type of CLA, where you just confirm you're using the upstream Apache-2.0 license for all of your contrib, nothing more), and then nothing else to know about. Just "git review" and it will send the patch to the correct place automatically (thanks to the .gitreview file in each project). The only other thing there is to know is from were to clone the upstream source. If it's a package from Debian OpenStack team, then either there's an UPSTREAM_GIT= in debian/rules, or it's systematically from https://git.openstack.org/<FOO> (or from Github which holds a copy). Again, all I'm telling here, you don't need to know, I'm very happy to upstream these patches myself, I just didn't want you to waste your time sending patches as Github pull requests which goes nowhere. Thanks for your patch, and working on reproducible-build, Cheers, Thomas Goirand (zigo)
