Le vendredi 09 mars 2018 à 17:45:44+0100, Pierre-Elliott Bécue a écrit : > Le samedi 10 mars 2018 à 01:21:20+0900, Osamu Aoki a écrit : > > Hi, > > > > Yes this looks trivial patch which I chose not to add complication at > > one point in history. But people insist and applied patch ... > > > > Whoever take responsibility for this patch need to read all other parts > > of code too. By adding this convenience feature, signature check and > > repacking code may not function as documented unless you add handling > > code for them. --- This was my reason not adding these. Now you are-in. > > Please continue your work on uscan ;-) Welcome to uscan maintenance. > > Hi, > > I'm not sure to understand how this could induce any issue? People already > put tgz or other extensions in their d/watch file[1] and this seems to work > properly so far. > > This piece of code is just designed to replace @ARCHIVE_EXT@ and > @SIGNATURE_EXT@ by a regexp. These are never used in the remaining portions > of uscan.pl or mk-origtargz.pl. > > Could you help me at seeing how these changes might introduce any issue? > > Cheers. :)
To be more specific, I reviewed your changes introducing these lines of code before applying the patch. The commit that introduced the @ARCHIVE_EXT@ feature is https://salsa.debian.org/debian/devscripts/commit/8ebab1c2bfa97830ca670d6830444297910282c7 Seeing that, I determined that adding extensions wouldn't break uscan any more than it could be by having directly these in d/watch files. -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them.
signature.asc
Description: PGP signature
