Hello!

Wouter Verhelst said:
> I'm attaching a quick-and-dirty patch which applies to monit-4.5 as it
> is in sarge, and which is the version that I'm currently using on this
> cluster. It's ugly, but it does what I needed it to do and was all I
> could come up with in the short timeframe that was given for this
> project. I know that's not very helpful; however, if upstream is
> interested, I'd be happy to help clean it up and provide a more robust
> method to differentiate log levels.

I agree that log differentiation would be good, and judging from
your patch, much needed :).

I'm just about preparing monit 4.7, but the patch did not apply very cleanly
(i.e. some 20 rejects), which means that new upstream versions probably
also will need hands on fixing. I also noted that upstream is
considering implementing this, which would be a much better solution.

However, I think your patch is a good starting point, especially as
much of the work involves determining the semantic of the log message
(i.e. error, debug, etc). When the logging framework has been decided
upon, it should be routine work (or even sed'able) to implement.

Thanks,
 Stefan






Reply via email to