Hi Rogério, On Sun, Feb 18, 2018 at 08:56:23PM -0300, Rogério Brito wrote: > Hi, Nicholas. > > There's no need to rush with any upload, as I am going to take care of that > myself. > > BTW, we had, essentially, a whole week of extended holidays here in Brazil > during this week (Carnival), which was the reason why I had not replied > earlier (poor connectivity etc.).
OK, sorry for assuming you might not be around for longer. Also, sorry for the slow reply, I am myself travelling this week. I'm closing the RFS as you will take care of it. :) > > It removes youtube-dl's built-in autoupdate mechanism, whose security > > is unclear and which is defunct on Debian anyhow (see #890119 for details). > > I am OK (not super happy, but OK) with the removal of the --upgrade option > of youtube-dl, *BUT* I think that removing it completely and giving the > users that try to invoke the command with that option something like "option > not recognized" is a poor user-experience. What's making you unhappy with the removal of that code, given that it is (supposed ot be) defunct on Debian anyhow? > We should, *IF* we remove the option, substitute it with an output saying > that in Debian (and other derived distributions) we have disabled that > option. Not having this will make users confused, since it would deviate > from the behavior of upstream. That's fairly sensible, I will update the patch in the PR. > > @Rogério: This exactly adds the patch I sent to the packaging repository in > > https://github.com/rbrito/pkg-youtube-dl/pull/2 > > However, since the state of the packaging repository is > > inconsistent > > with what is in the Debian archive, you will need to push to the > > repository, merge my PR, and then manually grab the updated > > changelog. > > Yes, I have not yet taken the time to migrate things to salsa.debian.org. I > will do as soon as I get familiar with the needed changes. A migration to salsa should be straightforward, but in the meantime, pushing the current version to the Github repo would be appreciated :) > > Note that there are 2 minor issues in the package that I did not change: > > - The package still uses dh 10 > > I have no idea whether the maintainer wants to switch to dh 11 > > That's on purpose/intentional, to ease backporting for people that don't > have a debhelper so recent. OK, I assumed as much :) > > - groff throws a warning on the youtube-dl(1) manpage (lintian tag > > manpage-has-errors-from-man), but I believe this is out of scope for this > > NMU. > > This problem has been communicated upstream and we reached the conclusion > that it is a problem with pandoc... Thanks for the info. Best, nicoo
