forwarded 889928 https://github.com/salt-formulas/salt-formula-cinder/pull/23
thanks
Hi,
the build failure is caused by missing Python 3 support. I created a
upstream pull request and backported that commit for the Debian package.
An attached patch that I applied for the Ubuntu package is attached.
On Thu, 08 Feb 2018 23:03:43 +0200 Adrian Bunk <b...@debian.org> wrote:
> Source: salt-formula-cinder
> Version: 2016.12.1-1
> Severity: serious
>
> https://ci.debian.net/packages/s/salt-formula-cinder/unstable/amd64/
> https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/sal
t-formula-cinder.html
>
> ...
> dh_auto_test
> make -j15 test
> make[1]: Entering directory '/build/1st/salt-formula-cinder-2016.12.1'
> [ ! -d tests ] || (cd tests; ./run_tests.sh)
> /usr/bin/salt-call
> [WARNING ] Failed to open log file, do you have permission to write to
/var/log/salt/minion?
> [ERROR ] Rendering exception occurred: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> [CRITICAL] Rendering SLS 'base:cinder.controller' failed: Jinja
variable 'salt.utils.odict.OrderedDict object' has no attribute
'iteritems'
> [ERROR ] Rendering exception occurred: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> [CRITICAL] Rendering SLS 'base:cinder.volume' failed: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> local:
> - Rendering SLS 'base:cinder.controller' failed: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> - Rendering SLS 'base:cinder.volume' failed: Jinja variable
'salt.utils.odict.OrderedDict object' has no attribute 'iteritems'
> [ERROR] Execution of cinder.ceph_single failed
> [ERROR] Execution failed
> Makefile:22: recipe for target 'test' failed
> make[1]: *** [test] Error 1
>
>
--
Benjamin Drung
Debian & Ubuntu Developer
diff -Nru salt-formula-cinder-2016.12.1/debian/changelog salt-formula-cinder-2016.12.1/debian/changelog
--- salt-formula-cinder-2016.12.1/debian/changelog 2016-12-25 17:05:43.000000000 +0100
+++ salt-formula-cinder-2016.12.1/debian/changelog 2018-02-15 00:25:17.000000000 +0100
@@ -1,3 +1,9 @@
+salt-formula-cinder (2016.12.1-1ubuntu1) bionic; urgency=medium
+
+ * Support Python 3 (Closes: #889928)
+
+ -- Benjamin Drung <bdr...@ubuntu.com> Thu, 15 Feb 2018 00:25:17 +0100
+
salt-formula-cinder (2016.12.1-1) unstable; urgency=medium
* New upstream release
diff -Nru salt-formula-cinder-2016.12.1/debian/control salt-formula-cinder-2016.12.1/debian/control
--- salt-formula-cinder-2016.12.1/debian/control 2016-11-21 15:55:43.000000000 +0100
+++ salt-formula-cinder-2016.12.1/debian/control 2018-02-15 00:25:17.000000000 +0100
@@ -1,5 +1,6 @@
Source: salt-formula-cinder
-Maintainer: PKG OpenStack <openstack-de...@lists.alioth.debian.org>
+Maintainer: Ubuntu Developers <ubuntu-devel-disc...@lists.ubuntu.com>
+XSBC-Original-Maintainer: PKG OpenStack <openstack-de...@lists.alioth.debian.org>
Uploaders: Filip Pytloun <fi...@pytloun.cz>,
Ondřej Nový <on...@debian.org>,
Section: admin
diff -Nru salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch
--- salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch 1970-01-01 01:00:00.000000000 +0100
+++ salt-formula-cinder-2016.12.1/debian/patches/0001-Support-Python-3.patch 2018-02-15 00:25:17.000000000 +0100
@@ -0,0 +1,270 @@
+From c5ea00cd7379b8a1dfcdc224c4a8de81553a8f28 Mon Sep 17 00:00:00 2001
+From: Benjamin Drung <bdr...@debian.org>
+Date: Wed, 14 Feb 2018 23:44:07 +0100
+Subject: [PATCH] Support Python 3
+
+Bug-Debian: https://bugs.debian.org/889928
+Forwarded: https://github.com/salt-formulas/salt-formula-cinder/pull/23
+---
+ cinder/client.sls | 4 ++--
+ cinder/controller.sls | 4 ++--
+ cinder/files/juno/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/juno/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/kilo/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/kilo/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/liberty/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/liberty/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/mitaka/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/mitaka/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/newton/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/newton/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/ocata/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/ocata/cinder.conf.volume.Debian | 4 ++--
+ cinder/files/pike/cinder.conf.controller.Debian | 4 ++--
+ cinder/files/pike/cinder.conf.volume.Debian | 4 ++--
+ cinder/meta/sphinx.yml | 4 ++--
+ cinder/volume.sls | 2 +-
+ 18 files changed, 35 insertions(+), 35 deletions(-)
+
+--- a/cinder/controller.sls
++++ b/cinder/controller.sls
+@@ -51,7 +51,7 @@
+
+ {# new way #}
+
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in controller.get('backend', {}).items() %}
+
+ cinder_type_create_{{ backend_name }}:
+ cmd.run:
+--- a/cinder/files/juno/cinder.conf.controller.Debian
++++ b/cinder/files/juno/cinder.conf.controller.Debian
+@@ -37,7 +37,7 @@
+
+ default_volume_type={{ controller.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in controller.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in controller.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- else %}
+
+@@ -106,7 +106,7 @@
+
+ {%- if controller.backend is defined %}
+
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in controller.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/juno/cinder.conf.volume.Debian
++++ b/cinder/files/juno/cinder.conf.volume.Debian
+@@ -37,7 +37,7 @@
+
+ default_volume_type={{ volume.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in volume.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in volume.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- else %}
+
+@@ -115,7 +115,7 @@
+
+ {%- if volume.backend is defined %}
+
+-{%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in volume.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/kilo/cinder.conf.controller.Debian
++++ b/cinder/files/kilo/cinder.conf.controller.Debian
+@@ -40,7 +40,7 @@
+
+ default_volume_type={{ controller.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in controller.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in controller.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- else %}
+
+@@ -143,7 +143,7 @@
+
+ {%- if controller.backend is defined %}
+
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in controller.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/kilo/cinder.conf.volume.Debian
++++ b/cinder/files/kilo/cinder.conf.volume.Debian
+@@ -39,7 +39,7 @@
+
+ default_volume_type={{ volume.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in volume.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in volume.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- else %}
+
+@@ -152,7 +152,7 @@
+
+ {%- if volume.backend is defined %}
+
+-{%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in volume.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/liberty/cinder.conf.controller.Debian
++++ b/cinder/files/liberty/cinder.conf.controller.Debian
+@@ -40,7 +40,7 @@
+
+ default_volume_type={{ controller.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in controller.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in controller.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- else %}
+
+@@ -145,7 +145,7 @@
+
+ {%- if controller.backend is defined %}
+
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in controller.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/liberty/cinder.conf.volume.Debian
++++ b/cinder/files/liberty/cinder.conf.volume.Debian
+@@ -39,7 +39,7 @@
+
+ default_volume_type={{ volume.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in volume.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in volume.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- else %}
+
+@@ -152,7 +152,7 @@
+
+ {%- if volume.backend is defined %}
+
+-{%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in volume.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/mitaka/cinder.conf.controller.Debian
++++ b/cinder/files/mitaka/cinder.conf.controller.Debian
+@@ -38,7 +38,7 @@
+
+ default_volume_type={{ controller.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in controller.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in controller.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- endif %}
+
+@@ -117,7 +117,7 @@
+
+ {%- if controller.backend is defined %}
+
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in controller.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/mitaka/cinder.conf.volume.Debian
++++ b/cinder/files/mitaka/cinder.conf.volume.Debian
+@@ -38,7 +38,7 @@
+
+ default_volume_type={{ volume.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in volume.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in volume.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- endif %}
+
+@@ -115,7 +115,7 @@
+
+ {%- if volume.backend is defined %}
+
+-{%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in volume.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/newton/cinder.conf.controller.Debian
++++ b/cinder/files/newton/cinder.conf.controller.Debian
+@@ -38,7 +38,7 @@
+
+ default_volume_type={{ controller.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in controller.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in controller.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- endif %}
+
+@@ -126,7 +126,7 @@
+
+ {%- if controller.backend is defined %}
+
+-{%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in controller.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/files/newton/cinder.conf.volume.Debian
++++ b/cinder/files/newton/cinder.conf.volume.Debian
+@@ -38,7 +38,7 @@
+
+ default_volume_type={{ volume.default_volume_type }}
+
+-enabled_backends={% for backend_name, backend in volume.get('backend', {}).iteritems() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
++enabled_backends={% for backend_name, backend in volume.get('backend', {}).items() %}{{ backend_name }}{% if not loop.last %},{% endif %}{% endfor %}
+
+ {%- endif %}
+
+@@ -122,7 +122,7 @@
+
+ {%- if volume.backend is defined %}
+
+-{%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in volume.get('backend', {}).items() %}
+
+ {%- set backend_fragment = "cinder/files/backend/_" + backend.engine + ".conf" %}
+ {%- include backend_fragment %}
+--- a/cinder/meta/sphinx.yml
++++ b/cinder/meta/sphinx.yml
+@@ -39,7 +39,7 @@
+ {%- if controller.backend is defined %}
+ backends:
+ value: |
+- {%- for backend_name, backend in controller.get('backend', {}).iteritems() %}
++ {%- for backend_name, backend in controller.get('backend', {}).items() %}
+ * {{ backend_name }}:
+ * storage engine: {{ backend.engine }}
+ * volume type: {{ backend.type_name}}
+@@ -80,7 +80,7 @@
+ {%- if volume.backend is defined %}
+ backends:
+ value: |
+- {%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++ {%- for backend_name, backend in volume.get('backend', {}).items() %}
+ * {{ backend_name }}:
+ * storage engine: {{ backend.engine }}
+ * volume type: {{ backend.type_name}}
+--- a/cinder/volume.sls
++++ b/cinder/volume.sls
+@@ -52,7 +52,7 @@
+
+ {%- if volume.backend is defined %}
+
+-{%- for backend_name, backend in volume.get('backend', {}).iteritems() %}
++{%- for backend_name, backend in volume.get('backend', {}).items() %}
+
+ {%- if backend.engine == 'iscsi' %}
+
diff -Nru salt-formula-cinder-2016.12.1/debian/patches/series salt-formula-cinder-2016.12.1/debian/patches/series
--- salt-formula-cinder-2016.12.1/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ salt-formula-cinder-2016.12.1/debian/patches/series 2018-02-15 00:24:07.000000000 +0100
@@ -0,0 +1 @@
+0001-Support-Python-3.patch
