On February 12, 2018 12:22:45 PM EST, Laurent Bigonville <bi...@debian.org> wrote: >On Wed, 12 Jul 2017 20:22:00 -0700 Josh Triplett ><j...@joshtriplett.org> >wrote: > > On Wed, Jul 12, 2017 at 07:57:28PM +0200, Andreas Henriksson wrote: > > > On Tue, Jul 11, 2017 at 08:23:07AM -0700, Josh Triplett wrote: > > > [...] > > > > Ideally, I would suggest that we start enabling the "discard" >option by >> > > default in d-i. That would also avoid spinning up a periodic cron >job > > > > that runs regardless of actual need or disk activity. > > > > > > This doesn't help systems that are being upgraded though, so IMHO > > > would be even more ideal if kernel just used it as default where > > > suitable. > > > > Agreed. I'd like to see the kernel use the more reasonable default. > > >> > > (One of the things I really wish we could do more easily is >eliminate >> > > the numerous cron jobs that simply wake up, realize they have no >work to > > > > do, and go back to sleep.) > > > >> > I see this problem but that's not my major concern. My personal >biggest >> > worry is about mixing mechanism (the util-linux tools) and policy >(cron >> > jobs, etc). I'd much rather see the two being separate and have >higher >> > level stuff put the policy in place rather than shipping the policy >in > > > an essential package. > > >> Agreed *completely*, and thank you for very clearly articulating this > > concern. > > > > > This is exactly the same reason why I'm not > > > entirely at ease with the suggestion in #855203 either. > > >> Agreed. Making that change would just move breakage around, fixing >some >> systems but breaking others. (There's a *reason* that job isn't run.) > > >> > Unfortunately I haven't been able to come up with a good package to > > > point the finger to where we should put this policy..... > > > Suggestions would be very welcome! > > >> I think the right answer is always "fix the underlying package to >have >> the right default, rather than papering over it with configuration". >If >> we have some non-standard configuration we're shipping by default, we >> should figure out how to make some kind of automatic detection that >Just > > Works the new default and eliminate the configuration. > > > > > >Marco has opened #889668 to just install the .service and the .timer >file at the correct location but not enabling them by default.
I can live with that. >I guess that it would be a good compromise for now, I also think that >putting these file in an example directory is a bit meh. > >But I'm seeing something weird, all my disks on my laptops have the >"discard" option set but for some reasons when running "fstrim -v -a" >it >still says that had trim data on all the FS. > >Do I miss something? Do you have an encrypted root filesystem? Or LVM? You need to take additional steps to enable discard if so. >Kind regards, > >Laurent Bigonville
