On Fri, Feb 9, 2018 at 2:09 AM, Pete Heist <p...@eventide.io> wrote: > > On Feb 7, 2018, at 10:03 AM, Michael Stapelberg <stapelb...@debian.org> > wrote: > > Thanks for contributing this package. > > The resulting binary package irtt_0.9-1_amd64.deb contains both a binary > and Go source code. This is a bit unusual: in Debian, we only package Go > source code to build other Go programs (not for developers). Hence, we > usually provide either a binary package with programs or an arch:all > package with Go source. It’s fine to have a source package which provides > both, but please separate the source from the binaries. Have a look at > https://anonscm.debian.org/cgit/collab-maint/codesearch.git/ for an > example of this pattern. > > Further, please address the following lintian warnings: > > P: irtt source: package-uses-old-debhelper-compat-version 10 > P: irtt source: insecure-copyright-format-uri http://www.debian.org/doc/ > packaging-manuals/copyright-format/1.0/ > I: irtt source: out-of-date-standards-version 3.9.8 (released 2016-04-06) > (current is 4.1.3) > I: irtt source: testsuite-autopkgtest-missing > W: irtt: priority-extra-is-replaced-by-priority-optional > > > I’m on Debian sid and closer now, with a binary only package (using > dh_auto_install -- --no-source). There’s still some lintian confusion. When > I run it, I get: > > $ cat /etc/debian_version > buster/sid > $ lintian --version > Lintian v2.5.74 > $ lintian irtt_0.9+git20180209.9cda776-1_amd64.changes > P: irtt source: debian-watch-does-not-check-gpg-signature > P: irtt: no-upstream-changelog > > From the original warnings you sent I know I’ve fixed all except "I: irtt > source: testsuite-autopkgtest-missing”, but a) I’m not seeing that > warning and b) I’m seeing two others. So my questions are: > > 1) What are your expectations for 'testsuite-autopkgtest-missing', and > why am I not seeing it? There are no unit tests to run. >
Did you apply the ~/.lintianrc I provided? Not doing so would explain the difference. autopkgtest is helpful even if it only compiles the package in question. Why are there no unit tests for your code? :) > > 2) Do you care about 'debian-watch-does-not-check-gpg-signature' and > 'no-upstream-changelog’? I do not sign the upstream, and the changes are in > README.md, in case those should be split out... > They’re not important for the time being. Of course, if you could start signing upstream and provide a separate changelog file, that would be great. Thanks! > > Thanks! > Pete > > > _______________________________________________ > Pkg-go-maintainers mailing list > pkg-go-maintain...@lists.alioth.debian.org > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-go-maintainers > -- Best regards, Michael
