Hi Joachim On 2018-01-24 18:12:30, Joachim Bauch wrote: > Package: sponsorship-requests > Severity: wishlist > > (CC'ing pkg-multimedia-maintainers as the package is a image codec and > Alessio and Sebastian who sponsored another package from me) > > Dear mentors, > > I am looking for a sponsor for my package "libheif" > > We are planning to release version 1.0.0 sometime next week, so I am > looking for some early feedback from a packaging perspective to see if > we need to change something in the upstream code to make packaging > better / easier. The final RFS will be updated for the 1.0.0 release. > > * Package name : libheif > Version : 0.0.1+20180124133753+git68fb4fe-1 > Upstream Author : struktur AG <opensou...@struktur.de> > * URL : https://github.com/strukturag/libheif > * License : LGPL (library), GPL (example applications) > Section : libs > > It builds those binary packages: > > libheif-0 - ISO/IEC 23008-12:2017 HEIF file format decoder. > libheif-dev - ISO/IEC 23008-12:2017 HEIF file format decoder - > development file > libheif-examples - ISO/IEC 23008-12:2017 HEIF file format decoder - examples > > To access further information about this package, please visit the > following URL: https://mentors.debian.net/package/libheif > > Alternatively, one can download the package with dget using this > command: > > dget -x > https://mentors.debian.net/debian/pool/main/libh/libheif/libheif_0.0.1+20180124133753+git68fb4fe-1.dsc
That fails to build: | g++ -DHAVE_CONFIG_H -I. -I.. -Wdate-time -D_FORTIFY_SOURCE=2 -I../src -g -O2 -fdebug-prefix-map=/<<BUILDDIR>>/libheif-0.0.1+20180124133753+git68fb4fe=. -fstack-protector-strong -Wformat -Werror=format-security -Wall -Werror -Wsign-compare -Wconversion -Wno-sign-conversion -Wno-error=conversion -c -o heif_info-heif_info.o `test -f 'heif_info.cc' || echo './'`heif_info.cc | encoder_png.cc: In member function 'virtual bool PngEncoder::Encode(const heif_image_handle*, const heif_image*, const string&)': | encoder_png.cc:56:62: error: 'strerror' was not declared in this scope | fprintf(stderr, "Can't open %s: %s\n", filename.c_str(), strerror(errno)); | ^~~~~~~~ | encoder_png.cc:56:62: note: suggested alternative: 'perror' | fprintf(stderr, "Can't open %s: %s\n", filename.c_str(), strerror(errno)); | ^~~~~~~~ | perror | Makefile:553: recipe for target 'heif_convert-encoder_png.o' failed Some other issues: * The library package should be named based on the SONAME, so that would be libheif1. * Current Standards-Version is 4.1.3. * If you bump debhelper compatibility to 10 or 11, you can drop the explicit --with autreconf and --parallel in d/rules. You could also drop dh-autoreconf from Build-Depends. Cheers -- Sebastian Ramacher
signature.asc
Description: PGP signature
