Package: openbox
Version: 3.5.2-8+deb8u1

toggled hover and pressed images masks in openbox themes are not loaded which broke many existing themes e.g.

https://www.box-look.org/p/1017288/

in the same page there exists a link with the upstream patch that fixes the problem:

http://git.openbox.org/?p=mikachu/openbox.git;a=commitdiff;h=f1f5610cca8511be3bd03198f49a6a4e9fc15314

it would be very nice if the patch is applied to the Jessie package. Although this patch was included in versions >= 3.6.0 the bug was re-introduced and Stretch and Sid packages are also affected.

A simple workaround is attached in the bug report to fix the problem in versions >= 3.6.0, there is a swap in the prefix filenames and variable names in the code which prevents the masks to be loaded.

Please also apply this fix in Stretch or contact upstream if needed,
Many thanks
Index: openbox-3.6.1/obrender/theme.c
===================================================================
--- openbox-3.6.1.orig/obrender/theme.c
+++ openbox-3.6.1/obrender/theme.c
@@ -1494,8 +1494,10 @@ static void read_button_styles(XrmDataba
     READ_BUTTON_MASK_COPY(disabled, btn->unpressed_mask);
     READ_BUTTON_MASK_COPY(hover, btn->unpressed_mask);
     if (toggled_mask) {
-        READ_BUTTON_MASK_COPY(pressed_toggled, btn->unpressed_toggled_mask);
-        READ_BUTTON_MASK_COPY(hover_toggled, btn->unpressed_toggled_mask);
+        g_snprintf(name, 128, "%s_toggled_pressed.xbm", btnname);
+        READ_MASK_COPY(name, btn->pressed_toggled_mask, btn->unpressed_toggled_mask);
+        g_snprintf(name, 128, "%s_toggled_hover.xbm", btnname);
+        READ_MASK_COPY(name, btn->hover_toggled_mask, btn->unpressed_toggled_mask);
     }
 
 #define READ_BUTTON_APPEARANCE(typedots, type, fallback) \

Reply via email to