Hi,

there are a few issues with your patch. Please submit patches as files next time. The first hunk is reverse applied and I suggest not to change the description for verbose because it is already quite clear what it means. The second hunk changes a translation field which means if you use Byzanz in a different language, this field will no longer be translated.

The third hunk is ok but the message is not translated at the moment which doesn't look very good in a different language. I also believe a counter would be more useful like 4...3...2...1 because the user already knows that the delay is four seconds when passing -d 4. The information about "Recording started" and "Recording stopped" is also already displayed. The counter would be informative but in its current form the patch doesn't add much value, on the contrary it introduces a regression translation-wise.

Regards,

Markus

Reply via email to