Hi Niels,
I think I reversed the root:root logic for testing and didn't save in my
editor. I am.on mobile now: can you just eq/ne (or the other way around) for
me?
—lamby
> Chris Lamb:
> > tags 886479 + pending
> > thanks
> >
> > Thanks for the review Niels; glad I didn't push to master late
> > night :)
> >
> >
> > Best wishes,
> >
>
> So, I think we overlooked something in that patch. All of the tests are
> failing with:
>
> """
> > tests::nmu-space-around-maintainer: diff -u
> > t/tests/nmu-space-around-maintainer/tags
> > /tmp/testrun/debian/test-out/tests/nmu-space-around-maintainer/tags.nmu-space-around-maintainer
> > --- t/tests/nmu-space-around-maintainer/tags 2018-01-07
> > 20:41:40.599428401 +0000
> > +++
> > /tmp/testrun/debian/test-out/tests/nmu-space-around-maintainer/tags.nmu-space-around-maintainer
> > 2018-01-07 20:52:10.246286088 +0000
> > @@ -1 +1,2 @@
> > +I: nmu-space-around-maintainer source: should-specify-rules-requires-root
> > nmu-space-around-maintainer usr/ (root:root)
> > W: nmu-space-around-maintainer source:
> > extra-whitespace-around-name-in-changelog-trailer
> > fail tests::nmu-space-around-maintainer: output differs!
> """
>
> But that strongly smells like a clear cut false-positive.
>
> Thanks,
> ~Niels
>
Regards,
--
,''`.
: :' : Chris Lamb
`. `'` la...@debian.org / chris-lamb.co.uk
`-
