control: reassign -1 git control: retitle -1 git-commit-tree should honor commit.commit-tree control: severity wishlist
Hi, On Tue, Jan 02, 2018 at 12:12:15AM +0100, Mattia Rizzolo wrote: > Package: git-buildpackage > Version: 0.9.5 > > Since some time (long time actually, but I never got around to report > it, probably even a whole year) `gbp import-orig` is not signing the > commits in the upstream and pristine-tar branches, despite me having > commit.pgpsign = true > in my ~/.gitconfig. The option is called commit.gpgsign not commit.pgpsign (according to "man git-config")… > I'm very sure it used to sign everything in the past, so I don't really > understand why it stopped, but even if it wasn't a regression I'd still > call it a bug that it's overriding my git config :) …and it doesn't affect git-commit-tree, that's why "gbp import-orig" is unaffected since it doesn't use "git commit" but git-commit-tree. So from gbp's point of view everything is working as expected as far as I can tell. We could add options to explicitly pass "-S" to commit tree but since git already has machinery for it it should be configurable there I think (and I can't see a reason why one would have "git commit" sign commits but not "git commit-tree". Cheers -- Guido
