Package: git-buildpackage Version: 0.9.5 Severity: normal Dear Maintainer,
thanks for maintaining gbp, I really enjoy it. Now that you have
extended DEP3 support, I just gave the patch queue another try, but
fear that I found a bug in it:
I tried to import the patches of privoxy 3.0.26-4 into the patch
queue. This fails with the following error:
$ gbp pq import
gbp:info: Trying to apply patches at 'c17f8e71000624bdcd2758a8fbe0b764b3b1c405'
Traceback (most recent call last):
File "/usr/bin/gbp", line 149, in <module>
sys.exit(supercommand())
File "/usr/bin/gbp", line 145, in supercommand
return module.main(args)
File "/usr/lib/python3/dist-packages/gbp/scripts/pq.py", line 488, in main
import_pq(repo, current, options)
File "/usr/lib/python3/dist-packages/gbp/scripts/pq.py", line 374, in
import_pq
options.upstream_tag)
File "/usr/lib/python3/dist-packages/gbp/scripts/pq.py", line 335, in
import_quilt_patches
apply_and_commit_patch(repo, patch, maintainer, patch.topic, name)
File "/usr/lib/python3/dist-packages/gbp/scripts/common/pq.py", line 311, in
apply_and_commit_patch
author = {'name': patch.author,
File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 156, in author
return self._get_info_field('author')
File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 303, in
_get_info_field
self._read_info()
File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 173, in
_read_info
self._check_dep3()
File "/usr/lib/python3/dist-packages/gbp/patch_series.py", line 240, in
_check_dep3
for line in file:
File "/usr/lib/python3.5/codecs.py", line 321, in decode
(result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 228:
invalid continuation byte
As far as I can see, this fails in 33_manpage_hyphen.patch (see
https://sources.debian.org/src/privoxy/3.0.26-4/debian/patches/33_manpage_hyphen.patch/
), since the body of this patch contains ISO-8859-1 chars.
Here the python UTF-8 parser fails. I'm not sure, whether the body
part of the patch (in contrast to the DEP3 header) should be expected
to be UTF-8, since this is part of the upstream package which may use
other charsets, so it should be considered binary, shouldn't it?
-- System Information:
Debian Release: 9.3
APT prefers stable
APT policy: (500, 'stable'), (50, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.9.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.utf-8, LC_CTYPE=de_DE.utf-8 (charmap=UTF-8),
LANGUAGE=de_DE:de:en_GB:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
Versions of packages git-buildpackage depends on:
ii devscripts 2.17.6+deb9u1
ii git 1:2.11.0-3+deb9u2
ii man-db 2.7.6.1-2
ii python3 3.5.3-1
ii python3-dateutil 2.5.3-2
ii python3-pkg-resources 33.1.1-1
Versions of packages git-buildpackage recommends:
ii cowbuilder 0.85
ii pbuilder 0.228.7
ii pristine-tar 1.38
ii python3-requests 2.12.4-1
ii sbuild 0.73.0-4
Versions of packages git-buildpackage suggests:
ii python3-notify2 0.3-3
ii sudo 1.8.19p1-2.1
ii unzip 6.0-21
-- no debconf information
Greetings
Roland
signature.asc
Description: PGP signature
