On Friday, December 29 2017, Gabriel F. T. Gomes wrote: > On 22 Dec 2017, Sergio Durigan Junior wrote: > >>As promised, here's my review. > > Thank you! ^^ > >>The first thing I did was to "gbp >>clone" your repository and build it locally. After that, I ran: >> >> lintian -EI --pedantic bash-completion_2.7-1_amd64.changes >> >>And noticed a few things worth fixing: >> >> I: bash-completion source: vcs-field-uses-insecure-uri vcs-git >> git://git.inconstante.eti.br/bash-completion-debian.git I: >> bash-completion source: vcs-field-uses-insecure-uri vcs-browser >> http://git.inconstante.eti.br/?p=bash-completion-debian.git >> >>Not sure if you're planning to change these URLs, but you should use >>secure (HTTPS) ones. But you're probably going to use the "official" >>repository, right? The one at >><https://anonscm.debian.org/cgit/bash-completion/bash-completion.git/>. > > Not really. If I understood it correctly, anonscm.debian.org is > alioth, which was being decomissioned when I started to work on this. > > I just noticed that alioth's replacement, salsa.debian.org, is up. So > maybe I should move this repository, now.
Yeah, that's right. I'm still using git.debian.org for my packages, but I should change that as well. >> W: bash-completion: package-installs-into-obsolete-dir >> etc/bash_completion.d/ : ^etc/bash_completion.d/ -> >> usr/share/bash-completion/completions Ensure new filename matches >> sticter requirements (see https://bugs.debian.org/776954 and >> https://bugs.debian.org/814599) >> >>It seems the package was abandoned before these warnings were added. >>You can see more details in the bugs, but the idea here is that >>completions should be installed under >>/usr/share/bash-completion/completions/, >>because /etc/bash_completion.d/ has been deprecated. >> >>It is questionable whether you should make at least one revision with >>/etc/bash_completion.d/, because according to README.Debian the >>directory was being kept for compatibility reasons. IMHO, this is a >>good opportunity to make needed changes to the package, and this is one >>of them. But maybe you/others have a different opinion. > > Currently, bash-completion only creates this directory because it is > listed in debian/dirs. Bash-completion itself doesn't install any files > in this directory. > > If I remove the listing from debian/dirs, the directory disappears from > the package. Other packages (e.g.: git, dkms) might still create this > directory and populate it with their completion files. > > Anyhow, I believe it is safe to remove the listing from debian/dirs at > this point (meaning I don't believe another revision that creates > /etc/bash_completion.d/ is necessary). > > So, I'll prepare a new version with this (which will solve the > lintian failure). Cool. As I said, I consider this to be a matter of preference; I personally wouldn't bother to see /etc/bash_completion.d/ still there in the next release. But thanks for doing that. >>It's also a good idea to bump the Standards-Version to 4.1.2 now. > > OK. 4.1.3 now :-). >>Other than that, I really like what you did, and I think the package is >>basically ready to be uploaded. > > I'll work on the changes you suggested. Thanks! Great! -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/
