The patch looks like it does three things:

1. Adds a dependency to zfs-zed
2. Corrects the path of zfs-zed in zfs-function
3. Installs zfs-import, zfs-mount, and zfs-zed as sysv startup scripts

1 should be submitted upstream to zfsonlinux, since this should be shared by
everyone. Once accepted upstream, I think Aron Xu will be more likely to accept
that change (esp. if it is in the stable branch). Also, shouldn't the 
preexisting
Required-{Start,Stop} be removed (this patch just adds other Required-* lines)?

2 should be factored out into a quilt patch (the same problem is addressed
in the systemd zfs-zed.service unit in 1004-zed-service-bindir.patch). Maybe it
should even be included in that quilt patch?

3: We should be 100% sure that that the /dev/null symlink to zfs-import doesn't
interfere strangely with the newly added zfs-import.target (already included in 
the
upstream stable branch). I don't think it will, but someone should double check.

Antonio

Reply via email to