On Thu, 2017-11-30 at 16:31 +0100, Christian Ehrhardt wrote: > Pushed it to the same debian-submission-nov2017 branch as before.
Thanks, I don't really have good news though. I took a look and first, it seems that the git commit entries aren't really good. git log --format=oneline is barely readable, for example. For the commit contents: 1aa409a5 (mass plugin enable): NACK again; I won't enable that many stuff (and especially not in one go) d83c243b (duplicheck disable): one good reason for the NACK just above: it's not enabled in Debian, you just enabled it in 1aa409a5 :) 766d4f0d (ha disable): not really sure; it's way easier to have a custom kernel than a custom strongSwan 85150f06 (kernel-libipsec enable): for reference, this is #739641 and I'm still not sure I like it. I might pick it but end up disabling it before release a587dc11 (TNC move): I might pick this one because TNC is pretty standalone per-se and it might make sense to split it, but really that's a lot of new binary packages. 7629c11a7 (test-vectors move): NACK, what's the justification? Also it'll need some breaks/replaces f9e7f9007 (CCN move): NACK, what's the justification? Also, the break/replace have the ubuntu version in them, which is wrong for Debian. 13300d3bf (libstrongswan.install reorder): ACK, I could pick it if there was an isolated changelog entry with it 4fe0861e2 (kernel-netlink conffiles): NACK, these files are installed only on Linux and thus the handling is done in debian/rules 76535cba5 (libfast disable): Should be ok, if I have an isolated changelog entry for this 8dbf648b7 (libcharon-standard-plugin): I can understand the rationale (plugins for common password-based mobile VPN setup), but I don't really like it. I don't really like adding a new binary package, and the name is definitely not good. Also, as far as I understand it, the plugins are useful when you're actually configuring a client/roadwarrior to imitate a mobile client with its limitations. I don't think it's a good thing to do, I'd prefer simplifying the secure uses cases, like pubkeys-based ones. 9b5769771 (changelog update): NACK for obvious reason, I'd need isolated changes to the changelog (although obviously it's not simple to cherry-pick them either, I think I prefer it that way). Regards, and again thanks for the work you do. Regards, -- Yves-Alexis
signature.asc
Description: This is a digitally signed message part
