Hi
On Wed, Nov 22, 2017 at 12:07:33AM +0100, Leo wrote:
> The program call in line 590 contains too many "which lead to a script error
> if the variable RSYNC contains a space. For example, RSYNC =
> "/usr/bin/socksify /usr/bin/rsync"
Strictly speaking, filenames can contain spaces. But I see the point
and may change that back.
> Compatibility problem:
> Not every Linux OS supports the -E parameter with sed. It is better to use
> the GNU compatible option -r, which gives the same result.
The -E option is common to all current operation systems as it is
specified by POSIX. As this script not only runs on Linux, using GNU
specific options is not the way to go. I also found no supported Linux
distribution without support for it.
> Improvement:
> Running the program through a (Socks) proxy whose timeout is less than 3600
> seconds may cause Stage2 to crash. The timeout should be customizable with
> its own variable in the configuration.
I would be more concerned about a stage2 that runs for over an hour.
Regards,
Bastian
--
I'm frequently appalled by the low regard you Earthmen have for life.
-- Spock, "The Galileo Seven", stardate 2822.3
