On Tue, Nov 21, 2017 at 10:53:16AM -0700, Eduardo Chappa wrote: > [ I added Helmut Grohne to this communication]
Please do not forget to Cc the bug to capture this conversation. > I tested the "95" patch. It does not fully work for me. After application I > cannot build alpine. However, some hunks do allow me to build successfully > Alpine. Please elaborate. An error message or such would allow me to fix up the patches. > The question is what to do. What I decided to do is to add the hunks that > work and exclude the hunks that do not. I have attributed that contribution > to Helmut Grohne <hel...@subdivi.de>. All I need to know is that he agrees > to this patch being distributed under the Apache License 2.0. I assume he > does, because he submitted it to you, and you are just passing it upstream > and that is all that is needed, but I would like confirmation. I do confirm the licensing question. In http://repo.or.cz/alpine.git/commitdiff/26a47a9a2c571ad9bb7076a41bc66f9dada65069, I see that you picked the AC_RUN_IFELSE removal patches and left out the CC_FOR_BUILD stuff. The macro AX_PROG_CC_FOR_BUILD comes from autoconf-archive[1], which is a collection of common macros. Did you install it? If you dislike using this, you can mostly make it work with a hack. We need variables CC_FOR_BUILD and EXEEXT_FOR_BUILD. If you use EXEEXT in place of EXEEXT_FOR_BUILD, you'll break cross builds from and to windows (but I don't care about that) and then you can derive CC_FOR_BUILD as follows: AC_PATH_PROG([CC_FOR_BUILD],[cc]) For the _FOR_BUILD stuff you must not use AC_PATH_TOOL which would usually be correct for compilers. Hope this helps. Helmut [1] https://www.gnu.org/software/autoconf-archive/
