Sorry, unfortunately my patch is very bad. Just reviewed the latest
virtualbox amd64-testbuild and
the SKB_GSO_UDP function is removed.
@@ -737,9 +746,6 @@
case PDMNETWORKGSOTYPE_IPV4_TCP:
fGsoType = SKB_GSO_TCPV4;
break;
- case PDMNETWORKGSOTYPE_IPV4_UDP:
- fGsoType = SKB_GSO_UDP;
- break;
case PDMNETWORKGSOTYPE_IPV6_TCP:
fGsoType = SKB_GSO_TCPV6;
break;
@@ -1273,7 +1279,7 @@
* Check the GSO properties of the socket buffer and make sure it
fits.
*/
/** @todo Figure out how to handle SKB_GSO_TCP_ECN! */
- if (RT_UNLIKELY( skb_shinfo(pSkb)->gso_type & ~(SKB_GSO_UDP |
SKB_GSO_DODGY | SKB_GSO_TCPV6 | SKB_GSO_TCPV4) ))
+ if (RT_UNLIKELY( skb_shinfo(pSkb)->gso_type & ~(SKB_GSO_DODGY |
SKB_GSO_TCPV6 | SKB_GSO_TCPV4) ))
{
Log5(("vboxNetFltLinuxCanForwardAsGso: gso_type=%#x\n",
skb_shinfo(pSkb)->gso_type));
return false;
@@ -1523,7 +1529,7 @@
}
#endif /* !VBOXNETFLT_SG_SUPPORT */
# ifdef VBOXNETFLT_WITH_GSO_RECV
- if ( (skb_shinfo(pBuf)->gso_type & (SKB_GSO_UDP |
SKB_GSO_TCPV6 | SKB_GSO_TCPV4))
+ if ( (skb_shinfo(pBuf)->gso_type & (SKB_GSO_TCPV6 |
SKB_GSO_TCPV4))
&& vboxNetFltLinuxCanForwardAsGso(pThis, pBuf, fSrc,
&GsoCtx) )
vboxNetFltLinuxForwardAsGso(pThis, pBuf, fSrc, &GsoCtx);
else
On Sat, 11 Nov 2017 21:36:44 +0700 Dio Putra <diooktpu...@gmail.com> wrote:
> Tags: patch
>
> I can reproducible this issue and same error log on my Debian Sid via
> Bare Metal VM, quite frankly
> I even don't know everything about C or C++. However because your
> make.log is readable for me, so
> here the patch I created.
>
> But, I don't believe this patch's quite realiable. So try yourself with
> risk.
>
> Cheers.
>
@@ -737,9 +746,6 @@
case PDMNETWORKGSOTYPE_IPV4_TCP:
fGsoType = SKB_GSO_TCPV4;
break;
- case PDMNETWORKGSOTYPE_IPV4_UDP:
- fGsoType = SKB_GSO_UDP;
- break;
case PDMNETWORKGSOTYPE_IPV6_TCP:
fGsoType = SKB_GSO_TCPV6;
break;
@@ -1273,7 +1279,7 @@
* Check the GSO properties of the socket buffer and make sure it fits.
*/
/** @todo Figure out how to handle SKB_GSO_TCP_ECN! */
- if (RT_UNLIKELY( skb_shinfo(pSkb)->gso_type & ~(SKB_GSO_UDP | SKB_GSO_DODGY | SKB_GSO_TCPV6 | SKB_GSO_TCPV4) ))
+ if (RT_UNLIKELY( skb_shinfo(pSkb)->gso_type & ~(SKB_GSO_DODGY | SKB_GSO_TCPV6 | SKB_GSO_TCPV4) ))
{
Log5(("vboxNetFltLinuxCanForwardAsGso: gso_type=%#x\n", skb_shinfo(pSkb)->gso_type));
return false;
@@ -1523,7 +1529,7 @@
}
#endif /* !VBOXNETFLT_SG_SUPPORT */
# ifdef VBOXNETFLT_WITH_GSO_RECV
- if ( (skb_shinfo(pBuf)->gso_type & (SKB_GSO_UDP | SKB_GSO_TCPV6 | SKB_GSO_TCPV4))
+ if ( (skb_shinfo(pBuf)->gso_type & (SKB_GSO_TCPV6 | SKB_GSO_TCPV4))
&& vboxNetFltLinuxCanForwardAsGso(pThis, pBuf, fSrc, &GsoCtx) )
vboxNetFltLinuxForwardAsGso(pThis, pBuf, fSrc, &GsoCtx);
else
