Package: dh-autoreconf
Version: 14
Severity: wishlist
Tags: patch
Hi,
The dh_autoreconf_clean helper is only necessary when dh_autoreconf
has been run AND created the "autoreconf.{before,after}" files. In
the initial "clean" prior to a build plus in packages without
autotools, these files will never exist. Accordingly, we can save the
call to dh_autoreconf_clean in all of these cases by simply adding a
"NOOP" promise (as done in the 0001 patch).
I have also attached a second (unrelated) patch to declare that
dh-autoreconf can be built without (fake)root (by setting R³=no). I
have made it a habit to attempt this whenever I work on packages to
avoid installing fakeroot. Feel free ignore this patch; it has no
practical consequences for this bug and is just a little "bonus".
Thanks,
~Niels
>From 4f5505c0eaeb85c28dffc037fcb8d35dfdbb9cf5 Mon Sep 17 00:00:00 2001
From: Niels Thykier <ni...@thykier.net>
Date: Sat, 11 Nov 2017 09:00:05 +0000
Subject: [PATCH 1/2] dh_autoreconf_clean: Add a NOOP promise
Signed-off-by: Niels Thykier <ni...@thykier.net>
---
dh_autoreconf_clean | 2 ++
1 file changed, 2 insertions(+)
diff --git a/dh_autoreconf_clean b/dh_autoreconf_clean
index 01b489c..62af818 100755
--- a/dh_autoreconf_clean
+++ b/dh_autoreconf_clean
@@ -23,6 +23,8 @@ any ltmain.sh patch applied by dh_autoreconf.
init();
+# PROMISE: DH NOOP WITHOUT autoreconf.before autoreconf.after
+
# autoreconf failed, just remove the 'before' file.
if (-r 'debian/autoreconf.before' && ! -r 'debian/autoreconf.after') {
doit("rm", "debian/autoreconf.before");
--
2.15.0
>From be5294c85a803c77e2cdc70782da7cec38d75dbb Mon Sep 17 00:00:00 2001
From: Niels Thykier <ni...@thykier.net>
Date: Sat, 11 Nov 2017 09:08:29 +0000
Subject: [PATCH 2/2] dh-autoreconf can build without (fake)root
Signed-off-by: Niels Thykier <ni...@thykier.net>
---
debian/control | 1 +
1 file changed, 1 insertion(+)
diff --git a/debian/control b/debian/control
index 0404295..d79651f 100644
--- a/debian/control
+++ b/debian/control
@@ -4,6 +4,7 @@ Priority: optional
Maintainer: Julian Andres Klode <j...@debian.org>
Build-Depends: debhelper (>= 9)
Standards-Version: 3.9.8
+Rules-Requires-Root: no
Vcs-Git: https://anonscm.debian.org/git/collab-maint/dh-autoreconf.git
Vcs-Browser: https://anonscm.debian.org/git/collab-maint/dh-autoreconf.git
--
2.15.0
