Hi, On Mon, Nov 06, 2017 at 02:21:16PM +0000, Nico Schlömer wrote: > I've tried with 0.9.1 and I'm getting the same error. The error message > makes sense too: In `_run_parsechangelog` one finds
Then please provide steps to reproduce. > ``` > self._contents.encode() > ``` > which fails in Python 2 if `self._contents` contains a non-ascii character. > (Reproducable with `'ö'.encode()`.) But this is not Python2. I know about encoding/decoding of strings in Python but I don't know why it fails on your system. I have parsed all changelogs in the archive in the passt and believe me your name isn't the only one with an umlaut. What locale are you running under? What's the exact git tree to reproduce this? Cheers, -- Guido > Position 399 in the error message > ``` > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 399: > ordinal not in range(128) > ``` > also refers to an "ö". > > I would hence vote for reopening this bug. > > On Mon, Nov 6, 2017 at 2:30 PM Debian Bug Tracking System < > ow...@bugs.debian.org> wrote: > > > This is an automatic notification regarding your Bug report > > which was filed against the git-buildpackage package: > > > > #880964: git-buildpackage: non-ascii character in d/changelog: > > UnicodeDecodeError > > > > It has been closed by Guido Günther <a...@sigxcpu.org>. > > > > Their explanation is attached below along with your original report. > > If this explanation is unsatisfactory and you have not received a > > better one in a separate message then please contact Guido Günther < > > a...@sigxcpu.org> by > > replying to this email. > > > > > > -- > > 880964: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=880964 > > Debian Bug Tracking System > > Contact ow...@bugs.debian.org with problems > > > > > > > > ---------- Forwarded message ---------- > > From: "Guido Günther" <a...@sigxcpu.org> > > To: 880964-d...@bugs.debian.org > > Cc: > > Bcc: > > Date: Mon, 6 Nov 2017 14:27:19 +0100 > > Subject: Re: Bug#880964: git-buildpackage: non-ascii character in > > d/changelog: UnicodeDecodeError > > Version: git-buildpackge/0.9.1 > > > > Hi, > > On Mon, Nov 06, 2017 at 02:17:29PM +0100, Nico Schlömer wrote: > > > Package: git-buildpackage > > > Version: 0.8.18 > > > Severity: important > > > > > > When running > > > ``` > > > gbp import-orig --uscan --pristine-tar > > > ``` > > > on the gmsh package, gbp bails out with the error message > > > ``` > > > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 399: > > > ordinal not in range(128) > > > ``` > > > referring to > > > ``` > > > File "/usr/local/lib/python2.7/dist-packages/gbp/deb/changelog.py", > > line 100, > > > in _run_parsechangelog > > > (stdout, stderr) = cmd.communicate(self._contents.encode()) > > > > > > ``` > > > This is because of the non-ascii character "ö". > > > > This is wired and likely not the source of the problem (not that my name > > contiains a 'ü' as well). However I can't reproduce this with 0.9.x on > > gmsh from sid. > > Cheers, > > -- Guido > > > > > > ---------- Forwarded message ---------- > > From: "Nico Schlömer" <nico.schloe...@gmail.com> > > To: Debian Bug Tracking System <sub...@bugs.debian.org> > > Cc: > > Bcc: > > Date: Mon, 06 Nov 2017 14:17:29 +0100 > > Subject: git-buildpackage: non-ascii character in d/changelog: > > UnicodeDecodeError > > Package: git-buildpackage > > Version: 0.8.18 > > Severity: important > > > > When running > > ``` > > gbp import-orig --uscan --pristine-tar > > ``` > > on the gmsh package, gbp bails out with the error message > > ``` > > UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 399: > > ordinal not in range(128) > > ``` > > referring to > > ``` > > File "/usr/local/lib/python2.7/dist-packages/gbp/deb/changelog.py", line > > 100, > > in _run_parsechangelog > > (stdout, stderr) = cmd.communicate(self._contents.encode()) > > > > ``` > > This is because of the non-ascii character "ö". > > > > > > > > -- System Information: > > Debian Release: stretch/sid > > APT prefers artful-updates > > APT policy: (500, 'artful-updates'), (500, 'artful-security'), (500, > > 'artful') > > Architecture: amd64 (x86_64) > > Foreign Architectures: i386 > > > > Kernel: Linux 4.13.0-16-generic (SMP w/4 CPU cores) > > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), > > LANGUAGE=en_US.UTF-8 (charmap=UTF-8) > > Shell: /bin/sh linked to /bin/dash > > Init: systemd (via /run/systemd/system) > > > > Versions of packages git-buildpackage depends on: > > ii devscripts 2.17.9build1 > > ii git 1:2.14.1-1ubuntu4 > > ii man-db 2.7.6.1-2 > > ii python 2.7.14-2ubuntu1 > > ii python-dateutil 2.6.0-1 > > ii python-pkg-resources 36.2.7-2 > > ii python-six 1.10.0-4 > > > > Versions of packages git-buildpackage recommends: > > ii pbuilder 0.228.9 > > ii pristine-tar 1.41 > > ii python-requests 2.18.1-1 > > > > Versions of packages git-buildpackage suggests: > > pn python-notify <none> > > ii sudo 1.8.20p2-1ubuntu1 > > ii unzip 6.0-21ubuntu1 > > > > -- Configuration Files: > > /etc/git-buildpackage/gbp.conf changed [not included] > > > > -- no debconf information > >
