On Thu, Oct 19, 2017 at 05:31:34PM +0200, Andy Spiegl wrote:
> Thanks for the patch.  I added your suggestions in version 2.3.2 with
> the following commits:
> 
>  
> https://bitbucket.org/ciberandy/qiv/commits/6ef68656650d53c8b7ec045ea62f3a2318fc1971
>  
> https://bitbucket.org/ciberandy/qiv/commits/ad05c8ae7b256a535d54eb42c919714cfcf3b445

If you are fixing this upstream, an alternative to the second patch
would be taking CC from the environment. Unfortunately, you cannot just
say

    CC ?= gcc

as CC has a default and the assignment would be ineffective, but you can
say

    ifeq ($(origin CC),default)
    CC = gcc
    endif

and have a CC assignment in the environment take precedence. Or you just
use the value of CC being "cc" (i.e. remove the CC assignment). These
alternatives can benefit other Linux distributions.

Helmut

Reply via email to