Control: tags -1 pending On Wed, 2017-10-18 at 15:58 +0100, James Clarke wrote: > On Wed, Oct 18, 2017 at 10:50:06AM -0400, Aaron M. Ucko wrote: > > Source: generator-scripting-language > > Version: 4.1.5-1 > > Severity: important > > Tags: upstream > > Justification: fails to build from source > > > > The build of generator-scripting-language for sparc64 (admittedly > > not > > a release architecture) failed: > > > > sfl.h:443:9: error: #error "Cannot compile: must change > > definition of 'qbyte'." > > > > Could you please take a look? > > Hi, > I saw this pop up on #debian-devel-changes due to my sparc64 > highlight. > It's because upstream is stupid and doesn't know how to detect > bitness > without hard-coding every possible architecture in a big list in the > preprocessor. Something like [0] is needed for sparc64 > (defined(__sparc__) && defined(__arch64__)). Why do we still have to > deal with this kind of junk in 2017... > > Regards, > James > > [0] https://github.com/bluca/gsl/commit/f541a121e12f1a7f3d0fa49f6057c > d6b13be3aea
Hi, Yes I know, that whole snippet is quite annoying and I had to update it a few times already. :-( The patch is very simply but I wanted to try and test it before uploading -2, but unfortunately the only sparc 64 porter box does not seem to be reachable at the moment: https://db.debian.org/machines.cgi?host=notker I guess I'll take my chances and do an upload anyway later today. -- Kind regards, Luca Boccassi --- a/src/prelude.h +++ b/src/prelude.h @@ -91,7 +91,7 @@ #if (defined (__64BIT__) || defined (__x86_64__) || defined (__AARCH64EL__) \ || defined (__PPC64__) || defined (__powerpc64__) || defined (__ppc64__) \ - || defined (__s390x__)) + || defined (__s390x__) || (defined (__sparc__) && defined (__arch64__))) # define __IS_64BIT__ /* May have 64-bit OS/compiler */ #else # define __IS_32BIT__ /* Else assume 32-bit OS/compiler */ --- a/src/sfl.h +++ b/src/sfl.h @@ -130,7 +130,7 @@ #if (defined (__64BIT__) || defined (__x86_64__) || defined (__AARCH64EL__) \ || defined (__PPC64__) || defined (__powerpc64__) || defined (__ppc64__) \ - || defined (__s390x__)) + || defined (__s390x__) || (defined (__sparc__) && defined (__arch64__))) # define __IS_64BIT__ /* May have 64-bit OS/compiler */ #else # define __IS_32BIT__ /* Else assume 32-bit OS/compiler */
signature.asc
Description: This is a digitally signed message part
