On Tue, Sep 26, 2017 at 11:05 PM, Danek Duvall <duv...@comfychair.org> wrote:
>> I see this as a bug in the man page to clarify this. Namely the
>> default is FvwmConsole's resource is that of the terminal
>> x-terminal-emulator points uses. Also clarify that the example
>> resources were written for xterm with the -name FvwmConsole flag.
>
> I figured that would be the likely outcome. That'd be okay by me. But see
> below.
>
>> > For now, my workaround is to simply run FvwmConsole with the -name
>> > option explictly added to the commandline.
>>
>> I don't see this as a workaround, but how it should be handled in
>> Debian. If you want FvwmConsole's terminal to use a different resource
>> than your default terminal's resource for configuration, that is what
>> the -name feature is for. You can also use it in conjunction with the
>> -terminal option to ensure you are running a terminal that supports
>> it.
>
> I see it as a workaround because it requires explicit configuration where
> none should be necessary. It seems obvious to me that one would want to
> use a different configuration from one's normal terminal emulator, since
> that's not really what's needed here.
This is a lot of personal opinion. To me I would rather not have a
separate terminal to configure for FvwmConsole by default, but the
option to create a separate config if I wanted. But I can see your way
too, which is more in the essence of the current upstream code.
> However, it occurred to me that there might be another way to do this. I
> discovered the RESOURCE_NAME environment variable, which I'd never used
> before, but if I put
>
> setenv("RESOURCE_NAME", "FvwmConsole", 1);
>
> right before the execvp() call, it works perfectly, and should be
> completely ignored by non-X11-toolkit programs. Using the environment
> makes sense here, since the process tree involved here is extremely minimal
> -- only FvwmConsoleC in addition to the terminal emulator, and it doesn't
> care. In fact, I think this change (along with the one to remove -name)
> might be worth sending upstream.
This might overall be a better way to do it. This way FvwmConsole
won't pass the -name option, which is present in some (but not all)
terminals, to set the resource. To me this wouldn't remove -name
option from FvwmConsole, but only from FvwmConsole's call to the
terminal.
I am open for adapting the Debian patch to use this. I don't know
enough details here to help with the patch. If you would like to
submit a patch that does just this, I will forward it to upstream.
jaimos
