On Sat, Oct 07, 2017 at 04:40:24PM +0200, Christoph Berg wrote:

> >     return ($ctype, $collate) unless $?;

Actually, isn't this inverted logic ?

It should return(...) unless $? actually is NOT zero ?

        PSQL(1)                                                             
PostgreSQL 9.6.5 Documentation                                                  
          PSQL(1)

        ...

        EXIT STATUS

        psql returns 0 to the shell if it finished normally, 1 if a
        fatal error of its own occurs (e.g. out of memory, file not
        found), 2 if the connection to the server went bad and the
        session was not interactive, and 3 if an error occurred in a
        script and the variable ON_ERROR_STOP was set.

Karsten
-- 
GPG key ID E4071346 @ eu.pool.sks-keyservers.net
E167 67FD A291 2BEA 73BD  4537 78B9 A9F9 E407 1346

Reply via email to