Hello Helmut 2017-09-26 1:51 GMT-03:00 Helmut Grohne <hel...@subdivi.de>:
> Hi Samuel, > > On Tue, Sep 26, 2017 at 01:09:19AM -0300, Samuel Henrique wrote: > > Thanks for the bugreport and patch, but did you realized that there's a > > FTBFS on linux when this patch is applied? > > Thanks for considering. I didn't see that coming, but a closer at > configure.in explains that behaviour. > I think you've opened FTCBFS bugs on at least 3 packages i maintain (bwm-ng, aircrack-ng, and some netfilter package), and i'm thankful for that, i'll consider all of them. > I see two (maybe three) ways forward: > > a) Fix configure.in. It should be checking DISK_INPUT_FOUND and others > to avoid adding input methods twice. > > a2) In theory it should also stop special casing $cross_compiling. > AC_CHECK_FILE(/proc/diskstats) is perfectly fine during cross > compilation. The check will fail, but the cross builder will > supply the right cache variable to make it succeed. > > b) Acknowledge that configure.in is weird and only pass these flags > for cross compilation. Make them conditional to > "ifneq ($(DEB_BUILD_ARCH),$(DEB_HOST_ARCH))". > > Do you have a preference? > Yes, i would like a mix of a) and b), i think this should be fixed upstream[1], and at the same time we could use b) until there's a new release with a fixed configure. Are you willing to send a patch upstream to fix this? In the meantime i can apply option b) [i'd appreciate if you could update your patch to ack b), but if you don't, i can do it myself on my next free time]. Thanks a lot! [1]https://github.com/vgropp/bwm-ng -- Samuel Henrique <samueloph>
