Am 22.09.2017 um 14:18 schrieb Michael Biebl: > Package: debhelper > Version: 10.9 > Severity: normal > > dh_installinit supports the installation of upstart job files. > I think we should stop doing that, given that upstart is no longer a > supported init system in Debian. > > I'm a bit uncertain whether we should just rip out the code or keep it > and make it conditional on the use of the debhelper compat level. > > Since upstart jobs are conffiles, they need to be removed manually on > upgrades. I guess the best we can do is to document that maintainers > need to that that themselves (e.g. via a .maintscript file)?
I guess removing upstart support completely can only be done once https://lintian.debian.org/tags/package-installs-deprecated-upstart-configuration.html is close to zero. I see that we already cleaned up dh_installinit wrt to .service and .tmpfile units in compat level 11 and beyond so it seems like a good opportunity to do the same for .upstart jobs as an intermediate step until we can remove upstart support completely from debhelper. Attached is a patch doing this first step (deprecating .upstart in newer compat levels). WDYT? Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth?
diff --git a/debhelper.pod b/debhelper.pod
index b03a8bbd..5c0a7e4e 100644
--- a/debhelper.pod
+++ b/debhelper.pod
@@ -595,6 +595,11 @@ B<dh_systemd_start> instead.
=item -
+B<dh_installinit> no longer installs F<upstart> files. Please make sure to
+remove existing files on upgrades (e.g. by using the B<maintscript> mechanism).
+
+=item -
+
The B<-s> (B<--same-arch>) option is removed. Please use B<-a> (B<--arch>) instead.
=item -
diff --git a/dh_installinit b/dh_installinit
index 02282e0d..cbd691cf 100755
--- a/dh_installinit
+++ b/dh_installinit
@@ -50,7 +50,7 @@ build directory.
=item debian/I<package>.upstart
If this exists, it is installed into etc/init/I<package>.conf in the package
-build directory.
+build directory. Only used in compat levels 10 and below.
=item debian/I<package>.service
@@ -255,7 +255,7 @@ foreach my $package (@{$dh{DOPACKAGES}}) {
install_file($tmpfile, "$path/$script.conf");
}
- my $job=pkgfile($package,"upstart");
+ my $job=pkgfile($package,"upstart") if compat(10);
if ($job ne '' && ! $dh{ONLYSCRIPTS}) {
install_dir("$tmp/etc/init");
install_file($job, "$tmp/etc/init/$jobfile.conf");
signature.asc
Description: OpenPGP digital signature
