Control: tags -1 + confirmed On 21-Sep-2017, Marc Haber wrote: > when uploading a package to my mini-buildd, dput bombs out:
Thanks for this bug report.
> [54/3314]mh@salida:~/packages/cron-apt $ dput --unchecked --force
> mini-buildd-zg cron-apt_0.10.0~zgSID+1_source.changes
> Uploading to mini-buildd-zg (via ftp to mini-buildd.example.com:8067):
> Traceback (most recent call last):
> File "/usr/bin/dput", line 11, in <module>
> load_entry_point('dput==1.0.1', 'console_scripts', 'execute-dput')()
> File "/usr/share/dput/dput/dput.py", line 1129, in main
> progress=progress, port=port)
> File "/usr/share/dput/dput/methods/ftp.py", line 29, in upload
> ftp_connection.connect(fqdn, port)
> File "/usr/lib/python3.5/ftplib.py", line 146, in connect
> if port > 0:
> TypeError: unorderable types: str() > int()
>
> Line 29 in ftp.py needs chaning from "port" to "int(port)" to make
> things work again
This is more wide-reaching; it's not only one upload method.
The command-line argument processing is wrong. It needs to convert the
‘port’ argument when it is read from the command line.
I will (unless you want to?) write unit tests for the command-line
argument processing, to ensure this is covered for all methods.
--
\ “I lost a button-hole.” —Steven Wright |
`\ |
_o__) |
Ben Finney <bign...@debian.org>
signature.asc
Description: PGP signature
