Hi Julien,
On Sat, Sep 9, 2017 at 5:58 PM, Julien Cristau <jcris...@debian.org> wrote:
> Control: tag -1 moreinfo
>
> On Mon, Sep 4, 2017 at 15:26:54 +0300, Sergei Golovan wrote:
>
>> Appears that the tdbcodbc package currently in stretch hav a bug introduced
>> by
>> the Debian maintainer and me the uploader, which leads to immediate segfault
>> on its loading. So the package is unusable at the moment.
>>
>> We'd like to propose an update 1.0.4-2+deb9u1 with a fix. The difference
>> between 1.0.4-2 and 1.0.4-2+deb9u1 is attached.
>>
> The changes to debian/compat and debian/control are neither documented
> in the changelog nor appropriate in a stable update.
>
> Is there a bug number for that error? It looks like this may or may not
> be fixed in sid now, but definitely wasn't yesterday.
Oops, I've missed that these changes (in debian/compat and
debian/control) have slipped from the unstable package into
1.0.4-2+deb9u1, sorry. Fixed now, the new debdiff is attached. Thank
you for spotting this!
There's no a formal bugreport for that. Looks like nobody stumbled
upon it (it doesn't show if unixodbc-dev is present on the system, or
may be too few users actually use this package).
The bug is already fixed in unstable (in 1.0.5-1), upload was after
this particular bugreport was filed.
Cheers!
--
Sergei Golovan
diff -Nru tdbcodbc-1.0.4/debian/changelog tdbcodbc-1.0.4/debian/changelog
--- tdbcodbc-1.0.4/debian/changelog 2016-03-15 01:16:57.000000000 +0300
+++ tdbcodbc-1.0.4/debian/changelog 2017-09-03 23:53:21.000000000 +0300
@@ -1,3 +1,10 @@
+tdbcodbc (1.0.4-2+deb9u1) stretch; urgency=medium
+
+ * Fixed bug in odbc libraries search as it caused a non existing
+ symbol to be loaded
+
+ -- Massimo Manghi <mxman...@apache.org> Sun, 03 Sep 2017 22:53:21 +0200
+
tdbcodbc (1.0.4-2) unstable; urgency=medium
* Removing unneeded build depend constraint that prevents the
diff -Nru tdbcodbc-1.0.4/debian/patches/extend-stub-search
tdbcodbc-1.0.4/debian/patches/extend-stub-search
--- tdbcodbc-1.0.4/debian/patches/extend-stub-search 2016-03-15
01:16:57.000000000 +0300
+++ tdbcodbc-1.0.4/debian/patches/extend-stub-search 2017-09-03
23:52:18.000000000 +0300
@@ -63,7 +63,7 @@
}
/*
-@@ -163,27 +176,34 @@
+@@ -163,27 +176,30 @@
if (status == TCL_OK) {
int status2 = TCL_ERROR;
for (i = 0; status2 == TCL_ERROR && odbcOptLibNames[i] != NULL; ++i) {
@@ -102,12 +102,11 @@
+ } else {
+ Tcl_ResetResult(interp);
}
- SQLInstallerError =
- (BOOL (INSTAPI*)(WORD, DWORD*, LPSTR, WORD, WORD*))
- Tcl_FindSymbol(NULL, *handle2Ptr, "SQLInstallerError");
+- SQLInstallerError =
+- (BOOL (INSTAPI*)(WORD, DWORD*, LPSTR, WORD, WORD*))
+- Tcl_FindSymbol(NULL, *handle2Ptr, "SQLInstallerError");
- } else {
- Tcl_ResetResult(interp);
-+
+ Tcl_DecrRefCount(path);
}
- Tcl_DecrRefCount(path);
