Thanks for accepting most of these changes, and additionally improving
them.  :)

A comment below about a couple of the patches.

On Thu, Aug 24, 2017, at 09:09, Alexander Zangerl wrote:
> >It's just something we've also done since maybe trusty because
> >upstream fixed the issues those patches solve.
> 
> i disagree with that claim: the relevant lauchpad bugs are still
> open, and i don't see any fixes in the code.

01-reverify is associated with Debian bug 659009 and Launchpad bug
946988.  The LP bug has been fixed for a long time.

02-unicode is associated with Debian bug 682837 and Launchpad bug
1030199 (dup of catch-all bug 1050509).

I recently added a comment to that bug explaining the current situation.
 This patch is a risk/reward calculation of how much you value duplicity
strings being in the user's language vs how much you think duplicity has
fixed its unicode issues.  I lean toward translated strings (and we've
been running that way in Ubuntu for years), but I understand if you
prefer to be more careful.

Thanks,
-mt

Reply via email to