Hi Hugh, I'm taking a look at these patches now, prompted by the fact that Ubuntu's incomplete multiarch transition for libfreetype6-dev has broken at least one reverse-dependency in contrib (astromenace).
On Thu, Aug 03, 2017 at 12:12:43PM +0000, Hugh McMaster wrote: > Package: libfreetype6-dev > Version: 2.8-0.2 > Severity: wishlist > Dear Maintainer, > The package libfreetype6-dev is still not multi-arch compatible. > In #666761, you stated that you will not accept patches that remove > freetype- config, as the interface is used by reverse dependencies. > This is no longer the case. I have examined all 41 reverse dependencies and > none of them use freetype-config anymore. It sounds like you've only looked at runtime dependencies. The primary concern is with packages that *build*-depend on libfreetype6-dev; there are far more than 41 of those, I count 243 in main alone. Are you willing to do a rebuild test of these reverse-dependencies against libfreetype6-dev with freetype-config removed, to verify that none of them regress? > Please remove this interface from the package, so that we can move forward > with marking libfreetype6-dev as Multi-Arch: same. > Also, freetype2/freetype/config/ftconfig.h conflicts between arches and > will need a resolution. Matthias Klose suggested one possible patch in > #666761. That particular patch is the one in Ubuntu which regresses the astromenace build. I think I prefer your solution: On Mon, Aug 28, 2017 at 02:49:22AM +0000, Hugh McMaster wrote: > --- debian/rules 2017-08-27 17:59:43.522265000 +1000 > +++ debian/rules 2017-08-27 19:46:36.000000000 +1000 > @@ -83,6 +83,7 @@ > dh_auto_build -D $(ft2demos_u) -- TOP_DIR=../$(freetype_u) \ > OBJ_DIR=../$(freetype_u)/objs > endif > + sed -i 's/\(\#define SIZEOF_LONG\).*/\1 __SIZEOF_LONG__/' > $(freetype_u)/builds/unix/ftconfig.h > > override_dh_auto_clean: > rm -f unpack-stamp patch-stamp I would prefer to see this as a patch to the source, not as post-processing from debian/rules. However, that means a bit of fiddling in builds/unix/configure.ac, so I'm ok to proceed with this approach for now. > --- debian/libfreetype6-dev.install 2017-08-27 19:46:36.000000000 +1000 > +++ debian/libfreetype6-dev.install 2017-08-27 19:51:15.455532188 +1000 > @@ -1,8 +1,6 @@ > -usr/bin/freetype-config > usr/include/ > usr/lib/*/*.so > usr/lib/*/*.la > usr/lib/*/*.a > usr/lib/*/pkgconfig/ > usr/share/aclocal/ > -/usr/share/man/man1/freetype-config.1 This still needs checking to be sure it doesn't regress reverse-build-dependencies. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer http://www.debian.org/ slanga...@ubuntu.com vor...@debian.org
signature.asc
Description: PGP signature