Dear Frédéric, On Tue, 11 Jul 2017 11:25:11 +0200 =?UTF-8?B?RnLDqWTDqXJpYw==?= Bonnard <fre...@linux.vnet.ibm.com> wrote: > Package: src:ffcall > Version: 1.10+cvs20100619-4 > Severity: normal > Tags: patch pending > > Dear maintainer, > > I've prepared diff for a NMU for ffcall (versioned as 1.13-0+nmu1) in the > attached patch but feel free to use the patch as you want. > The goal was initially to fix the FTBFS impacting mlpcap on ppc64el > https://buildd.debian.org/status/fetch.php?pkg=mlpcap&arch=ppc64el&ver=0.9-16&stamp=1485552538&raw=0 > > config.log would show : > configure:4214: gcc -o conftest -g -O2 > -fdebug-prefix-map=/build/mlpcap-gmmM7n/mlpcap-0.9=. -fstack-protector-strong > -Wformat -Werror=format-security -fPIC -Wdate-time -D_FORTIFY_SOURCE=2 > -Wl,-z,relro conftest. > c -lcallback -lpcap >&5 > /usr/lib/gcc/powerpc64le-linux-gnu/6/../../../powerpc64le-linux-gnu/libcallback.so: > undefined reference to `tramp_r' > > But this upload could fix other bugs as well. > > Looking at ffcal upstream, I see that there a much newer version of ffcall > namely > 1.13 which contains amongst other ppc64el improvements which fixed the build > of mlpcap (tested). > I tried to change the bare minimum of the packaging so that we have something > close > to 1.10+cvs20100619-4 but still building. Here are the changes I made : > debian/patches : I've updated fix-powerpcspe.patch, and > Fix_MIPS_N32_test.patch : please > review them. > I've disabled ppc64el-elfv2.patch as ppc64el support should >be good in 1.13. > I've also commented 0001-fix-callback-on-x86_64.patch as it >should be > fixed upstream : >https://www.bountysource.com/issues/20684153-segfault > debian/rules : autoreconf failed as is, so I added gnulib-m4 to aclocal > path and removed > skipping of libtoolize. > debian/libffcall1.symbols : some symbols seem local (__*) so no need to check > them I > think. There were some new additions. > debian/watch : I updated the repo URL which seemed to not work anymore at > all (server not found)
Thanks for your patch. I am currently working on updating ffcall, based on what you did (unless Christoph Egger is faster than me!). However, could you please give a detailed explanation of what your updated Fix_MIPS_N32_test.patch does? You modified several assembly files, and this needs explaining for non-mips-specialists. Best, -- ⢀⣴⠾⠻⢶⣦⠀ Sébastien Villemot ⣾⠁⢠⠒⠀⣿⡁ Debian Developer ⢿⡄⠘⠷⠚⠋⠀ http://sebastien.villemot.name ⠈⠳⣄⠀⠀⠀⠀ http://www.debian.org
signature.asc
Description: This is a digitally signed message part