Package: python-xarray
Version: 0.9.2-1
Severity: important
Tags: patch
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu artful ubuntu-patch autopkgtest
Hi Ghislain,
The autopkgtests for python-xarray have been failing in both Debian and
Ubuntu since the upload of 0.9.2-1. While the test failure is
(unfortunately) not considered a blocker for Debian testing, autopkgtest
regressions are blockers for Ubuntu releases.
The failures in Debian and Ubuntu are different from one another. In
Debian, the tests fail because the pydap backend appears to be broken:
=================================== FAILURES ===================================
________________________ PydapTest.test_cmp_local_file _________________________
self = <DatasetType with children 'bears', 'order', 'shot', 'aloan', 'cross',
'i', 'j', 'l'>
attr = 'iteritems'
def __getattr__(self, attr):
"""Lazy shortcut return children."""
try:
> return self[attr]
/usr/lib/python3/dist-packages/pydap/model.py:382:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <DatasetType with children 'bears', 'order', 'shot', 'aloan', 'cross',
'i', 'j', 'l'>
key = 'iteritems'
def __getitem__(self, key):
if isinstance(key, string_types):
> return self._getitem_string(key)
(https://ci.debian.net/packages/p/python-xarray/unstable/amd64/)
Whereas in Ubuntu, the tests fail because pydap as a whole is broken with
respect to autodetection of proxies through the http_proxy variable, so it
fails messily with a network timeout and is basically untestable on Ubuntu
infrastructure:
=================================== FAILURES ===================================
________________________ PydapTest.test_cmp_local_file _________________________
self = <xarray.tests.test_backends.PydapTest testMethod=test_cmp_local_file>
def test_cmp_local_file(self):
> with self.create_datasets() as (actual, expected):
/usr/lib/python3/dist-packages/xarray/tests/test_backends.py:1341:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib/python3.6/contextlib.py:81: in __enter__
return next(self.gen)
/usr/lib/python3/dist-packages/xarray/tests/test_backends.py:1331: in
create_datasets
actual = open_dataset(url, engine='pydap', **kwargs)
/usr/lib/python3/dist-packages/xarray/backends/api.py:296: in open_dataset
store = backends.PydapDataStore(filename_or_obj)
/usr/lib/python3/dist-packages/xarray/backends/pydap_.py:65: in __init__
self.ds = pydap.client.open_url(url)
/usr/lib/python3/dist-packages/pydap/client.py:67: in open_url
timeout).dataset
/usr/lib/python3/dist-packages/pydap/handlers/dap.py:54: in __init__
raise_for_status(r)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
response = <Response at 0x7fb355e301d0 504 Gateway Timeout>
Investigating this a bit more, I found that the pydap backend is not the
default in the upstream codebase; instead, the netcdf backend is preferred,
and this backend passes its tests fine.
So I think the best solution here is to not run tests for a backend we
shouldn't care about given that netcdf4 is available in Debian. I've
therefore dropped the test dependency on python3-pydap in Ubuntu, which
should allow python-xarray to be updated for the next release.
I think it would be a good idea for the Debian package to make this change
as well, and also to move python3-netcdf4 from Suggests to Recommends to
make it clear that this is the preferred backend (and possibly drop
python3-pydap from the suggests completely). It's not particularly useful
to have automated testing of the pydap backend if that backend is going to
be perpetually broken.
Cheers,
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slanga...@ubuntu.com vor...@debian.org
diff -Nru python-xarray-0.9.2/debian/tests/control
python-xarray-0.9.2/debian/tests/control
--- python-xarray-0.9.2/debian/tests/control 2017-04-15 13:28:16.000000000
-0700
+++ python-xarray-0.9.2/debian/tests/control 2017-08-26 16:40:53.000000000
-0700
@@ -12,7 +12,6 @@
python3-h5py,
python3-matplotlib,
python3-netcdf4,
- python3-pydap,
python3-pytest (>= 2.7.1),
python3-scipy,
python3-seaborn,
