On Mon, Jan 30, 2017 at 10:30:04PM +0100, Boud Roukema wrote:
> Package: blhc
> Version: 0.07+20161116+gitbf41976
> Severity: normal
>
> Dear Maintainer,
>
> SUMMARY: On https://qa.debian.org/bls/packages/m/mpgrafic.html,
> blhc, which is presumably the version of blhc presently in sid, i.e.
> blhc-0.07+20161116+gitbf41976, incorrectly labels builds of mpgrafic
> as "I no-compiler-commands", although mpgrafic does *both* fortran and C
> compilation using frontends to gcc.
>
> [snip]
>
> While the configure order of checking for gcc and mpicc might not, in
> general, give lines that are this close to one another, maybe the whole
> `configure' section of the build log could be searched to see if both
> the GNU C compiler and mpicc are configured. In that case, the usual
> checks for absence of hardening options can be made later in the perl
> script, where "mpicc" is the name of the compiler.

Hello,

Thank you for the detailed bug report and sorry for the late
reply, I totally missed this one. It was reported separately per
private mail and should be fixed (except for fortran, see below)
in bc6e92 [1].

I've followed your suggestion, just slightly modified:
mpicc/mpicxx are generally accepted as valid compilers (this is
simpler due to the internal matching of compiler lines which is
static).

I tested it with your example build logs and all report no errors
after the fix.

> COMMENT: I'm not sure if any hardening options are valid and
> recommended for gfortran - which is a fortran front end to gcc.

Following the output of dpkg-buildflags it doesn't support format
flags, but stack protector is supported. I've added support for
gfortran (that part never worked properly) and mpifort in cda2e04
[2].

Regards
Simon

[1]: 
https://ruderich.org/simon/gitweb/?p=blhc/blhc.git;a=commitdiff;h=bc6e920d8047a414012dd7f7dc152916d0670427
[2]: 
https://ruderich.org/simon/gitweb/?p=blhc/blhc.git;a=commitdiff;h=cda2e04237c0657e09d248b7f33c6ad0dc56612e
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9

Attachment: signature.asc
Description: PGP signature

Reply via email to