Hi Tomasz,
On Fri, Jul 07, 2017 at 10:07:14PM +0200, Tomasz Buchert wrote:
> retitle 867545 Fails with cryptic message when given paths do not exist
> thanks
> 
> On 07/07/17 09:57, Guido Günther wrote:
> > Package: pristine-tar
> > Version: 1.39
> > Severity: minor
> >
> > pristine-tar fails when the target it want's to reproduce is a symlink
> > that points nowhere. That by itself is o.k. but the error message is
> > confusing:
> >
> >     $ /usr/bin/pristine-tar checkout 
> > /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz
> >     Use of uninitialized value $tarball in -e at /usr/bin/pristine-tar line 
> > 454.
> >     Use of uninitialized value $_[0] in substitution (s///) at 
> > /usr/share/perl/5.24/File/Basename.pm line 180.
> >     fileparse(): need a valid pathname at /usr/bin/pristine-tar line 469.
> >     pristine-tar: failed to generate tarball
> >
> > Steps to reproduce:
> >
> >     ln -s /doesnotexist krb5-auth-dialog_3.20.0.orig.tar.xz
> >     gbp clone vcsgit:krb5-auth-dialog
> >     /usr/bin/pristine-tar checkout 
> > /var/scratch/src/krb5-auth-dialog/krb5-auth-dialog_3.20.0.orig.tar.xz
> >
> 
> Hey Guido,
> thanks for this info, but I think the issue has nothing to do with the
> symbolic link, but rather with the fact that the destination directory
> does not exist (also in steps above you have to 'cd' into the cloned
> repo).
> 
> I've committed a change [1] that will verify better what is given from
> the command line to all pristine-tar commands.

Thanks for fixing this so quickly!
 -- Guido

> 
> Thanks,
> Tomasz
> 
> [1] 
> https://anonscm.debian.org/cgit/collab-maint/pristine-tar.git/commit/?id=9265d0c0eea1620370a7261e0a6ee20eb86426fd

Reply via email to