Package: chiark-utils
Version: 5.0.2
Severity: normal
Tags: patch

$ sync-accounts
Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at 
./sync-accounts line 67.

Apparently this isn't allowed any more.  perl5220delta(1) says:

:    "defined(@array)" and "defined(%hash)" are now fatal errors
:        These have been deprecated since v5.6.1 and have raised deprecation
:        warnings since v5.16.

Obvious trivial patch to fix it:

diff --git a/sync-accounts/sync-accounts b/sync-accounts/sync-accounts
index cef131c..5348a14 100755
--- a/sync-accounts/sync-accounts
+++ b/sync-accounts/sync-accounts
@@ -64,7 +64,7 @@ sub fields_fmt ($$) {
     my ($pfx,$fmt) = @_;
     my ($vn);
     $vn= "fields_pw_$fmt";
-    die "unknown format $fmt\n" unless defined @$vn;
+    die "unknown format $fmt\n" unless @$vn;
     fields($pfx,@$vn);
     $vn= "${pfx}_format";
     $$vn= $fmt;

-- System Information:
Debian Release: 9.0
  APT prefers stable
  APT policy: (990, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.9.0-3-686-pae (SMP w/3 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Reply via email to