Package: libvirt
Version: 3.0.0-4
Severity: minor

Hi,
since quite a while (1.2.8-2) we (Debian and Ubuntu) are carrying
the patch debian/patches/debian/Debianize-virtlockd.patch [7b0894e] to make
it include the potential extra arguments from the Debian style path which
is "/etc/default/virtlockd".

In Ubuntu we had some changes on top in the past, but dropped them since
you fortunately adopted most or got the changes via upstream.
But now related to this I was made aware of orphaned conffiles.

Due to that I realized that Debian doesn't ship the
"/etc/default/virtlockd" that the service is referring to.

Attaching a patch on top of latest Debian packaging aligned to how you do
it for virtlogd that fixes the issue. Here is a buildlog [1] with it
applied, you can search for libvirt-admin.conf in it.

Note: Since the service works fine without the file, but being a bug not a
new feature request I decided for "minor" severity.

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
From fa5b1bcd485561fa543ae9a69170b5751541f32a Mon Sep 17 00:00:00 2001
From: Christian Ehrhardt <christian.ehrha...@canonical.com>
Date: Mon, 29 May 2017 16:21:35 +0200
Subject: [PATCH] Provide default file for virtlockd

Since the service is shipped also ship the related default
config file from upstream.

Signed-off-by: Christian Ehrhardt <christian.ehrha...@canonical.com>
---
 debian/rules | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/debian/rules b/debian/rules
index 36ba507..06ab667 100755
--- a/debian/rules
+++ b/debian/rules
@@ -168,6 +168,8 @@ override_dh_install-arch:
 	    debian/libvirt-daemon-system.libvirt-guests.default
 	cp src/logging/virtlogd.sysconf \
 	    debian/libvirt-daemon-system.virtlogd.default
+	cp src/locking/virtlockd.sysconf \
+	    debian/libvirt-daemon-system.virtlockd.default
 	# Add our backward compat polkit rule
 	cp debian/polkit/60-libvirt.pkla \
 	    debian/libvirt-daemon-system/var/lib/polkit-1/localauthority/10-vendor.d/
-- 
2.7.4

Reply via email to