Package: opendkim Version: 2.11.0~alpha-9 Severity: serious Justification: Policy 10.7.3
Hi, opendkim.postinst contains this: > # Upgrade /etc/default to systemd override files > if [ -d /run/systemd/system ] && [ -f /etc/default/opendkim ]; then > if /lib/opendkim/opendkim.service.generate; then > rm -f /etc/default/opendkim > fi This will forcefully remove /etc/default/opendkim on upgrade and erase any changes the user made without saving them anywhere, therefore violating policy 10.7.3. Instead of removing the file, it should be moved and then cleaned up on purge. ------ On a related note: I suspect the above code will break if the user ever decides to switch to a different init system while opendkim is installed. > if [ -f /etc/tmpfiles.d/opendkim.conf ]; then > systemd-tmpfiles --create > /etc/tmpfiles.d/opendkim.conf > fi I haven't tested anything, but I am wondering if this is subtly broken in the case where the generated $RUNDIR == /var/run/opendkim but $USER is different. dh_installinit inserts a call to systemd-tmpfiles for the file in /usr/lib/... which will override whatever is done here in that case. Thanks, James
signature.asc
Description: OpenPGP digital signature
