On Wed, Feb 08, 2006 at 07:07:54PM +0000, Christian Perrier wrote: > Author: bubulle > Date: 2006-02-08 19:07:53 +0000 (Wed, 08 Feb 2006) > New Revision: 1026
> Modified: > trunk/changelog > trunk/smb.conf > Log: > A few more default parameters Hmm, no discussion of this one before committing? > Modified: trunk/changelog > =================================================================== > --- trunk/changelog 2006-02-08 07:46:11 UTC (rev 1025) > +++ trunk/changelog 2006-02-08 19:07:53 UTC (rev 1026) > @@ -1,3 +1,12 @@ > +samba (3.0.21b-2) UNRELEASED; urgency=low > + > + * Default smb.conf changes: > + - activate "preserve case" and "short preserve case" in the > + default smb.conf file. Closes: #349047 These options are already the defaults. What's the point of uncommenting them? > + - add safe network browsing parameters . Closes: #349048 > +# Please read BROWSING.txt and set the next parameters accordind > +# to your network setup. There is no valid default, so they are commented > +; os level = 66 > +; local master = yes > +; preferred master = yes No, these are *not* safe options; they should almost *never* be tampered with, and almost anyone who touches them doesn't know what they're doing. Please do not include these as examples, they're just examples of how to break your network. > +# Is this machine able to authenticate users. Both PDC and BDC > +# must have this setting enabled. If you are the BDC you must > +# change the 'domain master' setting to no > +; domain logons = yes > +# Domain Master specifies Samba to be the Domain Master Browser. If this > +# machine will be configured as a BDC (a secondary logon server), you > +# must set this to 'no'; otherwise, the default behaviour is recommended. > + domain master = auto These are ok as examples, but again I don't see any reason to have an uncommented 'domain master' option that duplicates the compiled-in default. I also think we ought to be distinguishing between "this is a default value that you may want to uncomment and change to something else" and "this is a non-default value which you may want to uncomment under specific circumstances". That's a separate wishlist bug, though, as we haven't done this consistently for existing examples either. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. [EMAIL PROTECTED] http://www.debian.org/
signature.asc
Description: Digital signature
