On Wednesday, May 17, 2017 05:33:00 AM Niels Thykier wrote: > Control: tags -1 moreinfo > > Scott Kitterman: > > Package: release.debian.org > > Severity: normal > > User: release.debian....@packages.debian.org > > Usertags: unblock > > > > Please unblock package postfix > > > > This upload fixes two significant bugs and makes it possible for a user to > > recover from a third without hand editing configuration files: > > > > 1. Postfix-cdb will no longer fail to work after upgrade from jessie due > > to> > > upgrade ordering issues. > > > > 2. Postfix should wait to start until the network and DNS are actually > > > > available, so it won't fail to start on boot. > > > > 3. If an upgrade is performed from a not fully updated system and the > > > > dynamic maps locations are incorred in dynamicmaps.cf, > > dpkg-reconfigure > > postfix (and whatever postfix map types are installed) will fix it. > > > > Note: The last one will be followed by a bug to release-notes to mention > > this (it seems way better than a release note explaining how to hand edit > > files). > > > > unblock postfix/3.1.4-5 > > Hi, > > Thanks for working on fixing postfix. > > One remark / question about the following snippet: > > """ > - > +if dpkg --compare-versions $new lt 3.1.4-5~; then > + # This turned out to be the wrong way to solve the problem. > + rm -rf /etc/systemd/system/postfix.service.d > +fi > """ > > > Given the script only seemed to create > /etc/systemd/system/postfix.service.d/override.conf, shouldn't it only > remove that file (and possibly the directory iff it is empty)? Also, > what if the admin has changed the file locally?
I see your point. The directory would only exist (unless manually created) based on the old postinst, so I considered it ~safe to remove. As is, it's harmless, just not very pretty. Given the closeness of release, small risk of harm of leaving it, and the uncertainties around removing it due to the chance it's there for some other user created reason, perhaps it's best to leave it be for now. If I did another upload reverting that change, would you be good with unblocking? Scott K
