Source: taskcoach Version: 1.4.3-2 Severity: wishlist Tags: patch User: reproducible-bui...@lists.alioth.debian.org Usertags: fileordering X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org
Hi, Whilst working on the Reproducible Builds effort [0], we noticed that taskcoach could not be built reproducibly due to iteration over the filesystem in a non-determinstic order. Patch attached. [0] https://reproducible-builds.org/ Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
--- a/debian/patches/reproducible_build.diff 1970-01-01 01:00:00.000000000 +0100 --- b/debian/patches/reproducible_build.diff 2017-05-14 23:53:15.790046364 +0200 @@ -0,0 +1,15 @@ +Description: Make the build reproducible +Author: Chris Lamb <la...@debian.org> +Last-Update: 2017-05-14 + +--- taskcoach-1.4.3.orig/templates.in/make.py ++++ taskcoach-1.4.3/templates.in/make.py +@@ -42,7 +42,7 @@ def dumpDirectory(path): + fd.write('def getDefaultTemplates():\n') + fd.write(' templates = []\n') + +- for name in os.listdir(path): ++ for name in sorted(os.listdir(path)): + dumpTemplate(os.path.join(path, name), fd) + + fd.write('\n return templates\n') --- a/debian/patches/series 2017-05-14 23:50:28.805256147 +0200 --- b/debian/patches/series 2017-05-14 23:53:14.350039551 +0200 @@ -24,3 +24,4 @@ disable_failing_test.diff run_img2py_inside_xvfb.diff missing-import-in-openfile.diff +reproducible_build.diff